Handle Type selector in the Graph Editor's sidebar sets different types than selected #101602

New Issue

Oliver Villar · 2022-10-04T23:45:13+02:00

Oliver Villar commented

2022-10-04 23:45:13 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 517.40

Blender Version
Broken: version: 3.3.0, branch: master, commit date: 2022-09-06 15:39, hash: 0759f671ce
Worked: Don't know if it ever worked before or when.

Short description of error
When choosing the type of handle for a keyframe in the Graph Editor's sidebar, the options don't work as expected. Selecting "Vector" sets the handle to "Free", and selecting "Automatic" or "Auto Clamped" sets it to "Aligned".

Not sure if this is expected behavior, but choosing an option to get a different one be set felt weird. Most of all, I couldn't set it as Vector from there, so I had to press V in the Graph Editor and do it from there. Interestingly, then it appears as "Vector" in the sidebar as well.

I'm attaching a screenshot of the menu I refer to, and a .blend prepared to reproduce the issue (any file with an animation would do).

Exact steps for others to reproduce the error

Create an animation (already present in the attached .blend file)
Open a Graph Editor
Select a keyframe
Open the Graph Editor's sidebar
Try to change the handle type options in the F-Curve tab of the sidebar

Handles Issue.blend

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 517.40 **Blender Version** Broken: version: 3.3.0, branch: master, commit date: 2022-09-06 15:39, hash: `0759f671ce` Worked: Don't know if it ever worked before or when. **Short description of error** When choosing the type of handle for a keyframe in the Graph Editor's sidebar, the options don't work as expected. Selecting "Vector" sets the handle to "Free", and selecting "Automatic" or "Auto Clamped" sets it to "Aligned". Not sure if this is expected behavior, but choosing an option to get a different one be set felt weird. Most of all, I couldn't set it as Vector from there, so I had to press V in the Graph Editor and do it from there. Interestingly, then it appears as "Vector" in the sidebar as well. I'm attaching a screenshot of the menu I refer to, and a .blend prepared to reproduce the issue (any file with an animation would do). ![image.png](https://archive.blender.org/developer/F13615286/image.png) **Exact steps for others to reproduce the error** 1. Create an animation (already present in the attached .blend file) 2. Open a Graph Editor 3. Select a keyframe 4. Open the Graph Editor's sidebar 5. Try to change the handle type options in the F-Curve tab of the sidebar [Handles Issue.blend](https://archive.blender.org/developer/F13615289/Handles_Issue.blend)

Oliver Villar commented

2022-10-04 23:45:13 +02:00

Added subscriber: @OliverVillar

Pratik Borhade commented

2022-10-05 07:55:40 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-10-05 07:55:42 +02:00

Added subscriber: @PratikPB2123

Philipp Oeser commented

2022-10-05 18:34:01 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-10-05 18:34:01 +02:00

handled in these places:

So there seems to be some reasoning behind it, just needs double-checking.

handled in these places: - https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_graph/graph_buttons.c$292 - https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/curve.cc$4087 related commits: - e73cf35f4a - f1f7648d4c So there seems to be some reasoning behind it, just needs double-checking.

Christoph Lendenfeld commented

2022-11-23 10:59:50 +01:00

Added subscriber: @ChrisLend

Christoph Lendenfeld commented

2022-11-23 10:59:50 +01:00

This only works properly if the handles are selected as well. Quite confusing behaviour

Sybren A. Stüvel commented

2022-11-29 13:02:06 +01:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2022-11-29 13:02:06 +01:00

The behaviour seems to stem from f1f7648d4c, back in 2013. From the description it seems reasonable, but I there are some things in there that I don't agree with, at least not given Blender's current architecture. Acting on selection state to change the handle type seems more an activity for an "editor" part of Blender, and not necessarily the "kernel" part. After all, with the current UI, you can change handle types regardless of whether those handles are selected or not, and thus the code that performs this "data sanitation" needs to be aware of what the user was doing at the time.

The behaviour seems to stem from f1f7648d4c, back in 2013. From the description it seems reasonable, but I there are some things in there that I don't agree with, at least not given Blender's current architecture. Acting on selection state to change the handle type seems more an activity for an "editor" part of Blender, and not necessarily the "kernel" part. After all, with the current UI, you can change handle types regardless of whether those handles are selected or not, and thus the code that performs this "data sanitation" needs to be aware of what the user was doing at the time.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Handle Type selector in the Graph Editor's sidebar sets different types than selected #101602