Regression: cyclic curve twist behavior changed/broken #101843

Closed
opened 2022-10-15 18:49:04 +02:00 by Ohtsuki Akira · 13 comments

System Information
platform: 'Windows-10-10.0.19044-SP0'

Blender Version
version: 3.3.1, branch: master, commit date: 2022-10-04 18:35, hash: b292cfe5a9, type: release
build date: 2022-10-05, 00:49:25

Behavior changed in cf72194214

Short description of error
At the between the start and end points is not smooth.
blender-2.93.5-windows-x64 and blender-3.3.1-windows-x64 gives different results.

Exact steps for others to reproduce the error
Look at the image attached ,the same file loaded each.
3.3.1.png

2.93.5.png

You can reproduce it by this.
cylic_bezier_1.blend

Many Thanks,

**System Information** platform: 'Windows-10-10.0.19044-SP0' **Blender Version** version: 3.3.1, branch: master, commit date: 2022-10-04 18:35, hash: b292cfe5a936, type: release build date: 2022-10-05, 00:49:25 Behavior changed in cf72194214 **Short description of error** At the between the start and end points is not smooth. blender-2.93.5-windows-x64 and blender-3.3.1-windows-x64 gives different results. **Exact steps for others to reproduce the error** Look at the image attached ,the same file loaded each. ![3.3.1.png](https://archive.blender.org/developer/F13684241/3.3.1.png) ![2.93.5.png](https://archive.blender.org/developer/F13684240/2.93.5.png) You can reproduce it by this. [cylic_bezier_1.blend](https://archive.blender.org/developer/F13684257/cylic_bezier_1.blend) Many Thanks,
Author

Added subscriber: @tora-trustno1

Added subscriber: @tora-trustno1
Member

Added subscriber: @CharlieJolly

Added subscriber: @CharlieJolly
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Author

I don't know if it will be useful,
but the difference in behavior I'm aware of are follows...

Bevel Result of Start and end points do not connect smoothly.
(even same value of tilt)

Result of Normal (Binormal?) generation is different.

Thanks.

I don't know if it will be useful, but the difference in behavior I'm aware of are follows... Bevel Result of Start and end points do not connect smoothly. (even same value of tilt) Result of Normal (Binormal?) generation is different. Thanks.
Member
Added subscribers: @HooglyBoogly, @Ghaspias, @ideasman42, @lichtwerk
Member

Behavior changed in cf72194214

CC @ideasman42
CC @Ghaspias

Not sure I follow the logic from make_bevel_list_3D_minimum_twist

@HooglyBoogly : maybe it is now time to move to the stuff from CurvesGeometry ? (btw. should calculate_normals_minimum be named calculate_normals_minimum_twist ?)

Behavior changed in cf72194214 CC @ideasman42 CC @Ghaspias Not sure I follow the logic from `make_bevel_list_3D_minimum_twist` @HooglyBoogly : maybe it is now time to move to the stuff from `CurvesGeometry` ? (btw. should `calculate_normals_minimum` be named `calculate_normals_minimum_twist` ?)
Philipp Oeser changed title from Bezier curve behavior changed? to Regression: cyclic curve twist behavior changed/broken 2022-10-17 12:47:12 +02:00
Member

maybe it is now time to move to the stuff from CurvesGeometry

Yes, past time. Rather than doing surgery in this area though (and potentially cause more regressions in the meantime), I think I'd rather wait until we can fully version away the old curve type.

btw. should calculate_normals_minimum be named calculate_normals_minimum_twist

Yeah, sounds better. Feel free to just commit that change :)

>maybe it is now time to move to the stuff from CurvesGeometry Yes, past time. Rather than doing surgery in this area though (and potentially cause more regressions in the meantime), I think I'd rather wait until we can fully version away the old curve type. >btw. should calculate_normals_minimum be named calculate_normals_minimum_twist Yeah, sounds better. Feel free to just commit that change :)

Added subscriber: @BlenderBruno

Added subscriber: @BlenderBruno

FYI, no twist artifact in the GN version of the same curve extrusion (in master 3.5 alpha as of now):

Untitled.png cylic_bezier_1_WITH_GN_TEST.blend
FYI, no twist artifact in the GN version of the same curve extrusion (in master 3.5 alpha as of now): | ![Untitled.png](https://archive.blender.org/developer/F14094116/Untitled.png) | [cylic_bezier_1_WITH_GN_TEST.blend](https://archive.blender.org/developer/F14094115/cylic_bezier_1_WITH_GN_TEST.blend) | | -- | -- |

Added subscriber: @ThomasDinges

Added subscriber: @ThomasDinges

Any updates here? A status update would be appreciated. :)

Any updates here? A status update would be appreciated. :)

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Campbell Barton self-assigned this 2023-01-24 06:44:56 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
8 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#101843
No description provided.