Duplicate items in add node search after adding an asset #102529

New Issue

Closed

opened 2022-11-15 17:30:59 +01:00 by Alexander · 8 comments

Alexander commented

2022-11-15 17:30:59 +01:00

System Information
Operating system: Ubuntu 20.04
Graphics card: Geforce MX230

Blender Version
Broken: 3.4 Beta

Short description of error
If you create a node group in any way, it will be duplicated in the search menu

2022-11-15 19-09-54.mp4

Exact steps for others to reproduce the error
geonodes.zip

Unpack archive, make folder "geonodes" is asset library
Create empty node group, check node search menu (everything will be fine)
Add node group asset from add menu
Check node search menu again, now the error will manifest itself

**System Information** Operating system: Ubuntu 20.04 Graphics card: Geforce MX230 **Blender Version** Broken: 3.4 Beta **Short description of error** If you create a node group in any way, it will be duplicated in the search menu [2022-11-15 19-09-54.mp4](https://archive.blender.org/developer/F13918196/2022-11-15_19-09-54.mp4) **Exact steps for others to reproduce the error** [geonodes.zip](https://archive.blender.org/developer/F13918150/geonodes.zip) 1. Unpack archive, make folder "geonodes" is asset library 2. Create empty node group, check node search menu (everything will be fine) 3. Add node group asset from add menu 4. Check node search menu again, now the error will manifest itself

Alexander commented

2022-11-15 17:30:59 +01:00

Author

Added subscriber: @sanek2005

Added subscriber: @sanek2005

Germano Cavalcante commented

2022-11-16 22:12:31 +01:00

Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2022-11-16 22:12:31 +01:00

Member

Added subscriber: @mano-wii

Added subscriber: @mano-wii

Bastien Montagne added this to the Pipeline, Assets & IO project 2023-02-09 15:39:30 +01:00

Philipp Oeser removed the

Nodes & Physics

label 2023-02-10 08:43:29 +01:00

Philipp Oeser added the

Pipeline, Assets & IO

label 2023-02-10 11:21:26 +01:00

sanek122005 commented

2023-02-15 14:47:49 +01:00

Poke. I noticed one more feature, when creating a node using "false" menu items in the UI of the node, a drop-down list will appear for selecting groups of nodes, this is not observed with the correct menu item. Reproduced in 3.4 and 3.5
Video

Poke. I noticed one more feature, when creating a node using "false" menu items in the UI of the node, a drop-down list will appear for selecting groups of nodes, this is not observed with the correct menu item. Reproduced in 3.4 and 3.5 [Video](https://youtu.be/HdAZxuO5kI0)

Colin Marmond commented

2023-02-15 19:02:58 +01:00

Member

That is an expected behavior I think when seeing this commit (bdb5754). In fact, it is duplicated because of the Asset existing, and the node group now added to the current blender file. This makes duplicates, but in a way it is expected.

@HooglyBoogly could take a quick look and confirm (or not)

That is an expected behavior I think when seeing this commit (bdb5754). In fact, it is duplicated because of the Asset existing, and the node group now added to the current blender file. This makes duplicates, but in a way it is expected. @HooglyBoogly could take a quick look and confirm (or not)

Hans Goudey changed title from ~~Node group assets are dublicated in node search menu, if create this node group though node add menu~~ to Duplicate items in add node search after adding an asset

2023-02-15 19:05:31 +01:00

Hans Goudey commented

2023-02-15 19:06:58 +01:00

Member

Yeah, this is a bug. The search items are meant to be de-duplicated. There is code to do that already (see if (local_assets.contains(node_group->id.name)) {), but apparently it isn't working.

Yeah, this is a bug. The search items are meant to be de-duplicated. There is code to do that already (see `if (local_assets.contains(node_group->id.name)) {`), but apparently it isn't working.

Hans Goudey added this to the 3.5 milestone 2023-02-15 19:07:18 +01:00

Colin Marmond commented

2023-02-15 19:08:54 +01:00

Member

So, what is the behavior expected ? When adding the desired node group, should it be like an asset (no id buttons) or like a regular nodegroup of the file ?

So, what is the behavior expected ? When adding the desired node group, should it be like an asset (no id buttons) or like a regular nodegroup of the file ?

Hans Goudey commented

2023-02-15 19:14:12 +01:00

Member

When adding the desired node group, should it be like an asset (no id buttons) or like a regular nodegroup of the file ?

Currently I think the expected behavior is that if there's an asset with that name, only the asset search item should show up in the list.

>When adding the desired node group, should it be like an asset (no id buttons) or like a regular nodegroup of the file ? Currently I think the expected behavior is that if there's an asset with that name, only the asset search item should show up in the list.

Colin Marmond self-assigned this 2023-02-15 19:16:54 +01:00

Colin Marmond referenced a pull request that will close this issue

2023-02-15 21:49:11 +01:00

Fix #102529 : deduplicate NodeGroups with assets #104793

Hans Goudey referenced this issue from a commit

2023-02-15 22:12:55 +01:00

Fix #102529: De-duplicate add node search items with assets

Hans Goudey closed this issue

2023-02-15 22:13:43 +01:00

Blender Bot added

and removed

labels 2023-02-15 22:13:44 +01:00

sanek122005 referenced this issue

2023-02-16 10:22:32 +01:00

Duplicate of Asset Bundle Node Group in the search #104809

Hans Goudey referenced this issue

2023-02-16 14:24:08 +01:00

Duplicate of Asset Bundle Node Group in the search #104809

Bastien Montagne removed this from the Pipeline, Assets & IO project 2023-07-03 13:03:00 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#102529

No description provided.