Debug Assert for Asset Library Path Context Menu #102591

New Issue

Harley Acheson · 2022-11-17T21:12:07+01:00

Harley Acheson commented

2022-11-17 21:12:07 +01:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 745/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 517.48

Blender Version
Broken: version: 3.5.0 Alpha, branch: Unknown, commit date: Unknown Unknown, hash: rBUnknown
Worked: (newest version of Blender that worked as expected)

Short description of error
Right-clicking on default Asset Libraries path causes debug BLI_assert

Exact steps for others to reproduce the error

Factory Startup File
Factory Preferences
Edit / Preferences / Asset Libraries / right-click in "Path" input box.
BLI_assert failed: ...editors\interface\interface_context_menu.c:442, ui_but_menu_add_path_operators(), at 'subtype == PROP_FILEPATH'

This seems to happen because my default assets path is "C:\Users\Harley\Documents\Blender\Assets", which does not end in a backslash. Within ui_but_menu_add_path_operators we do a BLI_split_dirfile so that we can add different options for paths, depending on whether it is a file path or directory path. In this case, without trailing backslash, it looks like a file so wants to add "Open File Externally" rather than "Open Location Externally". These should both do the same things with different menu names, but the first is guarded by a BLI_assert(subtype == PROP_FILEPATH); and this is PROP_DIRPATH.

I could be relatively unique in having that path without backslash, and/or this might already be fixed for new users, but worth checking.

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 745/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 517.48 **Blender Version** Broken: version: 3.5.0 Alpha, branch: Unknown, commit date: Unknown Unknown, hash: `rBUnknown` Worked: (newest version of Blender that worked as expected) **Short description of error** Right-clicking on default Asset Libraries path causes debug BLI_assert **Exact steps for others to reproduce the error** - Factory Startup File - Factory Preferences - Edit / Preferences / Asset Libraries / right-click in "Path" input box. - BLI_assert failed: ...editors\interface\interface_context_menu.c:442, ui_but_menu_add_path_operators(), at 'subtype == PROP_FILEPATH' ``` ``` This seems to happen because my default assets path is "C:\Users\Harley\Documents\Blender\Assets", which does not end in a backslash. Within `ui_but_menu_add_path_operators` we do a `BLI_split_dirfile` so that we can add different options for paths, depending on whether it is a file path or directory path. In this case, without trailing backslash, it looks like a file so wants to add "Open File Externally" rather than "Open Location Externally". These should both do the same things with different menu names, but the first is guarded by a `BLI_assert(subtype == PROP_FILEPATH);` and this is PROP_DIRPATH. I could be relatively unique in having that path without backslash, and/or this might already be fixed for new users, but worth checking.

Iliya Katushenock commented

2022-11-17 21:18:16 +01:00

I couldn't get a crash in today's master debugging (lite)

![image.png](https://archive.blender.org/developer/F13937943/image.png) I couldn't get a crash in today's master debugging (lite)

Harley Acheson commented

2022-11-17 21:19:28 +01:00

I'm guessing that your path ends with a backslash?

Iliya Katushenock commented

2022-11-17 21:22:24 +01:00

2022-11-17 23-21-22.mp4

[2022-11-17 23-21-22.mp4](https://archive.blender.org/developer/F13937953/2022-11-17_23-21-22.mp4)

Harley Acheson commented

2022-11-17 21:30:56 +01:00

If I select a NEW folder, then that path does include the backslash and works correctly.

But I can delete my local preferences from my "config" folder, launch Blender, NOT load old settings, and that path is without backslash.

I think this is caused by BKE_preferences_asset_library_default_add, which looks for documents folder then uses BLI_path_join on that, N_("Blender"), and N_("Assets"). This wouldn't append a backslash to the end AFAIK.

There is a comment above it that says /* Add new "Default" library under '[doc_path]/Blender/Assets'. */ which also shows it without trailing slash

If I select a NEW folder, then that path does include the backslash and works correctly. But I can delete my local preferences from my "config" folder, launch Blender, NOT load old settings, and that path is without backslash. I _think_ this is caused by `BKE_preferences_asset_library_default_add`, which looks for documents folder then uses `BLI_path_join` on that, `N_("Blender")`, and `N_("Assets")`. This wouldn't append a backslash to the end AFAIK. There is a comment above it that says `/* Add new "Default" library under '[doc_path]/Blender/Assets'. */` which also shows it without trailing slash

Harley Acheson commented

2022-11-17 21:35:12 +01:00

yes needs something like:

diff --git a/source/blender/blenkernel/intern/preferences.c b/source/blender/blenkernel/intern/preferences.c
index dd76f9eddc17..658628f19db7 100644
--- a/source/blender/blenkernel/intern/preferences.c
+++ b/source/blender/blenkernel/intern/preferences.c
@@ -114,8 +114,9 @@ void BKE_preferences_asset_library_default_add(UserDef *userdef)
   bUserAssetLibrary *library = BKE_preferences_asset_library_add(
       userdef, DATA_(BKE_PREFS_ASSET_LIBRARY_DEFAULT_NAME), NULL);
 
-  /* Add new "Default" library under '[doc_path]/Blender/Assets'. */
-  BLI_path_join(library->path, sizeof(library->path), documents_path, N_("Blender"), N_("Assets"));
+  /* Add new "Default" library under '[doc_path]/Blender/Assets/'. */
+  BLI_path_join(
+      library->path, sizeof(library->path), documents_path, N_("Blender"), N_("Assets"), SEP_STR);
 }
 
 /** \} */

yes needs something like: ``` diff --git a/source/blender/blenkernel/intern/preferences.c b/source/blender/blenkernel/intern/preferences.c index dd76f9eddc17..658628f19db7 100644 --- a/source/blender/blenkernel/intern/preferences.c +++ b/source/blender/blenkernel/intern/preferences.c @@ -114,8 +114,9 @@ void BKE_preferences_asset_library_default_add(UserDef *userdef) bUserAssetLibrary *library = BKE_preferences_asset_library_add( userdef, DATA_(BKE_PREFS_ASSET_LIBRARY_DEFAULT_NAME), NULL); - /* Add new "Default" library under '[doc_path]/Blender/Assets'. */ - BLI_path_join(library->path, sizeof(library->path), documents_path, N_("Blender"), N_("Assets")); + /* Add new "Default" library under '[doc_path]/Blender/Assets/'. */ + BLI_path_join( + library->path, sizeof(library->path), documents_path, N_("Blender"), N_("Assets"), SEP_STR); } /** \} */ ```

Harley Acheson self-assigned this 2022-11-17 21:37:53 +01:00

Bastien Montagne added this to the Pipeline, Assets & IO project 2023-02-09 15:39:30 +01:00

Dalai Felinto commented

2023-10-03 12:18:13 +02:00

For the records, this still happens. @Harley are you still planning to fix that? Otherwise better to unassign yourself from it.

Harley Acheson commented

2023-10-03 17:29:54 +02:00

For the records, this still happens. @Harley are you still planning to fix that? Otherwise better to unassign yourself from it.

Yikes. Yes, this report was before before we got multiple asset paths and it was all moved into the "File Path" area. I assumed (wrongly) that this was no longer a problem, but can recreate the issue now. Will fix ASAP.

> For the records, this still happens. @Harley are you still planning to fix that? Otherwise better to unassign yourself from it. Yikes. Yes, this report was before before we got multiple asset paths and it was all moved into the "File Path" area. I assumed (wrongly) that this was no longer a problem, but can recreate the issue now. Will fix ASAP.

Harley Acheson referenced a pull request that will close this issue

2023-10-03 18:38:45 +02:00

Fix #102591: Improvements to Context Menu Path Operators #113216

Harley Acheson referenced this issue from a commit

2023-10-03 18:45:06 +02:00

Fix #102591: Improvements to Context Menu Path Operators

Harley Acheson closed this issue

2023-10-03 18:45:09 +02:00

Blender Bot added

Status

Resolved

and removed