Translation is not displayed in the node attribute interface #102721

New Issue

917037493@qq.com · 2022-11-23T17:05:30+01:00

917037493@qq.com commented

2022-11-23 17:05:30 +01:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.49

Blender Version
Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-22 00:01, hash: 89349067b6
Worked: (newest version of Blender that worked as expected)

Translation is not displayed in the node attribute interface.
![4IN6Y]W3OTB6@}K9$PW~4L.png
Shaders can translate languages, but there is no translation language in the property panel of geometric nodes.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.49 **Blender Version** Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-22 00:01, hash: `89349067b6` Worked: (newest version of Blender that worked as expected) Translation is not displayed in the node attribute interface. ![4IN6Y]W3O[TB6@}K9$PW~4L.png](https://archive.blender.org/developer/F13963653/4IN6Y_W3O_TB6__K9_PW_4L.png) Shaders can translate languages, but there is no translation language in the property panel of geometric nodes. ![X@@KXLBM9W@5OK%{BNZRN@R.png](https://archive.blender.org/developer/F13963655/X__KXLBM9W_5OK__BNZRN_R.png)

917037493@qq.com commented

2022-11-23 17:05:30 +01:00

Added subscriber: @chen13547542093

Iliya Katushenock commented

2022-11-23 17:18:21 +01:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2022-11-23 17:18:21 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Iliya Katushenock commented

2022-11-23 17:18:21 +01:00

I saw this offer on RCS. Since it didn't happen before, it's not a regression. But yes, it makes sense.

Charlie Jolly commented

2022-11-23 17:21:11 +01:00

Added subscriber: @CharlieJolly

Hans Goudey commented

2022-11-23 20:44:03 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2022-11-23 20:44:03 +01:00

Thatnks for the report. It looks like we should use DATA_ on the node socket names/labels for translation when creating the new interface sockets for the group.

Thatnks for the report. It looks like we should use `DATA_` on the node socket names/labels for translation when creating the new interface sockets for the group.

Hans Goudey commented

2022-11-23 23:18:48 +01:00

Added subscriber: @pioverfour

Hans Goudey commented

2022-11-23 23:18:48 +01:00

@pioverfour, are you interested in looking into this? I'm guessing it would involve changes around ntreeAddSocketInterfaceFromSocket.

@pioverfour, are you interested in looking into this? I'm guessing it would involve changes around `ntreeAddSocketInterfaceFromSocket`.

Hans Goudey commented

2022-11-23 23:20:40 +01:00

Actually, I think my thought above is totally wrong. The labels on the "Group Input" socket are clearly translated here, so maybe this is as simple as using IFACE_ in the modifier panel and the group sockets list. This is also user-created data though, I'm not sure how this influences that decision.

Actually, I think my thought above is totally wrong. The labels on the "Group Input" socket are clearly translated here, so maybe this is as simple as using `IFACE_` in the modifier panel and the group sockets list. This is also user-created data though, I'm not sure how this influences that decision.

Damien Picard commented

2022-11-24 00:04:38 +01:00

Added subscriber: @mont29

Damien Picard commented

2022-11-24 00:04:38 +01:00

Hello, I think this needs a bit of discussion. In my opinion, the current behaviour is the proper one, as these names are user data. They should only be translated on creation (made easier in D15763), using DATA_ as you suggested, but already-created inputs or outputs shouldn’t be translated, even in the node itself. This idea of not translating at display time was actually proposed in D15531 but the patch was rejected. Here is what I wrote at the time:

The rationale is, say you work in German but explicitly name your socket in English, "Color" and it gets translated to "Farbe" in the interface, but not in the actual socket name. That's confusing.

But then again maybe that’s just me, and I can see users may want labels to be translated to their language, even if those labels were defined in English. So, no strong opinion from me. @mont29, care to weigh in?

Hello, I think this needs a bit of discussion. In my opinion, the current behaviour is the proper one, as these names are user data. They should only be translated on creation (made easier in [D15763](https://archive.blender.org/developer/D15763)), using `DATA_` as you suggested, but already-created inputs or outputs shouldn’t be translated, even in the node itself. This idea of not translating at display time was actually proposed in [D15531](https://archive.blender.org/developer/D15531) but the patch was rejected. Here is what I wrote at the time: > The rationale is, say you work in German but explicitly name your socket in English, "Color" and it gets translated to "Farbe" in the interface, but not in the actual socket name. That's confusing. But then again maybe that’s just me, and I can see users may want labels to be translated to their language, even if those labels were defined in English. So, no strong opinion from me. @mont29, care to weigh in?

Iliya Katushenock commented

2022-11-24 05:59:17 +01:00

Most often you use this for clients with your node groups, so translating only the user part, not realizations, is the norm

Bastien Montagne added this to the User Interface project 2023-02-09 15:34:10 +01:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Translation is not displayed in the node attribute interface #102721