Cycles HIPRT device #104110

Open
opened 2023-01-24 01:33:49 +01:00 by Sahar A. Kashi · 13 comments
Member

Known Issues

  • The BVH builder doesn't efficiently handle degenerate triangles. For certain contents this might lead to performance slowdown or crash. We currently have a fix in HIP RT SDK to handle the crash, but the change is not yet part of our driver distribution.
  • Soft shadow on hair doesn't look right in certain cases. This seems to be a regression. Images from previous test results of the same scenes look correct. We are working to find the regression point.
  • Objects with motion blur are not rendered correctly. This is also a regression, and we have a rough idea of the change that broke motion blur.
  • Shadow linking not working (probably similar fixed as was needed for Metal #112012)
  • No Linux support

Background

HIPRT enables hardware ray tracing on AMD cards utilizing HIPRT SDK.

HIPRT SDK allows the developer to build the bvh on the GPU with different methods and trade-offs. It also allows for user defined primitives and intersection. The device side of the SDK provides traversal functions. In order to compile the kernels using traversal, the kernels must be compiled through the runtime compiler function that HIPRT SDK supplies.

HIPRTDevice and HIPRTDeviceQueue, derived from HIP, implement new functions or override existing functions to enable HIP ray tracing on the host. side.

### Known Issues - [ ] The BVH builder doesn't efficiently handle degenerate triangles. For certain contents this might lead to performance slowdown or crash. We currently have a fix in HIP RT SDK to handle the crash, but the change is not yet part of our driver distribution. - [x] Soft shadow on hair doesn't look right in certain cases. This seems to be a regression. Images from previous test results of the same scenes look correct. We are working to find the regression point. - [x] Objects with motion blur are not rendered correctly. This is also a regression, and we have a rough idea of the change that broke motion blur. - [ ] Shadow linking not working (probably similar fixed as was needed for Metal #112012) - [ ] No Linux support ### Background HIPRT enables hardware ray tracing on AMD cards utilizing HIPRT SDK. HIPRT SDK allows the developer to build the bvh on the GPU with different methods and trade-offs. It also allows for user defined primitives and intersection. The device side of the SDK provides traversal functions. In order to compile the kernels using traversal, the kernels must be compiled through the runtime compiler function that HIPRT SDK supplies. HIPRTDevice and HIPRTDeviceQueue, derived from HIP, implement new functions or override existing functions to enable HIP ray tracing on the host. side.
Brecht Van Lommel added this to the Render & Cycles project 2023-02-07 19:08:06 +01:00
Philipp Oeser removed the
Interest
Render & Cycles
label 2023-02-09 14:04:23 +01:00
Author
Member

Known issues and To-Dos:

  1. The BVH builder doesn't efficiently handle degenerate triangles. For certain contents this might lead to performance slowdown or crash. We currently have a fix in HIP RT SDK to handle the crash, but the change is not yet part of our driver distribution.

  2. Soft shadow on hair doesn't look right in certain cases. This seems to be a regression. Images from previous test results of the same scenes look correct. We are working to find the regression point.

  3. Objects with motion blur are not rendered correctly. This is also a regression, and we have a rough idea of the change that broke motion blur.

Known issues and To-Dos: 1. The BVH builder doesn't efficiently handle degenerate triangles. For certain contents this might lead to performance slowdown or crash. We currently have a fix in HIP RT SDK to handle the crash, but the change is not yet part of our driver distribution. 2. Soft shadow on hair doesn't look right in certain cases. This seems to be a regression. Images from previous test results of the same scenes look correct. We are working to find the regression point. 3. Objects with motion blur are not rendered correctly. This is also a regression, and we have a rough idea of the change that broke motion blur.
Brecht Van Lommel removed the
Status
Needs Triage
label 2023-05-15 13:54:03 +02:00

No Linux support

Do you mean HIP-RT has no Linux support or Cycles' HIP renderer has no Linux support?

cause : gambar

> No Linux support Do you mean HIP-RT has no Linux support or Cycles' HIP renderer has no Linux support? cause : ![gambar](/attachments/2db48c6c-9fc4-4d0e-b82c-3baf07897e4a)

No Linux support

Do you mean HIP-RT has no Linux support or Cycles' HIP renderer has no Linux support?

cause : gambar

Queue up support one by one, c++ is not python

> > No Linux support > > Do you mean HIP-RT has no Linux support or Cycles' HIP renderer has no Linux support? > > cause : ![gambar](/attachments/2db48c6c-9fc4-4d0e-b82c-3baf07897e4a) Queue up support one by one, c++ is not python

@salipour @BrianSavery is there any update on fixing the remaining issues? Besides Linux support which I understand will be for 4.0.

We still have 2 weeks for 3.6 bugfixes, and then 1 more week for fixes that are critical and relatively low risk.

@salipour @BrianSavery is there any update on fixing the remaining issues? Besides Linux support which I understand will be for 4.0. We still have 2 weeks for 3.6 bugfixes, and then 1 more week for fixes that are critical and relatively low risk.
Author
Member

@salipour @BrianSavery is there any update on fixing the remaining issues? Besides Linux support which I understand will be for 4.0.

We still have 2 weeks for 3.6 bugfixes, and then 1 more week for fixes that are critical and relatively low risk.

I submitted changes for motion blur issue and some other minor bugs.

> @salipour @BrianSavery is there any update on fixing the remaining issues? Besides Linux support which I understand will be for 4.0. > > We still have 2 weeks for 3.6 bugfixes, and then 1 more week for fixes that are critical and relatively low risk. I [submitted ](https://projects.blender.org/salipour/AMD_HIPRT/commit/a49c4180015a5c964159e4b0eb8ba6e0efa56065)changes for motion blur issue and some other minor bugs.

Differences with Hair and the other one with degenerate triangles are still in progress. I doubt for 3.6.

Differences with Hair and the other one with degenerate triangles are still in progress. I doubt for 3.6.

Thanks for the info.

@salipour can you submit that as a pull request targetting the blender-v3.6-release branch?

Thanks for the info. @salipour can you submit that as a pull request targetting the `blender-v3.6-release` branch?

Any update? Shall I just merge these changes myself?

I'd leave out -parallel-jobs=15, that kind of thing can make the buildbot run out of memory.

Any update? Shall I just merge these changes myself? I'd leave out `-parallel-jobs=15`, that kind of thing can make the buildbot run out of memory.
Author
Member

Any update? Shall I just merge these changes myself?

I'd leave out -parallel-jobs=15, that kind of thing can make the buildbot run out of memory.

oh! I thought I rebased. Is this pull request targeted properly to 3.6 bracnh?

> Any update? Shall I just merge these changes myself? > > I'd leave out `-parallel-jobs=15`, that kind of thing can make the buildbot run out of memory. oh! I thought I rebased. Is this pull [request](https://projects.blender.org/blender/blender/compare/blender-v3.6-release...salipour/AMD_HIPRT:blender-v3.6-release) targeted properly to 3.6 bracnh?

Yes, it's targetted properly. Can you leave out the -parallel-jobs=15 part, update the title and add a description of the changes?

Yes, it's targetted properly. Can you leave out the `-parallel-jobs=15` part, update the title and add a description of the changes?
Author
Member

Alright! I just pushed it.

Alright! I just pushed it.

Hi guys, any update on linux support for the HIP-RT?

Hi guys, any update on linux support for the HIP-RT?

Not much else, just a question: the BVH generator does not handle degenerate triangles efficiently. For some content, this may cause performance degradation or crashes. We have now fixed the crashing issue in the HIP RT SDK, but the change has not yet been incorporated into our driver distribution.
When will this entry be checked off in the task list?

Not much else, just a question: the BVH generator does not handle degenerate triangles efficiently. For some content, this may cause performance degradation or crashes. We have now fixed the crashing issue in the HIP RT SDK, but the change has not yet been incorporated into our driver distribution. When will this entry be checked off in the task list?
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104110
No description provided.