Regession: Smooth modifier with vergex group not work for negative factors #104176

New Issue

Alexandr · 2023-01-27T13:59:29+01:00

Alexandr commented

2023-01-27 13:59:29 +01:00

System Information
Operating system: Debian Testing
Graphics card: RTX 3090

Blender Version
Broken: version: 2.82 (sub 6), branch: master, commit date: 2019-12-23 22:37, hash: b450ba84d9
Worked: version: 2.81 (sub 1), branch: master, commit date: 2019-08-09 18:48, hash: a571ff2c16

Caused by: abc8d6b12c
Commit add if (f_new <= 0.0f) {continue;} case for vertext group mode

Short description of error
When Smooth modifier with Vergex Group don't work for negative factor value. Works only for positive values.

#104176.blend

Exact steps for others to reproduce the error

Apply "simple" subdivide to cube
Create vertex group and add at least 1 verticle to it
Add "Smooth" modifier, select vertex group and set factor to any negative value.

**System Information** Operating system: Debian Testing Graphics card: RTX 3090 **Blender Version** Broken: version: 2.82 (sub 6), branch: master, commit date: 2019-12-23 22:37, hash: `b450ba84d9` Worked: version: 2.81 (sub 1), branch: master, commit date: 2019-08-09 18:48, hash: `a571ff2c16` Caused by: abc8d6b12c *Commit add `if (f_new <= 0.0f) {continue;}` case for vertext group mode* **Short description of error** When Smooth modifier with Vergex Group don't work for negative factor value. Works only for positive values. [#104176.blend](https://archive.blender.org/developer/F14218301/T104176.blend) **Exact steps for others to reproduce the error** 1. Apply "simple" subdivide to cube 2. Create vertex group and add at least 1 verticle to it 3. Add "Smooth" modifier, select vertex group and set factor to any negative value.

Alexandr commented

2023-01-27 13:59:29 +01:00

Added subscriber: @scaled

Iliya Katushenock commented

2023-01-27 14:08:25 +01:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2023-01-27 14:08:25 +01:00

I not sure that negative factor is really work case so thinking that that not a bug.

Alexandr commented

2023-01-27 14:11:39 +01:00

I use Smooth with -1 factor before Subdivision, so my models will not loose volume and little details. But now i need to apply this modifier only to some part of the model. I probably can work around that, but it worked so well in Blender 2.79b, so why it's not present in current version?

Iliya Katushenock commented

2023-01-27 14:15:24 +01:00

Okay, will check this, maybe regression

Iliya Katushenock changed title from ~~Smooth modifier with vergex group not work for negative factors~~ to Regession: Smooth modifier with vergex group not work for negative factors

2023-01-27 14:52:59 +01:00

Iliya Katushenock commented

2023-01-27 14:52:59 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Iliya Katushenock commented

2023-01-27 14:53:51 +01:00

I did not find information about this in the release notes, nor in the commit message.

Philipp Oeser commented

2023-01-31 09:00:01 +01:00

Added subscribers: @mont29, @lichtwerk

Philipp Oeser commented

2023-01-31 09:00:01 +01:00

@mod_moder : please always tag the module (and not only a submodule)
Also: this changed 3.5 years ago, what makes you think this is the highest priority we have? (usually we only assign High priority to regressions if they are recent [meaning younger than ~6 months])

CC @mont29

@mod_moder : please always tag the module (and not only a submodule) Also: this changed 3.5 years ago, what makes you think this is the highest priority we have? (usually we only assign High priority to regressions if they are recent [meaning younger than ~6 months]) CC @mont29

Iliya Katushenock commented

2023-01-31 09:35:00 +01:00

It seemed that the regression itself was high priority, so did not pay attention to the date, yes ...

Bastien Montagne self-assigned this 2023-01-31 09:43:14 +01:00

Bastien Montagne commented

2023-01-31 09:43:14 +01:00

This was indeed not an intended change, funny it took so long for someone to notice and report that bug. :)