Regression: Blender crash in weight paint mode and vertex select checked and then weights -> fix deforms #104358
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.50
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-09-09 00:25, hash:
Worked: version: 3.4.0 Alpha, branch: arcpatch-D15914, commit date: 2022-09-08 15:28, hash:
Simplified short description of error
Blender crashes if try to call
Fix Deforms operator if
Vertex Selection is enable and no one selected vertex haven't weight of selected bone.
Short description of error
Blender crash in weight paint mode and vertex select is clicked and then you click on Weights -> Fix Deforms.
Exact steps for others to reproduce the error
EDIT: simplified with demo file
- Open the file
- Click on Weights->Fix Deform
Start blender and load factory settings.
Toggle x-ray mode. (Makes it simpler to see)
Select default cube and tab into edit mode.
Make a horisontal loop cut.
Tab out of edit mode.
Add Armature -> Single bone.
Move the bone down 1. g + z - 1
With the armature selected, tab into edit mode.
Extrude the tip up 1. e + z + 1
Change viewport display for the armature to be "In Front". (Makes it simpler to see)
Select default cube and shift select the armature.
Ctrl+P -> Set Parent To -> Armature Deform With Automatic Weights
Select armature and shift select default cube.
Go into Weight Paint mode.
Select the top bone.
Click on Vertex Select. Make sure some vertexes are selected.
Click on Weights -> Fix Deforms
This looks a lot like #69004 Weight Paint - Fix Deform crash . Except the last step "Adjust the options at the bottom of viewport" is not needed.
Debug logs. There's an error in what the blender_system_info.txt shows. If I enable an add-on. like rigify, then click on File ->Defaults -> Load Factory Settings. Then click on Preferences -> Add-ons and search for rigify I see it's not enabled. But blender_system_info.txt shows it as an enabled add-on.
Also "Load Factory Settings" doesn't load blender as when downloaded, which I thought. It' seen in step 6. If I disable rigify there's no option "Single bone" when adding an armature. But if it's enabled and then loading factory settings "single bone" is still there. I have manually disabled rigify and other add-ons but the crash is still happens.
Changed status from 'Needs Triage' to: 'Confirmed'
d593497421 . But nothing more than a witch hunt
Stack trace on current master:
lines=5 blender.exe :0x00007FF68DF5E570 moveCloserToDistanceFromPlane C:\blender-git\blender\source\blender\editors\object\object_vgroup.cc:1428 blender.exe :0x00007FF68DF62510 vgroup_fix C:\blender-git\blender\source\blender\editors\object\object_vgroup.cc:1568 blender.exe :0x00007FF68DF5FB80 vertex_group_fix_exec C:\blender-git\blender\source\blender\editors\object\object_vgroup.cc:3370 blender.exe :0x00007FF68D68ABB0 wm_operator_invoke C:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.cc:1515 blender.exe :0x00007FF68D68A1B0 wm_operator_call_internal C:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.cc:1706 blender.exe :0x00007FF68D68D1E0 WM_operator_name_call_ptr_with_depends_on_cursor C:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.cc:1945 blender.exe :0x00007FF68E101980 ui_apply_but_funcs_after C:\blender-git\blender\source\blender\editors\interface\interface_handlers.cc:1019 blender.exe :0x00007FF68E10D220 ui_handler_region_menu C:\blender-git\blender\source\blender\editors\interface\interface_handlers.cc:11422 blender.exe :0x00007FF68D689620 wm_handlers_do_intern C:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.cc:3278 blender.exe :0x00007FF68D688A50 wm_handlers_do C:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.cc:3398 blender.exe :0x00007FF68D68F0F0 wm_event_do_handlers C:\blender-git\blender\source\blender\windowmanager\intern\wm_event_system.cc:3991 blender.exe :0x00007FF68D674490 WM_main C:\blender-git\blender\source\blender\windowmanager\intern\wm.c:644 blender.exe :0x00007FF68D169D60 main C:\blender-git\blender\source\creator\creator.c:590 blender.exe :0x00007FF692B598B4 __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 KERNEL32.DLL :0x00007FFEA75F7600 BaseThreadInitThunk ntdll.dll :0x00007FFEA8102680 RtlUserThreadStart
05952aa94d (second time commenting to check the bot that should mention this in the commit)
Since this was apparently caused by a patch tagged as "Core" (D15488), I'll re-label this with 'Module > Core'.
Honestly think this is more of a Modelling module responsibility... This is really an 'internal affair' of Mesh data.
I'll unassign myself since the operator will most likely be removed.
Not much info out there on
Fix Deforms (was just curious if people are actuay using it), just putting this up for reference: https://archive.blender.org/wiki/index.php/User:Jason_hays22/GSoC-2011/
Was introduced with
I have a PR ready for removal of the operator: #105237
Since #105237 was merged, I think this report can be closed. There is no more "Fix Deforms" operator.
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?