OBJ: Support polylines with more than 2 vertices. #104503

Martin Heistermann · 2023-02-09T11:14:27+01:00

2023-02-09 11:14:27 +01:00

The OBJ spec (page B1-17) allows "l" entries to specify
polylines with more than 2 vertices, optionally with texture
coordinates.

Previously, only the first 2 vertices of each polyline
were read and added as loose edges, failing when texture
coordinates were present.

This adds support for proper polylines, reading but ignoring
texture coordinates.

The OBJ spec (page B1-17) allows "l" entries to specify polylines with more than 2 vertices, optionally with texture coordinates. Previously, only the first 2 vertices of each polyline were read and added as loose edges, failing when texture coordinates were present. This adds support for proper polylines, reading but ignoring texture coordinates.

Martin Heistermann requested review from Aras Pranckevicius 2023-02-09 11:20:34 +01:00

Martin Heistermann commented

2023-02-09 11:30:34 +01:00

This used to be https://archive.blender.org/developer/D17215

Martin Heistermann commented

2023-02-09 12:08:17 +01:00

@aras_p I hope it's okay I added you as reviewer (can't un-assign you anyways :/), looking into commit history and reading your blog before, you appear to be a main developer of the OBJ importer.

I'll be happy about any comments & suggestions for improvement from other developers too, of course :)

@aras_p I hope it's okay I added you as reviewer (can't un-assign you anyways :/), looking into commit history and reading your blog before, you appear to be a main developer of the OBJ importer. I'll be happy about any comments & suggestions for improvement from other developers too, of course :)

Aras Pranckevicius commented

2023-02-09 15:03:10 +01:00

Code looks good to me! Would be nice to have some test coverage; do you have a relatively simple .obj file that uses this?

Martin Heistermann commented

2023-02-10 10:04:26 +01:00

I created a very simple test file with a few lines and polylines, including some with (bogus) texture coords, as well as out-of-bounds vertex references (polylines_artificial.obj).

I'm also attaching the file I had uploaded in D17215 which contains less variety but is not synthetic.

I created a very simple test file with a few lines and polylines, including some with (bogus) texture coords, as well as out-of-bounds vertex references (polylines_artificial.obj). I'm also attaching the file I had uploaded in D17215 which contains less variety but is not synthetic.

polylines_realworld.obj

66 KiB

polylines_artificial.obj

265 B

Martin Heistermann force-pushed dev/mh/obj-polyline-support from 6e3ce1193d to b7752b176e

2023-02-11 20:27:17 +01:00

Compare

Martin Heistermann commented

2023-02-11 20:29:31 +01:00

I added a rudimentary test that expects the previously attached polylines_artificial.obj as io_tests/obj/polylines.obj in the test data repo.

In line with the existing tests, it checks for number of vertices/edges, as well as the position of the first and last vertex. Admittedly, more extensive tests would be nice.

I also rebased my branch to current main.

I added a rudimentary test that expects the previously attached `polylines_artificial.obj` as `io_tests/obj/polylines.obj` in the test data repo. In line with the existing tests, it checks for number of vertices/edges, as well as the position of the first and last vertex. Admittedly, more extensive tests would be nice. I also rebased my branch to current main.

👍 1

Brecht Van Lommel added this to the Pipeline, Assets & IO project 2023-02-13 09:18:48 +01:00

Aras Pranckevicius merged commit cfe828b452 into main

2023-02-14 16:31:02 +01:00

Aras Pranckevicius referenced this issue from a commit

2023-02-14 16:31:03 +01:00

OBJ: Support polylines with more than 2 vertices.

Aras Pranckevicius referenced this pull request

2023-05-30 21:28:16 +02:00

IO: remove OBJ and PLY Python add-ons (#104503, #104504) #108440

Aras Pranckevicius referenced this issue from a commit

2023-05-30 21:41:32 +02:00