Animation: Add Slider operators to hotkey menu #104530

Merged
Christoph Lendenfeld merged 8 commits from ChrisLend/blender:graph_slider_menu into main 2023-02-23 09:29:30 +01:00

Currently the slider operators for the Graph Editor are not easily accessible since they don't have a hotkey.
While we could go down the route of giving each operator it's own hotkey, I can see a lot more operators being added in the future, so we need an option that scales better.

I think the most "Blender" way of doing that would be to use a popup menu such as when you press T in the graph editor to change the interpolation type.

That has the advantage, that your last used operator will always be under the cursor, so it's quick to access.
(It would be far better if pressing the hotkey twice would trigger it as well, but that's beside the point)

Additionally we can group operators to different popups
Currently they trigger with D (just because that wasn't used) but we could add another menu that triggers e.g. with SHIFT + D when we need to regroup

That is also the reason why I made a completely new operator instead of refactoring the existing operators into 1 with an enum.

Instead of making a new C operator with an enum and such, it is much simpler to go through python instead. In this case I am just reusing the existing menu, but it's even easier to change in the future.


original phabricator patch
https://archive.blender.org/developer/D17192

Currently the slider operators for the Graph Editor are not easily accessible since they don't have a hotkey. While we could go down the route of giving each operator it's own hotkey, I can see a lot more operators being added in the future, so we need an option that scales better. I think the most "Blender" way of doing that would be to use a popup menu such as when you press T in the graph editor to change the interpolation type. That has the advantage, that your last used operator will always be under the cursor, so it's quick to access. (It would be far better if pressing the hotkey twice would trigger it as well, but that's beside the point) Additionally we can group operators to different popups Currently they trigger with D (just because that wasn't used) but we could add another menu that triggers e.g. with SHIFT + D when we need to regroup ~~That is also the reason why I made a completely new operator instead of refactoring the existing operators into 1 with an enum.~~ Instead of making a new C operator with an enum and such, it is much simpler to go through python instead. In this case I am just reusing the existing menu, but it's even easier to change in the future. ----- original phabricator patch https://archive.blender.org/developer/D17192
Christoph Lendenfeld added 5 commits 2023-02-09 17:45:04 +01:00
Author
Member

video demo

video demo
Christoph Lendenfeld added the
Module
Animation & Rigging
label 2023-02-09 17:50:18 +01:00
Christoph Lendenfeld requested review from Sybren A. Stüvel 2023-02-09 17:50:28 +01:00

Apart from the submodule change (that shouldn't be in this PR) the code LGTM. This is something to be discussed with animators, though, so I won't press the accept button just yet.

I'll add this to the agenda of the next module meeting. If there wasn't a decision before that time already, we can decide during the meeting.

Apart from the submodule change (that shouldn't be in this PR) the code LGTM. This is something to be discussed with animators, though, so I won't press the accept button just yet. I'll add this to the agenda of the next module meeting. If there wasn't a decision before that time already, we can decide during the meeting.
Brecht Van Lommel added this to the Animation & Rigging project 2023-02-13 09:13:36 +01:00
Christoph Lendenfeld added 1 commit 2023-02-16 11:39:39 +01:00
Christoph Lendenfeld added 1 commit 2023-02-16 11:41:00 +01:00
Christoph Lendenfeld requested review from Luciano Muñoz Sessarego 2023-02-16 11:41:44 +01:00
First-time contributor

I think this is the way to go.
But i dont know how to approve things in this new platform :(

I think this is the way to go. But i dont know how to approve things in this new platform :(
Sybren A. Stüvel approved these changes 2023-02-17 15:59:22 +01:00
Sybren A. Stüvel left a comment
Member

I think 'D' is fine when it comes to the hotkey. It's the first one that's still free in the word "Slider", which IMO is good enough.

I think 'D' is fine when it comes to the hotkey. It's the first one that's still free in the word "Slider", which IMO is good enough.
Christoph Lendenfeld added 1 commit 2023-02-23 09:22:41 +01:00
Christoph Lendenfeld merged commit 8756671084 into main 2023-02-23 09:29:30 +01:00
Christoph Lendenfeld deleted branch graph_slider_menu 2023-02-23 09:29:30 +01:00
Sybren A. Stüvel removed this from the Animation & Rigging project 2023-03-02 17:01:01 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104530
No description provided.