Define author of bundle essential assets #105250

New Issue

Dalai Felinto · 2023-02-27T15:35:41+01:00

Dalai Felinto commented

2023-02-27 15:35:41 +01:00

Right now we are crediting Blender Studio for the Hair node group essential bundle.

I want to revisit or confirm this decision before 3.5 is out.

Right now we are crediting Blender Studio for the Hair node group essential bundle. I want to revisit or confirm this decision before 3.5 is out.

Dalai Felinto added this to the 3.5 milestone 2023-02-27 15:35:41 +01:00

Dalai Felinto added the

Type

To Do

label 2023-02-27 15:35:41 +01:00

Dalai Felinto self-assigned this 2023-02-27 15:35:42 +01:00

Dalai Felinto added this to the Nodes & Physics project 2023-02-27 15:35:42 +01:00

Dalai Felinto commented

2023-03-02 16:25:33 +01:00

The conclusion was to have copyright and license as new meta-data entries.

This is fully described on #105300 and implemented on #105318.

The conclusion was to have copyright and license as new meta-data entries. This is fully described on #105300 and implemented on #105318.

Julian Eisel added the

Interest

Asset Browser

label 2023-03-06 16:53:09 +01:00

Dalai Felinto commented

2023-03-17 14:43:20 +01:00

For the records, this is the conclusion of the discussions I had at the Blender HQ with Ton, Francesco and Simmon. Eventually this should be moved to the wiki, to a page explaning the bundled assets.

License: CC0
Copyright: Blender Foundation
Author: {leave it empty}

There is no dispute regarding License and Copyright. But let me lay down the reasoning for the author:

Having specific authors for official assets is really hard to manage.

The moment someone tweaks the asset, fix an issue, extend its functionality, that person should be added as co-author. The same if someone creates a new node specific for a node group asset.

We already run into this same issue for add-ons. And we used to run on this for individual copyright attributions in the source code.

For the records, this is the conclusion of the discussions I had at the Blender HQ with Ton, Francesco and Simmon. Eventually this should be moved to the wiki, to a page explaning the bundled assets. * License: CC0 * Copyright: Blender Foundation * Author: {leave it empty} There is no dispute regarding License and Copyright. But let me lay down the reasoning for the author: Having specific authors for official assets is really hard to manage. The moment someone tweaks the asset, fix an issue, extend its functionality, that person should be added as co-author. The same if someone creates a new node specific for a node group asset. We already run into this same issue for add-ons. And we used to run on this for individual copyright attributions in the source code.

Brecht Van Lommel commented

2023-03-21 19:00:01 +01:00

This is one of the few remaining open issues for 3.5. Is there anything to be done here still before that release? Is it clear who will do it?

CC @Harley @JulianEisel

This is one of the few remaining open issues for 3.5. Is there anything to be done here still before that release? Is it clear who will do it? CC @Harley @JulianEisel

Harley Acheson commented

2023-03-21 19:11:54 +01:00

@brecht - Is there anything to be done here still before that release?

There is a related unreviewed PR #105812 that makes it so that meta-fields that are both blank and read-only are not shown. That way bundled Essential Assets can leave a field blank, like author, and it will just not appear to users.

> @brecht - Is there anything to be done here still before that release? There is a related unreviewed PR #105812 that makes it so that meta-fields that are both blank and read-only are not shown. That way bundled Essential Assets can leave a field blank, like author, and it will just not appear to users.

Brecht Van Lommel commented

2023-03-21 19:21:33 +01:00

Ok, I thought perhaps there might also be assets .blend files to be updated?

That patch seems something that can be quickly reviewed and landed in any case.

Ok, I thought perhaps there might also be assets .blend files to be updated? That patch seems something that can be quickly reviewed and landed in any case.

Harley Acheson commented

2023-03-21 19:47:54 +01:00

@brecht - Ok, I thought perhaps there might also be assets .blend files to be updated?

There might be; I don't know if the current state of the bundled assets represents their desired final form.

That patch seems something that can be quickly reviewed and landed in any case.

This patch was just done on spec based on a conversation with Julian last Wednesday. It seems reasonable and unharmful but it is also possible that others need to sign off.

> @brecht - Ok, I thought perhaps there might also be assets .blend files to be updated? There might be; I don't know if the current state of the bundled assets represents their desired final form. > That patch seems something that can be quickly reviewed and landed in any case. This patch was just done on spec based on a conversation with Julian last Wednesday. It seems reasonable and unharmful but it is also possible that others need to sign off.

Harley Acheson commented

2023-03-21 20:54:24 +01:00

@brecht - The currently bundled assets do seem to be as described, with each having a blank "author" field, not shown with PR #105812.

@brecht - The currently bundled assets do seem to be as described, with each having a blank "author" field, not shown with PR #105812. ![BundledAssets.png](/attachments/749d8d1f-b464-4073-b940-7fba76a3f6c0)

BundledAssets.png

397 KiB

Julian Eisel commented

2023-03-22 17:29:54 +01:00

From what I can tell the assets are ready for the release. License and copyright are set, author is unset (which AFAIK is intentional). @SimonThommes any changes you still want to do?
I think we should also link to the license, so the license field could read like one of the following:

CC0 - https://creativecommons.org/publicdomain/zero/1.0/legalcode
CC0 Public Domain - https://creativecommons.org/publicdomain/zero/1.0/legalcode
CC0 (Public Domain) - https://creativecommons.org/publicdomain/zero/1.0

I think the last one is the clearest, note that it links to the human-readable summary, not the legal text.

Hiding unset properties (#105812) is a separate change IMO that can be done for the next release.

From what I can tell the assets are ready for the release. License and copyright are set, author is unset (which AFAIK is intentional). @SimonThommes any changes you still want to do? I think we should also link to the license, so the license field could read like one of the following: * `CC0 - https://creativecommons.org/publicdomain/zero/1.0/legalcode` * `CC0 Public Domain - https://creativecommons.org/publicdomain/zero/1.0/legalcode` * `CC0 (Public Domain) - https://creativecommons.org/publicdomain/zero/1.0` I think the last one is the clearest, note that it links to the human-readable summary, not the legal text. Hiding unset properties (#105812) is a separate change IMO that can be done for the next release.

Simon Thommes commented

2023-03-22 17:50:59 +01:00

From what I can tell the assets are ready for the release

That's correct from my end. I have only been doing small bug fixes for issues I'm finding, nothing major. I'm now only working on material for the release and documentation.

I set author, license and copyright to what has been confirmed to me by Dalai. I can add the additional information to the license. Should I do that now?

> From what I can tell the assets are ready for the release That's correct from my end. I have only been doing small bug fixes for issues I'm finding, nothing major. I'm now only working on material for the release and documentation. I set author, license and copyright to what has been confirmed to me by Dalai. I can add the additional information to the license. Should I do that now?

Simon Thommes commented

2023-03-23 20:44:30 +01:00

Before I forget: @JulianEisel Do you have an update on that? You poked Ton in the chat but he didn't respond there afaict

Simon Thommes commented

2023-03-28 12:05:15 +02:00

This topic is entirely resolved now. This is the approved configuration that I now committed:

This topic is entirely resolved now. This is the approved configuration that I now committed: ![image](/attachments/b16f3992-b821-43c2-9a35-b16ef194ae31)

image.png

8.6 KiB

Simon Thommes closed this issue

2023-03-28 12:05:16 +02:00

Blender Bot added the

Status

Archived

label 2023-03-28 12:05:17 +02:00

Sign in to join this conversation.