[METAL] Texture Paint Color Picker picks wrong colors #106103

New Issue

Closed

opened 2023-03-24 13:25:05 +01:00 by Helge Maus · 12 comments

Helge Maus commented

2023-03-24 13:25:05 +01:00

System Information
Operating system: macOS-13.2.1-x86_64-i386-64bit 64 Bits
Graphics card: Metal API AMD Radeon Pro 580 1.2

Blender Version
Broken: version: 3.5.0 Release Candidate, branch: blender-v3.5-release, commit date: 2023-03-24 01:57, hash: 6caccf6b9f20
Worked: It worked correctly in Blender 3.4.1 for me

Short description of error
If I hold down the S Key for sampling a color in 3d view, it picks most of the time the background color of a textture and not the color under the Mouse Pointer.
Look into the screenshot onto the palette. These "colors" I pickes over the blue area in 3D View. They should be blue and not white.

You see it also while drawing with pressed S key in the color wheel in the picker on the right side. It samples blue, all values between and while, while I'm over the blue area. Shading is set to flat ...

In 2D-View it works as expected.

Exact steps for others to reproduce the error

Open attached .blend file or
- Take a default cube,
- switch to texture painting
- add a texture
paint an area blue.
Hold down the s-key and start sampling the colors from the cube.

Depending on the sampling point you should get the correct color, I don't

**System Information** Operating system: macOS-13.2.1-x86_64-i386-64bit 64 Bits Graphics card: Metal API AMD Radeon Pro 580 1.2 **Blender Version** Broken: version: 3.5.0 Release Candidate, branch: blender-v3.5-release, commit date: 2023-03-24 01:57, hash: `6caccf6b9f20` Worked: It worked correctly in Blender 3.4.1 for me **Short description of error** If I hold down the S Key for sampling a color in 3d view, it picks most of the time the background color of a textture and not the color under the Mouse Pointer. Look into the screenshot onto the palette. These "colors" I pickes over the blue area in 3D View. They should be blue and not white. You see it also while drawing with pressed S key in the color wheel in the picker on the right side. It samples blue, all values between and while, while I'm over the blue area. Shading is set to flat ... In 2D-View it works as expected. **Exact steps for others to reproduce the error** - Open attached .blend file or - Take a default cube, - switch to texture painting - add a texture - paint an area blue. - Hold down the s-key and start sampling the colors from the cube. Depending on the sampling point you should get the correct color, I don't

system-info.txt

10 KiB

ColorPicker.blend

902 KiB

Texture Sampling.png

1.5 MiB

Texture Sampling.png

Helge Maus added the

labels 2023-03-24 13:25:06 +01:00

YimingWu commented

2023-03-27 15:04:53 +02:00

Member

Unable to reproduce this on linux & nvidia hardware. Likely to be a metal-related issue.

Unable to reproduce this on linux & nvidia hardware. Likely to be a metal-related issue.

Helge Maus commented

2023-03-27 16:44:20 +02:00

Author

Good point, will test.
Yes, works uner OpenGL.
Seems to happen only in METAL.

Good point, will test. Yes, works uner OpenGL. Seems to happen only in METAL.

Helge Maus changed title from ~~Texture Paint Color Picker picks wrong colors~~ to [METAL] Texture Paint Color Picker picks wrong colors

2023-03-27 16:44:37 +02:00

Pratik Borhade commented

2023-03-28 08:04:01 +02:00

Member

@mano-wii , can you replicate the issue?

@mano-wii , can you replicate the issue?

Pratik Borhade added the

labels 2023-03-28 08:04:15 +02:00

Germano Cavalcante commented

2023-03-28 15:19:16 +02:00

Member

I can confirm the problem.
My impression is that the color Picker reads the object as if it had a different UV.

I can confirm the problem. My impression is that the color Picker reads the object as if it had a different UV.

Germano Cavalcante added

EEVEE & Viewport

and removed

labels 2023-03-28 15:19:45 +02:00

Clément Foucault added this to the EEVEE & Viewport project 2023-03-28 16:30:50 +02:00

Clément Foucault added this to the 3.6 LTS milestone 2023-03-29 16:32:40 +02:00

Clément Foucault commented

2023-03-29 16:32:48 +02:00

Member

@Michael-Parkin-White-Apple Here is one for you.

@Michael-Parkin-White-Apple Here is one for you.

Michael Parkin-White commented

2023-03-29 17:18:39 +02:00

Thanks for the report, i'll look into this.

Thanks for the report, i'll look into this.

Michael Parkin-White commented

2023-03-29 17:23:18 +02:00

I'm getting a separate assertion failure in GPU_select_buffer_stride_realign and also in the area size check in MTLFramebuffer::read if you hold down S and whizz the cursor around the view.

When a fix is found, can hopefully also patch up any undefined paths.

I'm getting a separate assertion failure in `GPU_select_buffer_stride_realign` and also in the area size check in MTLFramebuffer::read if you hold down S and whizz the cursor around the view. When a fix is found, can hopefully also patch up any undefined paths.

Michael Parkin-White commented

2023-03-29 18:25:07 +02:00

if a quick fix is needed, skipping the data fetch from the paint and going straight to sampling the viewport framebuffer works fine in Metal

Skipping this check in source/blender/editors/sculpt_paint/paint_utils.c :: paint_sample_color
if (v3d && texpaint_proj) {

GPU_backend_get_type() != GPU_BACKEND_METAL

and using the GPU_frontbuffer_read_pixels based fallback can work.

Let me know if this is viable for a PR. I'll investigate a proper solution, but not too familiar with texture painting feature.

if a quick fix is needed, skipping the data fetch from the paint and going straight to sampling the viewport framebuffer works fine in Metal Skipping this check in `source/blender/editors/sculpt_paint/paint_utils.c :: paint_sample_color` `if (v3d && texpaint_proj) {` `GPU_backend_get_type() != GPU_BACKEND_METAL` and using the `GPU_frontbuffer_read_pixels` based fallback can work. Let me know if this is viable for a PR. I'll investigate a proper solution, but not too familiar with texture painting feature.

Germano Cavalcante commented

2023-03-29 19:06:11 +02:00

Member

If I remember correctly, GPU_select_buffer_stride_realign was created because GPU_framebuffer_read_color crashed on some older GPUs if it was required to read regions outside the framebuffer boundary.
So a rect_clamp and the buffer needed to be corrected to match the original rect.

The downside of using GPU_frontbuffer_read_pixels is that it returns the shaded image value. The user usually wants the original texture or colordata value. That's why a selection is made first to identify the polygon and thus read its data.

As today has been set as the Blender 3.5 Release day (https://projects.blender.org/milestones), I'm not sure how this bug should be handled. @ThomasDinges should know?

If I remember correctly, `GPU_select_buffer_stride_realign` was created because `GPU_framebuffer_read_color` crashed on some older GPUs if it was required to read regions outside the framebuffer boundary. So a `rect_clamp` and the buffer needed to be corrected to match the original `rect`. The downside of using `GPU_frontbuffer_read_pixels` is that it returns the shaded image value. The user usually wants the original texture or colordata value. That's why a selection is made first to identify the polygon and thus read its data. As today has been set as the Blender 3.5 Release day (https://projects.blender.org/milestones), I'm not sure how this bug should be handled. @ThomasDinges should know?

Thomas Dinges commented

2023-04-04 16:10:37 +02:00

Owner

Once this report is fixed in main, it can be backported for a 3.5.1 bugfix release.

The usual procedure applies @mano-wii :) For future issues on release day, please notify me on the chat.

Once this report is fixed in main, it can be backported for a 3.5.1 bugfix release. The usual procedure applies @mano-wii :) For future issues on release day, please notify me on the chat.

Michael Parkin-White commented

2023-04-05 16:28:39 +02:00

Looks like this is a bug with GPU_viewport_size_get_i not correctly returning the contextual viewport size in Metal.

Viewport returned by OpenGL: VIEWPORT: 1219 41 1279 1548

Returned by Metal: VIEWPORT: 0 0 3024 1694 (Which is the native backbuffer res).

Likely a state issue of which current viewport is active at the time of sampling. Will submit a patch.

Looks like this is a bug with `GPU_viewport_size_get_i` not correctly returning the contextual viewport size in Metal. Viewport returned by OpenGL: `VIEWPORT: 1219 41 1279 1548` Returned by Metal: `VIEWPORT: 0 0 3024 1694` (Which is the native backbuffer res). Likely a state issue of which current viewport is active at the time of sampling. Will submit a patch.

Germano Cavalcante commented

2023-04-05 19:12:37 +02:00

Member

EDIT: comment in wrong report

EDIT: comment in wrong report

Jason Fielder referenced a pull request that will close this issue

2023-04-06 12:18:23 +02:00

Fix #106103: Resolve texture paint selection in Metal #106619

Jeroen Bakker referenced this issue from a commit

2023-04-07 13:06:03 +02:00

Fix #106103: Resolve texture paint selection in Metal

Jeroen Bakker closed this issue

2023-04-07 13:06:04 +02:00

Blender Bot added

and removed

labels 2023-04-07 13:06:05 +02:00

Jeroen Bakker referenced this issue

2023-04-07 13:07:29 +02:00

3.5: Candidates for corrective releases #106258

YimingWu referenced this issue

2023-04-11 06:01:17 +02:00

GPencil Fill tool is broken on all builds after April 07 #106773

antonheg referenced this issue

2023-04-11 10:50:54 +02:00

GPencil Fill tool is broken on all builds after April 07 #106773

Thomas Dinges referenced this issue from a commit

2023-04-20 12:32:10 +02:00

Fix #106103: Resolve texture paint selection in Metal

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

7 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106103

No description provided.