blender
/
blender
128
396
Fork 569
Code Issues 6.2k Pull Requests 756 Projects 19 Wiki Activity

Regression: Crash when loading project using custom material nodes #106467

New Issue
Closed
opened 2023-04-02 21:05:15 +02:00 by Max Schlecht · 10 comments
Max Schlecht commented 2023-04-02 21:05:15 +02:00
Contributor
Copy Link

System Information
Operating system: Windows 10
Graphics card: 980Ti

Blender Version
Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-03-01 23:48, hash: 6b8cdd597996
Worked: version: 3.6.0 Alpha, branch: main, commit date: 2023-02-26 23:09, hash: ca2c0da79eeb

Short description of error
I have a python addon which uses custom material nodes, based on group nodes.
This works by inheriting from ShaderNodeCustomGroup, registering the new node class and adding new node categories to the material node menus.

I don't think this behavior is entirely intended, but it's very useful and I've seen it used by some other addons aswell.

The problem is, that saving a file containing such custom material nodes and loading it using Blender 3.5 will simply crash Blender under certain conditions:

  1. the addon is active (if it's not, it'll load fine, but the nodes won't work)
  2. the custom node uses one of the new NodeSocket types (any of the new NodeSocketFloat variants or the new NodeSocketVector variants)
    It doesn't crash if the node is only using "the old" NodeSocket types, so this is somehow related to the new socket types being added and could also lead to issues in other scenarios.

Exact steps for others to reproduce the error

  1. Install the attached min_customnodes_addon addon and enable it.
  2. Create a cube and add a material to it
  3. Add the new "TestNode" node from the "Test" category.
  4. Save the file
  5. Restart Blender
  6. Load the file

If anyone has an idea what could cause this, I'd be happy to dig into this further, but because Blender just straight up crashes, I don't really have any good starting point. Thanks!

**System Information** Operating system: Windows 10 Graphics card: 980Ti **Blender Version** Broken: version: 3.6.0 Alpha, branch: main, commit date: 2023-03-01 23:48, hash: `6b8cdd597996` Worked: version: 3.6.0 Alpha, branch: main, commit date: 2023-02-26 23:09, hash: `ca2c0da79eeb` **Short description of error** I have a python addon which uses custom material nodes, based on group nodes. This works by inheriting from `ShaderNodeCustomGroup`, registering the new node class and adding new node categories to the material node menus. I don't think this behavior is entirely intended, but it's very useful and I've seen it used by some other addons aswell. The problem is, that saving a file containing such custom material nodes and loading it using Blender 3.5 will simply crash Blender under certain conditions: 1. the addon is active (if it's not, it'll load fine, but the nodes won't work) 2. **the custom node uses one of the new NodeSocket types (any of the new NodeSocketFloat variants or the new NodeSocketVector variants)** It doesn't crash if the node is only using "the old" `NodeSocket` types, so this is somehow related to the new socket types being added and **could also lead to issues in other scenarios**. **Exact steps for others to reproduce the error** 1. Install the attached `min_customnodes_addon` addon and enable it. 2. Create a cube and add a material to it 3. Add the new "TestNode" node from the "Test" category. 4. Save the file 5. Restart Blender 6. Load the file If anyone has an idea what could cause this, I'd be happy to dig into this further, but because Blender just straight up crashes, I don't really have any good starting point. Thanks!
min_customnodes_addon.py
2.7 KiB
Max Schlecht added the
Priority
Normal
Status
Needs Triage
Type
Report
 labels 2023-04-02 21:05:15 +02:00
Iliya Katushenock added the
Interest
Nodes & Physics
Interest
Python API
 labels 2023-04-02 21:06:14 +02:00
Max Schlecht commented 2023-04-02 21:11:20 +02:00
Author
Contributor
Copy Link

(This might or might not contain useful information, not sure.)

(This might or might not contain useful information, not sure.)
blender.crash.txt
26 KiB
Max Schlecht commented 2023-04-02 21:19:42 +02:00
Author
Contributor
Copy Link

Oh also: This only happens with NodeSocketFloat... and NodeSocketVector.... Other new socket types like NodeSocketVirtual, NodeSocketImage etc. seem to work fine (didn't test all of them).
So I'm guessing this does have something to do with all the Float and Vector subtypes.

Oh also: This only happens with `NodeSocketFloat...` and `NodeSocketVector...`. Other new socket types like `NodeSocketVirtual`, `NodeSocketImage` etc. seem to work fine (didn't test all of them). So I'm guessing this does have something to do with all the Float and Vector subtypes.
Iliya Katushenock commented 2023-04-02 21:24:20 +02:00
Member
Copy Link

I'll check

I'll check
Max Schlecht commented 2023-04-02 21:26:51 +02:00
Author
Contributor
Copy Link

Thanks! I'll try to find the exact version where this got broken. I just tested the earliest alpha build I could find and it worked fine there.

Thanks! I'll try to find the exact version where this got broken. I just tested the earliest alpha build I could find and it worked fine there.
Iliya Katushenock commented 2023-04-02 22:18:21 +02:00
Member
Copy Link

When updating the node declaration, the socket have a null pointer to the socket type. Not sure who and when should initialize and find the right type instance...

When updating the node declaration, the socket have a null pointer to the socket type. Not sure who and when should initialize and find the right type instance...
Max Schlecht commented 2023-04-03 19:18:26 +02:00
Author
Contributor
Copy Link

I think I found it!
In D17183 @JacquesLucke fixed this crash for normal group nodes here like this:

/* Don't update node groups here because they may depend on other node groups which are not
* fully versioned yet and don't have `typeinfo` pointers set. */
if (node->type != NODE_GROUP) {
  node_verify_sockets(ntree, node, false);
}

This only affects normal node groups though. The "custom" material nodes I create are of type NODE_CUSTOM_GROUP though, so the crash still happens for them.

Updating the code like this, should fix this.

/* Don't update node groups here because they may depend on other node groups which are not
* fully versioned yet and don't have `typeinfo` pointers set. */
if (node->type != NODE_GROUP && node->type != NODE_CUSTOM_GROUP) {
  node_verify_sockets(ntree, node, false);
}
I think I found it! In [D17183](https://archive.blender.org/developer/D17183) @JacquesLucke fixed this crash for normal group nodes [here](https://projects.blender.org/blender/blender/src/commit/e7f395dd206dcd46ff9d8e89682b33cd9e95abe7/source/blender/blenkernel/intern/node.cc#L926) like this: ```c /* Don't update node groups here because they may depend on other node groups which are not * fully versioned yet and don't have `typeinfo` pointers set. */ if (node->type != NODE_GROUP) { node_verify_sockets(ntree, node, false); } ``` This only affects normal node groups though. The "custom" material nodes I create are of type `NODE_CUSTOM_GROUP` though, so the crash still happens for them. Updating the code like this, should fix this. ```c /* Don't update node groups here because they may depend on other node groups which are not * fully versioned yet and don't have `typeinfo` pointers set. */ if (node->type != NODE_GROUP && node->type != NODE_CUSTOM_GROUP) { node_verify_sockets(ntree, node, false); } ```
Iliya Katushenock commented 2023-04-03 19:20:39 +02:00
Member
Copy Link

Not totally sure but look wrong, the problem here is with sockets, not groups.

Not totally sure but look wrong, the problem here is with sockets, not groups.
Iliya Katushenock changed title from Crash when loading project using custom material nodes to Regression: Crash when loading project using custom material nodes 2023-04-03 19:24:12 +02:00
Iliya Katushenock added
Priority
High
 and removed
Priority
Normal
 labels 2023-04-03 19:24:17 +02:00
Max Schlecht commented 2023-04-03 19:35:46 +02:00
Author
Contributor
Copy Link

Not totally sure but look wrong, the problem here is with sockets, not groups.

Yes, but no. The crash seems to happen because of uninitialized node socket types, but this is somehow only a problem with node groups.
I'm 95% this is the issue.
In T104296 they were also talking about node sockets being NULL.

> Not totally sure but look wrong, the problem here is with sockets, not groups. Yes, but no. The crash seems to happen because of uninitialized node socket types, but this is somehow only a problem with node groups. I'm 95% this is the issue. In [T104296](https://archive.blender.org/developer/maniphest/0104/0104296/index.html#1482913) they were also talking about node sockets being NULL.
Iliya Katushenock commented 2023-04-04 16:15:32 +02:00
Member
Copy Link

I'll try to make a more accurate bisect today, I don't see any potential culprits

I'll try to make a more accurate bisect today, I don't see any potential culprits
Max Schlecht commented 2023-04-04 17:15:33 +02:00
Author
Contributor
Copy Link

100% sure now, just did a build with the fix applied and it works. Making a PR.

100% sure now, just did a build with the fix applied and it works. Making a PR.
Blender Bot added
Status
Resolved
 and removed
Status
Confirmed
 labels 2023-04-05 15:36:37 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
brush-assets-project
blender-v4.1-release
blender-v3.3-release
blender-v3.6-release
universal-scene-description
blender-v3.6-temp_wmoss_animrig_public
temp-sculpt-dyntopo
gpencil-next
anim/animation-id-113594
blender-v4.0-release
blender-projects-basics
bridge-curves
sculpt-blender
asset-browser-frontend-split
asset-shelf
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-v2.93-release
realtime-clock
sculpt-dev
bevelv2
xr-dev
v4.1.1
v3.6.11
v3.3.18
v4.1.0
v3.3.17
v3.6.10
v3.6.9
v3.3.16
v3.6.8
v3.6.7
v3.3.14
v4.0.2
v4.0.1
v4.0.0
v3.6.5
v3.3.12
v3.6.4
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106467
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?