Node frame grid alignment issue #106594

Open
opened 2023-04-05 14:44:52 +02:00 by Hadrien · 6 comments

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 528.24

Blender Version
Broken: version: 3.4.1, branch: blender-v3.4-release, commit date: 2022-12-19 17:00, hash: rB55485cb379f7
Worked: (newest version of Blender that worked as expected)

Short description of error
Node frames shift contents out of grid alignment when transformed.
My understanding is that the frame borders are not multiples of the grid spacing, so whenever the frame is transformed and snapped to the grid, its contents are yanked out of alignment with the grid. Moving the contents back into alignment on their own works, but any further transforming the encompassing frame will yank them out again. Perhaps making the frame border an exact multiple of a grid unit could fix this.

Exact steps for others to reproduce the error

  1. Try moving the convex hull node. Observe that it stays aligned with the grid
  2. Try moving the frame around it. Observe that it snaps to the grid, and the convex hull node is now unaligned with the grid
**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 528.24 **Blender Version** Broken: version: 3.4.1, branch: blender-v3.4-release, commit date: 2022-12-19 17:00, hash: `rB55485cb379f7` Worked: (newest version of Blender that worked as expected) **Short description of error** Node frames shift contents out of grid alignment when transformed. My understanding is that the frame borders are not multiples of the grid spacing, so whenever the frame is transformed and snapped to the grid, its contents are yanked out of alignment with the grid. Moving the contents back into alignment on their own works, but any further transforming the encompassing frame will yank them out again. Perhaps making the frame border an exact multiple of a grid unit could fix this. **Exact steps for others to reproduce the error** 1. Try moving the convex hull node. Observe that it stays aligned with the grid 2. Try moving the frame around it. Observe that it snaps to the grid, and the convex hull node is now unaligned with the grid
Hadrien added the
Priority
Normal
Type
Report
Status
Needs Triage
labels 2023-04-05 14:44:53 +02:00
Member

Hi, thanks for the report. You mean when snapping the frame to gird, it should also align contents with grid?
In 3.4 and prior versions, when transforming the frame over grid, only contents are aligned and not the frame.

Hi, thanks for the report. You mean when snapping the frame to gird, it should also align contents with grid? In 3.4 and prior versions, when transforming the frame over grid, only contents are aligned and not the frame.
Pratik Borhade added
Status
Needs Information from User
and removed
Status
Needs Triage
labels 2023-04-07 07:27:10 +02:00
Author

Hi, I am merely reporting an inconvenience, how it should be solved is up for debate. Either the contents alone should be snapped to the grid, or the frame itself, but in the latter case then we should make sure the frame being aligned means the contents are also aligned. However I understand this is only valid if "shrink frame" is enabled, so maybe not such a solid solution. After all even if "shrink frames" is disabled, the frame contents aren't necessarily aligned to the grid, so the snapping is chancey at best, but I believe that's for the user to ensure.

Hi, I am merely reporting an inconvenience, how it should be solved is up for debate. Either the contents alone should be snapped to the grid, or the frame itself, but in the latter case then we should make sure the frame being aligned means the contents are also aligned. However I understand this is only valid if "shrink frame" is enabled, so maybe not such a solid solution. After all even if "shrink frames" is disabled, the frame contents aren't necessarily aligned to the grid, so the snapping is chancey at best, but I believe that's for the user to ensure.
Member

caused by the same commit: 6d3ce8273a
@lichtwerk ^

Either the contents alone should be snapped to the grid, or the frame itself

Will forward this report to devs to decide which one is more appropriate

caused by the same commit: 6d3ce8273a448f20c947e14e71934212202e4c3b @lichtwerk ^ > Either the contents alone should be snapped to the grid, or the frame itself Will forward this report to devs to decide which one is more appropriate
Member

Will check on this

Will check on this
Philipp Oeser self-assigned this 2023-04-12 09:33:28 +02:00
Member

Hi, @Lichtwerk I was wondering if you still were working on this/ if there was any progress? Otherwise I was thinking of taking a stab at it.

This is what I've came up with so far:

  1. We could try a band-aid solution, by making the frame margin as well as the padding for the label always match (integer multiples) of the node grid.
    That prevents the mismatch between the grid-alignment of the frame and it’s child nodes. But to me this feels quite hacky and I don’t like entailing the design of frame nodes so much with the snapping functionality.
  2. The „proper“ way to do this at this point is probably to move nodes out of „parent space“ so they all snap to the global grid like @HadrienBrissaud suggested.
    Making shrinking frames work with that doesn't seem to bad from what I've tried so far.
Hi, @Lichtwerk I was wondering if you still were working on this/ if there was any progress? Otherwise I was thinking of taking a stab at it. This is what I've came up with so far: 1. We could try a band-aid solution, by making the frame margin as well as the padding for the label always match (integer multiples) of the node grid. That prevents the mismatch between the grid-alignment of the frame and it’s child nodes. But to me this feels quite hacky and I don’t like entailing the design of frame nodes so much with the snapping functionality. 2. The „proper“ way to do this at this point is probably to move nodes out of „parent space“ so they all snap to the global grid like @HadrienBrissaud suggested. Making shrinking frames work with that doesn't seem to bad from what I've tried so far.
Member

@lone_noel : thx poking, this somehow slipped under the radar...

Feel free to go for it (and if solution 2 turns out to be workable, sounds good -- probably would be good to reach out in blender.chat prior to prevent efforts that somehow dont match design ideas other people have...)

Will step down then.

@lone_noel : thx poking, this somehow slipped under the radar... Feel free to go for it (and if solution 2 turns out to be workable, sounds good -- probably would be good to reach out in blender.chat prior to prevent efforts that somehow dont match design ideas other people have...) Will step down then.
Philipp Oeser removed their assignment 2023-12-06 14:05:10 +01:00
Leon Schittek self-assigned this 2023-12-07 07:35:33 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106594
No description provided.