Brush Assets: Create polished mockup for the Draft operators #106898

New Issue

Dalai Felinto · 2023-04-13T12:34:18+02:00

Dalai Felinto commented

2023-04-13 12:34:18 +02:00

Note that Apply Draft is disabled because its poll has "is local brush + has overides". So although this has overrides, this brush is not local, so it cannot be applied.

Also note that the cyan color we use for some settings is because they are overrides (this is the general override color).

--

Part of #101942.

![image](/attachments/c8310cd9-5368-4652-b8a2-a87234128894) ![image](/attachments/67ebec08-b37e-4a6f-9a6b-ecc8e9ddfcb0) Note that Apply Draft is disabled because its poll has "is local brush + has overides". So although this has overrides, this brush is not local, so it cannot be applied. Also note that the cyan color we use for some settings is because they are overrides (this is the general override color). -- Part of #101942.

image.png

141 KiB

image.png

232 KiB

image.png

126 KiB

image.png

14 KiB

image.png

19 KiB

image.png

126 KiB

Dalai Felinto added the

Type

To Do

label 2023-04-13 12:34:18 +02:00

Dalai Felinto self-assigned this 2023-04-13 12:34:18 +02:00

Dalai Felinto added this to the Brush Assets & Asset Shelf project 2023-04-13 12:34:19 +02:00

Dalai Felinto changed title from ~~Create final mockup for the Draft operators~~ to Brush Assets: Create polished mockup for the Draft operators

2023-04-13 12:35:40 +02:00

Dalai Felinto changed title from ~~Brush Assets: Create polished mockup for the Draft operators~~ to Brush Assets: Create polished mockup for the Draft operator

2023-04-13 12:35:50 +02:00

Dalai Felinto changed title from ~~Brush Assets: Create polished mockup for the Draft operator~~ to Brush Assets: Create polished mockup for the Draft operators

2023-04-13 12:35:54 +02:00

Dalai Felinto commented

2023-04-14 13:07:11 +02:00

Task updated with mockup.

Dalai Felinto referenced this issue

2023-04-17 15:19:40 +02:00

Implement UI for brush assets and Draft operators #107039

Julian Eisel commented

2023-04-17 15:34:19 +02:00

Not too sure if we should show much more info than the brush preview and the name. The description would often be clipped since we don't have multi-line label support. License & copyright are usually just visual noise, this doesn't really matter while using brushes, only when sharing. Plus it's just duplicating more of the Asset Browser UI.
If we really want to show more asset information it may be better off in a sub-panel, collapsed by default.

Not too sure if we should show much more info than the brush preview and the name. The description would often be clipped since we don't have multi-line label support. License & copyright are usually just visual noise, this doesn't really matter while using brushes, only when sharing. Plus it's just duplicating more of the Asset Browser UI. If we really want to show more asset information it may be better off in a sub-panel, collapsed by default.

Dalai Felinto commented

2023-04-17 15:46:21 +02:00

I'm fine with starting with the name + thumbnail.
That said, technically license & copyright do matter when duplicating the brush.

--

Mockups updated based on @JulienKaspar feedback on chat: use duplicate + trash icons and accomodate for extra operators in the future.

I'm fine with starting with the name + thumbnail. That said, technically license & copyright do matter when duplicating the brush. -- Mockups updated based on @JulienKaspar feedback on chat: use duplicate + trash icons and accomodate for extra operators in the future.

Julien Kaspar commented

2023-04-19 12:42:31 +02:00

Some more thoughts.

First off, I never asked this but I hope the override color is only ever used for session overrides. This would clearly communicate that there are unsaved changes.
Any drafted changes don't need a highlight imo.

Also I'm wrecking my head about the different operators that we'd need, because we basically have 4 different states that a brush asset can be in:
A = Original Asset (stored in asset file)
B = Draft Overrides (drafted changes on top of original asset)
C = New Draft (unique in preferences)
D = Session Overrides (Any unsaved changes that persist until Blender is closed)

This informs the need for various operators altering the state to another:

Duplicate as Draft (ABCD -> B)
Save Overrides (D -> ABC)
Clear Overrides (D -> ABC)
Apply to Asset (B -> A)
Reset Asset (B -> A)
Delete (ABC -> Nothing)
Convert Draft to new local Asset (C -> A)

That's a lot of operators that are all valid to exist but are not all availible at once.
That can be quite confusing.

More operations that are needed and should be accessible when possible are:

Rename Asset
Set Thumbnail

Some more thoughts. First off, I never asked this but I hope the override color is only ever used for session overrides. This would clearly communicate that there are unsaved changes. Any drafted changes don't need a highlight imo. Also I'm wrecking my head about the different operators that we'd need, because we basically have 4 different states that a brush asset can be in: A = Original Asset (stored in asset file) B = Draft Overrides (drafted changes on top of original asset) C = New Draft (unique in preferences) D = Session Overrides (Any unsaved changes that persist until Blender is closed) This informs the need for various operators altering the state to another: - Duplicate as Draft (ABCD -> B) - Save Overrides (D -> ABC) - Clear Overrides (D -> ABC) - Apply to Asset (B -> A) - Reset Asset (B -> A) - Delete (ABC -> Nothing) - Convert Draft to new local Asset (C -> A) That's a lot of operators that are all valid to exist but are not all availible at once. That can be quite confusing. More operations that are needed and should be accessible when possible are: - Rename Asset - Set Thumbnail

Dalai Felinto commented

2023-04-20 12:31:08 +02:00

@JulienKaspar

about the color:

I talked to Bastien, and the idea is to show the overrides also when editing the local brush, so you know what would be applied if you Apply Overrides.

We can look at this with more details once we switch gears and start heads on into the draft.

About the operators:

2.1 Why do we need a "Reset Asset"? Isn't this just a combination of Clear Overrides + Save Overrides?

2.2 The "Convert Draft to new local Asset" (or as I called it, "Create Local Brushes from Draft") can be applied to any brush. A better name may be "Duplicate as Local Brush" [this would apply all the overrides by the way].

2.3 Confusion ... I agree with something you said IRL, which is that we may need a way to indicate the state (A-D) of the brush to the user. Not sure yet what is the best way for that.

That plus a polling function to the operators explaining why the operator cannot run in this case may be enough.

@JulienKaspar 1. about the color: I talked to Bastien, and the idea is to show the overrides also when editing the local brush, so you know what would be applied if you Apply Overrides. We can look at this with more details once we switch gears and start heads on into the draft. 2. About the operators: 2.1 Why do we need a "Reset Asset"? Isn't this just a combination of Clear Overrides + Save Overrides? 2.2 The "Convert Draft to new local Asset" (or as I called it, "Create Local Brushes from Draft") can be applied to any brush. A better name may be "Duplicate as Local Brush" [this would apply all the overrides by the way]. 2.3 Confusion ... I agree with something you said IRL, which is that we may need a way to indicate the state (A-D) of the brush to the user. Not sure yet what is the best way for that. That plus a polling function to the operators explaining why the operator cannot run in this case may be enough.

Brecht Van Lommel commented

2023-04-20 18:25:16 +02:00

My understanding is that the workflow is that you can create drafts in any .blend while working, whereas ""Create Local Brushes from Draft"" is something you to do move a draft into a .blend file that is part of an asset library.

It may be more clear to have more distinct user interfaces for those.

The Brush Info panel could have operators "Duplicate", "Remove", "Apply Changes". No draft in the name needed.
In the Asset Browser you can have a Draft library, and an operator to move selected brushes from the draft into the current .Blend file.

I also suggest "move" rather than "duplicate" since that's what I understand the intended workflow to be. If someone wants to have a distinct brush in their asset .blend they can duplicate it first in the draft library.

My understanding is that the workflow is that you can create drafts in any .blend while working, whereas ""Create Local Brushes from Draft"" is something you to do move a draft into a .blend file that is part of an asset library. It may be more clear to have more distinct user interfaces for those. * The Brush Info panel could have operators "Duplicate", "Remove", "Apply Changes". No draft in the name needed. * In the Asset Browser you can have a Draft library, and an operator to move selected brushes from the draft into the current .Blend file. I also suggest "move" rather than "duplicate" since that's what I understand the intended workflow to be. If someone wants to have a distinct brush in their asset .blend they can duplicate it first in the draft library.

👍 1

Julien Kaspar commented

2023-04-24 11:34:49 +02:00

Here's my take on making this less confusing.

First of all we need to clearly separate the actions that are meant for "using" and casually "drafting" brushes from "authoring" assets.
Buttons in the sidebar should be undoable or non-destructive and typically result in a new or saved Draft.

Additional operators for applying drafts, deleting assets and creating new assets can potentially be grayed out and cannot be undone.
So they can be grouped and less exposed.

Here's a crude mockup:

The pink operators relate to any operation that results in a Draft or handle session overrides.
"Save" and "Revert" relate to the session overrides.
The rest is to edit or create a Draft.

Blue arrows are authoring specific edits that are likely grayed out if not inside the asset library .blend.
These operators are not directly exposed (as popover and collapsed tab) and should also be accessible in the asset browser to make batch edits on all selected assets.

Notable here are the "Remove" and "Rename" operators.
We should push to include these into the drafting at a later stage even though they are likely technically challenging.
"Remove" would always mark a draft or asset for deletion. That way it will be hidden from the asset shelf and put into a "Trash Bin" Catalog/Asset Library.
Once the drafted removal is applied, the asset is deleted for good.

Renaming is vital for drafting and needs to be possible on any brush, even essentials.
That doesn't mean that this change can be applied to an asset.
But putting a different name on top of the original asset and applying that change later is important functionality.

After some drafting, there will be many changes to apply, discard or deletions to approve.
This can be highlighted in the asset browser and changes can be applied on all selected assets.

Here's my take on making this less confusing. First of all we need to clearly separate the actions that are meant for "using" and casually "drafting" brushes from "authoring" assets. Buttons in the sidebar should be undoable or non-destructive and typically result in a new or saved Draft. Additional operators for applying drafts, deleting assets and creating new assets can potentially be grayed out and cannot be undone. So they can be grouped and less exposed. Here's a crude mockup: ![asset_UI_5.png](/attachments/46cb86da-378c-49cd-820c-9e9602de26a3) The pink operators relate to any operation that results in a Draft or handle session overrides. "Save" and "Revert" relate to the session overrides. The rest is to edit or create a Draft. Blue arrows are authoring specific edits that are likely grayed out if not inside the asset library .blend. These operators are not directly exposed (as popover and collapsed tab) and should also be accessible in the asset browser to make batch edits on all selected assets. Notable here are the "Remove" and "Rename" operators. We should push to include these into the drafting at a later stage even though they are likely technically challenging. "Remove" would always mark a draft or asset for deletion. That way it will be hidden from the asset shelf and put into a "Trash Bin" Catalog/Asset Library. Once the drafted removal is applied, the asset is deleted for good. Renaming is vital for drafting and needs to be possible on any brush, even essentials. That doesn't mean that this change can be applied to an asset. But putting a different name on top of the original asset and applying that change later is important functionality. After some drafting, there will be many changes to apply, discard or deletions to approve. This can be highlighted in the asset browser and changes can be applied on all selected assets. ![asset_UI_6.png](/attachments/58faa05e-c364-4ffc-a43a-f3c58efbeba0)

asset_UI_5.png

1.1 MiB

asset_UI_6.png

1.2 MiB

Brecht Van Lommel commented

2023-04-24 15:50:31 +02:00

I understand why this kind of draft (or direct editing of assets in other .blend files) is useful. But is that really the plan, to record a set of changes to assets that can then be applied?

That's not what I got from the previous design docs, and probably not accounted for in the implementation? The draft library as I understand it is just a set of isolated assets with no explicit relation to other assets.

I understand why this kind of draft (or direct editing of assets in other .blend files) is useful. But is that really the plan, to record a set of changes to assets that can then be applied? That's not what I got from the previous design docs, and probably not accounted for in the implementation? The draft library as I understand it is just a set of isolated assets with no explicit relation to other assets.

Julien Kaspar commented

2023-04-24 16:45:29 +02:00

The use of Drafts is overall to allow brush changes to be saved (draft overrides) while outside of the original asset library .blend.
New brushes that are duplicated from existing assets are also part of drafts.

This makes it possible to freely edit and create external assets (brushes in this case) while respecting the rule of having the original external assets as read-only.

The step of applying the drafts on assets (and making the changes permanent) will then often happen late, in bulk and only when users intend to share or copy their asset library.

The use of Drafts is overall to allow brush changes to be saved (draft overrides) while outside of the original asset library .blend. New brushes that are duplicated from existing assets are also part of drafts. This makes it possible to freely edit and create external assets (brushes in this case) while respecting the rule of having the original external assets as read-only. The step of applying the drafts on assets (and making the changes permanent) will then often happen late, in bulk and only when users intend to share or copy their asset library.

Hans Goudey commented

2024-01-17 20:00:39 +01:00

#116338

Hans Goudey closed this issue

2024-01-17 20:00:46 +01:00

Blender Bot added the

Status

Archived

label 2024-01-17 20:00:47 +01:00

Sign in to join this conversation.