Fix #107294 : Node Editor "Frame All/Selected" ignore Smooth View #107296

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:107294 into main 2023-04-25 10:30:02 +02:00
Member

Caused by 3a1cf838ca.

Smooth view transitions only work when an operator is invoked (wont
work from exec, see WM_operator_smooth_viewtx_get).

Now 3a1cf838ca changed the operator_context for some other operators
in the menu to 'EXEC_REGION_WIN' (for good reason). But setting
operator_context on a uiLayout will set context on the root
layout (not the actual sublayout alone), so all following operators
"inherited" the [changed] context.

Now make sure following operators get properly invoked again by giving
the right context.

Caused by 3a1cf838ca09. Smooth view transitions only work when an operator is **invoked** (wont work from **exec**, see `WM_operator_smooth_viewtx_get`). Now 3a1cf838ca09 changed the `operator_context` for some other operators in the menu to 'EXEC_REGION_WIN' (for good reason). But setting `operator_context` on a `uiLayout` will set context on the **root** layout (not the actual sublayout alone), so all following operators "inherited" the [changed] context. Now make sure following operators get properly invoked again by giving the right context.
Philipp Oeser added 1 commit 2023-04-24 14:17:44 +02:00
a0c2c518fa Fix #107294 : Node Editor "Frame All/Selected" ignore Smooth View
Caused by 3a1cf838ca.

Smooth view transitions only work when an operator is **invoked** (wont
work from **exec**, see `WM_operator_smooth_viewtx_get`).

Now 3a1cf838ca changed the `operator_context` for some other operators
in the menu to 'EXEC_REGION_WIN' (for good reason). But setting
`operator_context` on a `uiLayout` will set context on the **root**
layout (not the actual sublayout alone), so all following operators
"inherited" the [changed] context.

Now make sure following operators get properly invoked again by giving
the right context.
Philipp Oeser requested review from Harley Acheson 2023-04-24 14:17:53 +02:00
Philipp Oeser requested review from Julian Eisel 2023-04-24 14:18:01 +02:00
Philipp Oeser added this to the User Interface project 2023-04-24 14:18:07 +02:00
Philipp Oeser added the
Interest
Nodes & Physics
label 2023-04-24 14:18:15 +02:00
Julian Eisel approved these changes 2023-04-24 15:26:44 +02:00
Member

Hey that works great!

Hey that works great!
Harley Acheson approved these changes 2023-04-24 22:10:12 +02:00
Philipp Oeser merged commit 2f0b166dce into main 2023-04-25 10:30:02 +02:00
Philipp Oeser deleted branch 107294 2023-04-25 10:30:03 +02:00
Howard Trickey referenced this issue from a commit 2023-05-29 02:51:44 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107296
No description provided.