Regression: Hair sculpt crash on an empty hair object with "Density" brush #107637

New Issue

YimingWu · 2023-05-05T07:51:30+02:00

YimingWu commented

2023-05-05 07:51:30 +02:00

System Information
Operating system: Ubuntu 22.04 LTS
Graphics card: Nvidia K5100M

Blender Version
Broken: 3.6 dcb3b1c1f9
Worked: 3.6 dcb3b1c1f9cb~

Short description of error

Hair sculpt crash on an empty hair object.

Exact steps for others to reproduce the error

Default cube
Add object -> Curve -> Empty Hair
Go to sculpt mode
Try to sculpt
- Note: Cursor must land outside of the cube.
Crash

Note that this only happens for the Density brush.

Crashed at source/blender/geometry/intern/add_curves_on_mesh.cc Line 297 where:

  MutableSpan<int> curve_offsets = curves.offsets_for_write();
  // ...
  curve_offsets[old_curves_num] = old_points_num;  // <---- curve_offsets is NULL

**System Information** Operating system: Ubuntu 22.04 LTS Graphics card: Nvidia K5100M **Blender Version** Broken: 3.6 dcb3b1c1f9cb Worked: 3.6 dcb3b1c1f9cb~ **Short description of error** Hair sculpt crash on an empty hair object. **Exact steps for others to reproduce the error** - Default cube - Add object -> Curve -> Empty Hair - Go to sculpt mode - Try to sculpt - Note: Cursor must land outside of the cube. - Crash Note that this only happens for the Density brush. Crashed at `source/blender/geometry/intern/add_curves_on_mesh.cc` Line 297 where: ``` MutableSpan<int> curve_offsets = curves.offsets_for_write(); // ... curve_offsets[old_curves_num] = old_points_num; // <---- curve_offsets is NULL ```

YimingWu added the

labels 2023-05-05 07:51:31 +02:00

YimingWu commented

2023-05-05 07:55:19 +02:00

seems to be related to 6899474615 cc @JacquesLucke

seems to be related to 6899474615df cc @JacquesLucke

YimingWu added

Module

Sculpt, Paint & Texture

Status

Needs Info from Developers

and removed

Status

Needs Triage

labels 2023-05-05 07:55:34 +02:00

Dalai Felinto added this to the Nodes & Physics project 2023-05-05 10:12:45 +02:00

Dalai Felinto added

and removed

Needs Info from Developers

Type

Report

labels 2023-05-05 10:13:05 +02:00

Dalai Felinto commented

2023-05-05 10:15:07 +02:00

Confirmed indeed (and yes for the crash the cursor has to start outside the cube)

👍 1

Dalai Felinto commented

2023-05-05 10:16:15 +02:00

The backtrace:

#0  0x0000000001dc7da5 in blender::geometry::add_curves_on_mesh(blender::bke::CurvesGeometry&, blender::geometry::AddCurvesOnMeshInputs const&) ()
#1  0x0000000001c692d7 in blender::ed::sculpt_paint::DensityAddOperationExecutor::execute(blender::ed::sculpt_paint::DensityAddOperation&, bContext const&, blender::ed::sculpt_paint::StrokeExtension const&) ()
#2  0x0000000001c64bbb in blender::ed::sculpt_paint::DensityAddOperation::on_stroke_extended(bContext const&, blender::ed::sculpt_paint::StrokeExtension const&) ()
#3  0x0000000001b88dcd in blender::ed::sculpt_paint::stroke_update_step(bContext*, wmOperator*, PaintStroke*, PointerRNA*) ()
#4  0x0000000001bc1621 in paint_brush_stroke_add_step(bContext*, wmOperator*, PaintStroke*, float const*, float) ()
#5  0x0000000001bc3713 in paint_stroke_modal ()
#6  0x0000000001b89138 in blender::ed::sculpt_paint::sculpt_curves_stroke_modal(bContext*, wmOperator*, wmEvent const*) ()
#7  0x0000000001b89043 in blender::ed::sculpt_paint::sculpt_curves_stroke_invoke(bContext*, wmOperator*, wmEvent const*) ()
#8  0x0000000000f19f66 in wm_operator_invoke(bContext*, wmOperatorType*, wmEvent const*, PointerRNA*, ReportList*, bool, bool) [clone .part.0] ()
#9  0x0000000000f1da64 in wm_handler_operator_call(bContext*, ListBase*, wmEventHandler*, wmEvent*, PointerRNA*, char const*) ()
#10 0x0000000000f1dffe in wm_handlers_do_keymap_with_keymap_handler(bContext*, wmEvent*, ListBase*, wmEventHandler_Keymap*, wmKeyMap*, bool) ()
#11 0x0000000000f1e984 in wm_handlers_do_intern(bContext*, wmWindow*, wmEvent*, ListBase*) ()
#12 0x0000000000f1f31d in wm_handlers_do(bContext*, wmEvent*, ListBase*) ()
#13 0x0000000000f2017f in wm_event_do_handlers ()
#14 0x0000000000f12ff0 in WM_main ()
#15 0x00000000007458a7 in main ()

The backtrace: ``` #0 0x0000000001dc7da5 in blender::geometry::add_curves_on_mesh(blender::bke::CurvesGeometry&, blender::geometry::AddCurvesOnMeshInputs const&) () #1 0x0000000001c692d7 in blender::ed::sculpt_paint::DensityAddOperationExecutor::execute(blender::ed::sculpt_paint::DensityAddOperation&, bContext const&, blender::ed::sculpt_paint::StrokeExtension const&) () #2 0x0000000001c64bbb in blender::ed::sculpt_paint::DensityAddOperation::on_stroke_extended(bContext const&, blender::ed::sculpt_paint::StrokeExtension const&) () #3 0x0000000001b88dcd in blender::ed::sculpt_paint::stroke_update_step(bContext*, wmOperator*, PaintStroke*, PointerRNA*) () #4 0x0000000001bc1621 in paint_brush_stroke_add_step(bContext*, wmOperator*, PaintStroke*, float const*, float) () #5 0x0000000001bc3713 in paint_stroke_modal () #6 0x0000000001b89138 in blender::ed::sculpt_paint::sculpt_curves_stroke_modal(bContext*, wmOperator*, wmEvent const*) () #7 0x0000000001b89043 in blender::ed::sculpt_paint::sculpt_curves_stroke_invoke(bContext*, wmOperator*, wmEvent const*) () #8 0x0000000000f19f66 in wm_operator_invoke(bContext*, wmOperatorType*, wmEvent const*, PointerRNA*, ReportList*, bool, bool) [clone .part.0] () #9 0x0000000000f1da64 in wm_handler_operator_call(bContext*, ListBase*, wmEventHandler*, wmEvent*, PointerRNA*, char const*) () #10 0x0000000000f1dffe in wm_handlers_do_keymap_with_keymap_handler(bContext*, wmEvent*, ListBase*, wmEventHandler_Keymap*, wmKeyMap*, bool) () #11 0x0000000000f1e984 in wm_handlers_do_intern(bContext*, wmWindow*, wmEvent*, ListBase*) () #12 0x0000000000f1f31d in wm_handlers_do(bContext*, wmEvent*, ListBase*) () #13 0x0000000000f2017f in wm_event_do_handlers () #14 0x0000000000f12ff0 in WM_main () #15 0x00000000007458a7 in main () ```

Dalai Felinto changed title from ~~Hair sculpt crash on an empty hair object~~ to Hair sculpt crash on an empty hair object with "Density" brush

2023-05-05 10:17:40 +02:00

Dalai Felinto commented

2023-05-05 11:07:09 +02:00

Bisected to dcb3b1c1f9

Bisected to dcb3b1c1f9cb3d5b5e1827a7378b909745c55d64

Hans Goudey was assigned by Dalai Felinto

2023-05-05 11:07:19 +02:00

Pratik Borhade added

and removed

labels 2023-05-05 11:19:58 +02:00

Pratik Borhade changed title from ~~Hair sculpt crash on an empty hair object with "Density" brush~~ to Regression: Hair sculpt crash on an empty hair object with "Density" brush

2023-05-05 11:20:09 +02:00

Jacques Lucke referenced this issue from a commit

2023-05-08 09:26:37 +02:00

Fix #107637: crash when using density brush on empty hair

Jacques Lucke closed this issue

2023-05-08 09:26:38 +02:00

Blender Bot added

and removed