BKE_id_copy: Handle properly case when copying IDs into non-local destination (aka copied ID will belong to a library) #107847

Closed
opened 2023-05-11 15:34:40 +02:00 by Bastien Montagne · 1 comment

This is not used/needed in basic common situations, since duplicated ID from 'user PoV' should always become local data.

However, internal ID handling can require duplicating linked data that should remain linked. E.g. depsgraph CoW evaluated IDs should keep their same library as their source ID. LibOverride code also needs to keep copied IDs in their original (or in case of recursive resync, into another) library.

Current handling of these cases is fairly fragile and hacky. Think the best way to move forward would be to introduce a 'destination library' parameter in the lower-level part of the API (BKE_id_copy_ex). That BKE code can then handle things like making IDs local or not, updating accordingly the status (direct vs. indirect linked etc.) of the other IDs they use, assert that a local ID is never duplicated into a linked one, and so on.

This is not used/needed in basic common situations, since duplicated ID from 'user PoV' should always become local data. However, internal ID handling can require duplicating linked data that should remain linked. E.g. depsgraph CoW evaluated IDs should keep their same library as their source ID. LibOverride code also needs to keep copied IDs in their original (or in case of recursive resync, into another) library. Current handling of these cases is fairly fragile and hacky. Think the best way to move forward would be to introduce a 'destination library' parameter in the lower-level part of the API (`BKE_id_copy_ex`). That BKE code can then handle things like making IDs local or not, updating accordingly the status (direct vs. indirect linked etc.) of the other IDs they use, assert that a local ID is never duplicated into a linked one, and so on.
Bastien Montagne added the
Type
To Do
Module
Core
labels 2023-05-11 15:34:50 +02:00
Bastien Montagne added this to the Core project 2023-05-11 15:35:00 +02:00
Bastien Montagne changed title from BKE_id_copy: Hanlde properly case when copying IDs into non-local destination (aka copied ID will belong to a library) to BKE_id_copy: Handle properly case when copying IDs into non-local destination (aka copied ID will belong to a library) 2023-05-11 15:35:20 +02:00
Author
Owner

This was addressed by PR !108328 and commit ea73438e8a.

This was addressed by PR !108328 and commit ea73438e8a.
Blender Bot added the
Status
Archived
label 2024-05-23 10:49:12 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107847
No description provided.