outliner.object_operation (select hierarchy) does not change active object when directly called through a key event #107996

New Issue

Lluc Romaní Brasó · 2023-05-17T02:24:50+02:00

2023-05-17 02:24:50 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 526.98

Blender Version
Broken: version: 3.5.1, branch: blender-v3.5-release, commit date: 2023-04-24 18:11, hash: e1ccd9d4a1d3
Worked: (newest version of Blender that worked as expected)

Short description of error
"outliner.object_operation" has an inconsistent behaviour when assigned to a key:
when I go to the outliner and I select a hierarchy with the "right-click menu" > "select hierarchy" I just click on the object that has a hierarchy that I want to select.

If I assign this "outliner.object_operation" "select hierarchy" to a key for example "right click" + "alt" when I click on the same object by pressing "alt" sometimes it will not perform the correct selection.

I recorded a video to explain better the problem, sorry for my voice I'm a bit sick :(
https://youtu.be/7E_2Zra_3CY

Exact steps for others to reproduce the error

Assign "outliner.object_operation" "select hierarchy" to "right click" + "alt" .
Alt+right click on the hierarchy.
"select hierarchy" does work, but it selects the hierarchy of the active object instead from the object under the mouse pointer.
- Expected: "select hierarchy" if performed with a mouse click, should select the object under the mouse pointer and select the hierarchy.

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 526.98 **Blender Version** Broken: version: 3.5.1, branch: blender-v3.5-release, commit date: 2023-04-24 18:11, hash: `e1ccd9d4a1d3` Worked: (newest version of Blender that worked as expected) **Short description of error** "outliner.object_operation" has an inconsistent behaviour when assigned to a key: when I go to the outliner and I select a hierarchy with the "right-click menu" > "select hierarchy" I just click on the object that has a hierarchy that I want to select. If I assign this "outliner.object_operation" "select hierarchy" to a key for example "right click" + "alt" when I click on the same object by pressing "alt" sometimes it will not perform the correct selection. I recorded a video to explain better the problem, sorry for my voice I'm a bit sick :( https://youtu.be/7E_2Zra_3CY **Exact steps for others to reproduce the error** - Assign "outliner.object_operation" "select hierarchy" to "right click" + "alt" . - Alt+right click on the hierarchy. - "select hierarchy" does work, but it selects the hierarchy of the active object instead from the object under the mouse pointer. - Expected: "select hierarchy" if performed with a mouse click, should select the object under the mouse pointer and select the hierarchy.

Lluc Romaní Brasó added the

labels 2023-05-17 02:24:51 +02:00

YimingWu added

and removed

labels 2023-05-17 08:14:39 +02:00

YimingWu commented

2023-05-17 08:16:21 +02:00

Can confirm the behaviour.

I think basically when you use context menu to select hierarchy, it worked because it first activated the object before popping up the menu, while using alt-click, the outline doesn't do that for you.

It seems that object_select_hierarchy_fn does not select the object under pointer, which makes sense because normally the operation is executed through the menu, and if we do so it will move the selection to the other row. We didn't get a event when exec is called, so I think the best option so far (if we need to suport this) is to have yet another select option that allows hierarchy selection under mouse pointer, but not sure if TreeStoreElem * tselem is available.

Will poke interface guys for this.

@Lluc3D A way to sort of make it work for the moment is to have alt-click as active, and alt-double-click as select hierarchy, so basically alt-double-click is activating the object and selecting the hierarchy.

@pablovazquez Do you think we could add such alt-double-click (or ctrl or something) key map by default as select hierarchy? I could see this becoming rather convenient.

Can confirm the behaviour. I think basically when you use context menu to select hierarchy, it worked because it first activated the object before popping up the menu, while using alt-click, the outline doesn't do that for you. It seems that `object_select_hierarchy_fn` does not select the object under pointer, which makes sense because normally the operation is executed through the menu, and if we do so it will move the selection to the other row. We didn't get a `event` when `exec` is called, so I think the best option so far (if we need to suport this) is to have yet another select option that allows hierarchy selection under mouse pointer, but not sure if `TreeStoreElem * tselem` is available. Will poke interface guys for this. @Lluc3D A way to sort of make it work for the moment is to have alt-click as active, and alt-double-click as select hierarchy, so basically alt-double-click is activating the object and selecting the hierarchy. ![图片](/attachments/d74dff73-12b9-4048-b3e5-4f72b11ebddb) @pablovazquez Do you think we could add such `alt-double-click` (or ctrl or something) key map by default as select hierarchy? I could see this becoming rather convenient.

图片.png

47 KiB

YimingWu changed title from ~~"outliner.object_operation" has an inconsistent behaviour when assigned to a key~~ to `outliner.object_operation (select hierarchy)` does not change active object when directly called through a key event

2023-05-17 08:23:24 +02:00

Lluc Romaní Brasó commented

2023-05-17 22:42:24 +02:00

@ChengduLittleA the workaround is great I can use that for now, thanks :)

Lluc Romaní Brasó commented

2023-05-17 22:55:34 +02:00

Ignore this request, it was just a comment not a request for this particular bug.
It would be really cool if you could hold "alt"+"control" to select multiple hierarchies, Right now with the workaround you can only select one at a time, if you could select one hierarchy and then another one adding to the selection it would be very convenient.
But that may require more changes in the code. But it would be really useful if selecting hierarchies from the outliner was easier, potentially it could be used on armatures too for a better rigging process.

Ignore this request, it was just a comment not a request for this particular bug. It would be really cool if you could hold "alt"+"control" to select multiple hierarchies, Right now with the workaround you can only select one at a time, if you could select one hierarchy and then another one adding to the selection it would be very convenient. But that may require more changes in the code. But it would be really useful if selecting hierarchies from the outliner was easier, potentially it could be used on armatures too for a better rigging process.

YimingWu commented

2023-05-18 07:55:19 +02:00

@Lluc3D I can see how that's convenient, but here's what the code commented, not sure if this helps in clarifying things:

static void object_select_hierarchy_fn(bContext *C,
                                       ReportList * /*reports*/,
                                       Scene * /*scene*/,
                                       TreeElement *te,
                                       TreeStoreElem * /*tsep*/,
                                       TreeStoreElem * /*tselem*/,
                                       void * /*user_data*/)
{
  /* Don't extend because this toggles, which is nice for Ctrl-Click but not for a menu item.
   * it's especially confusing when multiple items are selected since some toggle on/off. */

This is implemented by @natecraddock , I think a new select mode specifically for mouse is doable, there we can implement select toggle/extend. So I guess we can keep this open.

@Lluc3D I can see how that's convenient, but here's what the code commented, not sure if this helps in clarifying things: ```Cpp static void object_select_hierarchy_fn(bContext *C, ReportList * /*reports*/, Scene * /*scene*/, TreeElement *te, TreeStoreElem * /*tsep*/, TreeStoreElem * /*tselem*/, void * /*user_data*/) { /* Don't extend because this toggles, which is nice for Ctrl-Click but not for a menu item. * it's especially confusing when multiple items are selected since some toggle on/off. */ ``` This is implemented by @natecraddock , I think a new select mode specifically for mouse is doable, there we can implement select toggle/extend. So I guess we can keep this open.

Pratik Borhade commented

2023-05-18 19:42:38 +02:00

to select multiple hierarchies, Right now with the workaround you can only select one at a time, if you could select one hierarchy and then another one adding to the selection it would be very convenient.

I think this is handled in #104737 (not sure, I need to build the branch again)

It seems that object_select_hierarchy_fn does not select the object under pointer,

Maybe this can be achieved with the help of outliner_item_is_co_over_name_icons function?

> to select multiple hierarchies, Right now with the workaround you can only select one at a time, if you could select one hierarchy and then another one adding to the selection it would be very convenient. I think this is handled in https://projects.blender.org/blender/blender/pulls/104737 (not sure, I need to build the branch again) > It seems that `object_select_hierarchy_fn` does not select the object under pointer, Maybe this can be achieved with the help of `outliner_item_is_co_over_name_icons` function?

Pratik Borhade commented

2023-05-18 20:09:51 +02:00

It would be really cool if you could hold "alt"+"control" to select multiple hierarchies,

This is request to improve existing feature functionality. We could track this at RCS: https://blender.community/c/rightclickselect/

> It would be really cool if you could hold "alt"+"control" to select multiple hierarchies, This is request to improve existing feature functionality. We could track this at RCS: https://blender.community/c/rightclickselect/

👍 1

YimingWu commented

2023-05-22 16:26:38 +02:00

hi @Lluc3D if you have posted on RCS let us know or have a link here, so we can close this issue :)

Pratik Borhade commented

2023-05-22 18:45:54 +02:00

@ChengduLittleA hi, original report is valid. That's upto UI-dev whether to change hierarchy selection behavior. But implementing this is not tough AFAICS.

I'm asking @Lluc3D to move the request made for "alt-ctrl support for selecting multiple hierarchies" to RCS.

@ChengduLittleA hi, original report is valid. That's upto UI-dev whether to change hierarchy selection behavior. But implementing this is not tough AFAICS. I'm asking @Lluc3D to move the request made for "`alt-ctrl` support for selecting multiple hierarchies" to RCS.

👍 1

Lluc Romaní Brasó commented

2023-06-01 01:01:29 +02:00

The request for "alt-ctrl" is not necessary it was just a comment sorry for that.

But the behaviour on the outliner would be nice to get it fix, altho the double-click workaround is useful I think it still should work with one click.

Thanks.

The request for "alt-ctrl" is not necessary it was just a comment sorry for that. But the behaviour on the outliner would be nice to get it fix, altho the double-click workaround is useful I think it still should work with one click. Thanks.

Pratik Borhade commented

2024-04-19 11:48:02 +02:00

Hi, now you can select hierarchy by double clicking the icon: !110151 / 796577d76e
I think we can close this.

Hi, now you can select hierarchy by double clicking the icon: !110151 / 796577d76e208df0358cdf306e5553386e555fc9 I think we can close this.

Pratik Borhade closed this issue

2024-04-19 11:48:06 +02:00

Blender Bot added

and removed