Fix operators that affect hidden geometry #108105

New Issue

Julien Kaspar · 2023-05-20T16:38:56+02:00

Julien Kaspar commented

2023-05-20 16:38:56 +02:00

(NOTE) This task is part of the community & sub tasks of the workboard. Anyone is free to pick up this task and contribute. For any questions or needed reviewers, please tag @Sergey @HooglyBoogly and @JulienKaspar.

There are a number of operators in sculpt mode that affect hidden geometry. As a general rule this should be avoided.

bpy.ops.sculpt.face_set_edit to Grow/Shrink, Fair or Delete face sets needs to have the "Modifiy Hidden" property disabled by default and disabled in all menu and keymap entries.

List of further operators:

bpy.ops.sculpt.face_sets_init
bpy.ops.sculpt.face_sets_create(mode='SELECTION')
bpy.ops.mesh.paint_mask_extract()
bpy.ops.mesh.paint_mask_slice()

(NOTE) This task is part of the community & sub tasks of the workboard. Anyone is free to pick up this task and contribute. For any questions or needed reviewers, please tag @Sergey @HooglyBoogly and @JulienKaspar. There are a number of operators in sculpt mode that affect hidden geometry. As a general rule this should be avoided. - [ ] `bpy.ops.sculpt.face_set_edit` to Grow/Shrink, Fair or Delete face sets needs to have the "Modifiy Hidden" property disabled by default and disabled in all menu and keymap entries. List of further operators: - [ ] `bpy.ops.sculpt.face_sets_init` - [ ] `bpy.ops.sculpt.face_sets_create(mode='SELECTION')` - [ ] `bpy.ops.mesh.paint_mask_extract()` - [ ] `bpy.ops.mesh.paint_mask_slice()`

Julien Kaspar added the

Type

To Do

Module

Sculpt, Paint & Texture

Meta

Good First Issue

labels 2023-05-20 16:38:57 +02:00

Julien Kaspar added this to the Sculpt, Paint & Texture project 2023-05-20 16:38:58 +02:00

Julien Kaspar changed title from ~~Operators only affect visible geometry~~ to Fix operators that affect hidden geometry

2023-05-20 16:39:41 +02:00

Lorenzo-Carpaneto commented

2023-06-02 16:58:02 +02:00

Hello, I am new to blender dev, and I was looking into this issue to start.

Before diving into the issue I wanted to highlight a couple of findings that might make the problem more difficult and ask more seasoned developers how to move forward.

It would appear that:

Fair operators makes the application crash
"Modifiy Hidden", when it is not enabled, does nothing (still modifies hidden geometry)

Both of these issues do not happen with previous blender build (I tried these operations on Blender 3.3, and everything worked as expected). (I have also attached a couple of videos to better show the errors)

So I was wondering if the issue was intended to have this scope or it was supposed to be only modify the default of the "Modify hidden" property to true to false.

(Windows OS) details of the build:

Vendor: Intel
Renderer: Intel(R) UHD Graphics 620
Version: 4.5.0 - Build 27.20.100.9664
Context Version: 4.5
Vendor: Intel
Renderer: Intel(R) UHD Graphics 620
Version: 4.5.0 - Build 27.20.100.9664
Context Version: 4.5

Hello, I am new to blender dev, and I was looking into this issue to start. Before diving into the issue I wanted to highlight a couple of findings that might make the problem more difficult and ask more seasoned developers how to move forward. It would appear that: - Fair operators makes the application crash - "Modifiy Hidden", when it is not enabled, does nothing (still modifies hidden geometry) Both of these issues do not happen with previous blender build (I tried these operations on Blender 3.3, and everything worked as expected). (I have also attached a couple of videos to better show the errors) So I was wondering if the issue was intended to have this scope or it was supposed to be only modify the default of the "Modify hidden" property to true to false. (Windows OS) details of the build: ``` Vendor: Intel Renderer: Intel(R) UHD Graphics 620 Version: 4.5.0 - Build 27.20.100.9664 Context Version: 4.5 Vendor: Intel Renderer: Intel(R) UHD Graphics 620 Version: 4.5.0 - Build 27.20.100.9664 Context Version: 4.5 ```

blender_modify_does_nothing.mp4

38 MiB

blender_abort_fair_position.mp4

11 MiB

Artur-Vieira commented

2023-07-31 00:18:01 +02:00

Hi @JulienKaspar , could I work on this issue as a first good issue? If it's available. Thank you.

Mangal Kushwah referenced a pull request that will close this issue

2024-03-07 16:06:45 +01:00

Fix #108105: Fix operators affecting hidden geometry #119168

Sign in to join this conversation.