Regression: Nodes: Background dots clipping is visible #114110

New Issue

Iliya Katueshenock · 2023-10-24T16:29:53+02:00

2023-10-24 16:29:53 +02:00

Background dots in node editor are clipped by borders.
But that clipping is not correct on too large zoom.

Fix: Deduce the reason of that behavior, and change iteration amount to +1 or add zoom factor multiplication in somethere.

Background dots in node editor are clipped by borders. But that clipping is not correct on too large zoom. ![image](/attachments/1f2c87fe-516e-4516-b95b-949795c6c5b5) Fix: Deduce the reason of that behavior, and change iteration amount to +1 or add zoom factor multiplication in somethere.

image.png

15 KiB

2023-10-24 17-23-34.mp4

11 MiB

Iliya Katueshenock added the

labels 2023-10-24 16:29:54 +02:00

Ian Failing commented

2023-10-25 20:37:04 +02:00

First-time contributor

@harley tiniest regression in the world in 04285c2d0e

@harley tiniest regression in the world in 04285c2d0e645470ece4f12169adbbc09ccef887

04285c2d0e.png

22 KiB

0b23816d5c.png

23 KiB

👍 1

Iliya Katueshenock commented

2023-10-25 20:50:55 +02:00

Oh..

Iliya Katueshenock changed title from ~~Nodes: Background dots clipping is visible~~ to Regression: Nodes: Background dots clipping is visible

2023-10-25 20:51:07 +02:00

Iliya Katueshenock added the

labels 2023-10-25 20:51:16 +02:00

Iliya Katueshenock added this to the 4.0 milestone 2023-10-25 20:51:28 +02:00

Iliya Katueshenock removed the

Meta

Good First Issue

label 2023-10-25 20:55:55 +02:00

Harley Acheson commented

2023-10-25 21:11:38 +02:00

Yes, I struggled with clipping of those dots. Before my patch (which was more about the sizing and placement of them) there were many times that they would be shown on top of the scroll bar, which I really hated. Fairly certain (away from computer) that in the example above the next column of them would in the space used by the scroll bar. That the scroll bar is not currently show makes it look odd, but not as odd as having dots on the scroll bar. It’s a fun bit of code if you want to try to improve it.

Hans Goudey added

and removed

labels 2023-10-25 21:24:11 +02:00

Douglas Paul commented

2023-10-26 04:27:21 +02:00

Ah, yes, I know this struggle well from some web apps I've worked on in my day job. The dynamic-width translucent "floating" scrollbars are so pretty and modern, but quite a pain when they clash with the background content.

That said, the dots are definitely clipping farther from the scrollbars than they need to be. In this screenshot, I've panned so the dots near the scrollbars are as close as they can get before they clip (and both scrollbars are active and at full width):

Looks like there's an extra scrollbar width/height being added to the margin.

Anyway, I'll try taking a look at this while everyone else is busy with BCON 2023

Ah, yes, I know this struggle well from some web apps I've worked on in my day job. The dynamic-width translucent "floating" scrollbars are so pretty and modern, but quite a pain when they clash with the background content. That said, the dots are definitely clipping farther from the scrollbars than they need to be. In this screenshot, I've panned so the dots near the scrollbars are as close as they can get before they clip (and both scrollbars are active and at full width): ![Scaled Screenshot 2023-10-25 at 10.12.15 PM.png](/attachments/54b75d12-51aa-44c6-add6-50838e9a22e3) Looks like there's an extra scrollbar width/height being added to the margin. Anyway, I'll try taking a look at this while everyone else is busy with BCON 2023

Scaled Screenshot 2023-10-25 at 10.12.15 PM.png

11 KiB

👍 1

Harley Acheson commented

2023-10-26 07:52:26 +02:00

The link to my PR above should point you at the code nicely and you’ll probably find it fun to play with.

The complications here are how we want things to scale. Generally we want everything scaling linearly. But… we also have “line width” adjustment which we use like a “minimum feature size”, so small things like lines become thicker independent of interface scaling. In this case with the dot grid we want the line width to affect the size of each dot but only use ui scale for the dot placement.

For this particular issue, if we want to make sure the dots don’t show in the scroll bar space you need to make sure this applies when you change scale and when selecting “wide lines” because that makes those wider. There is probably a function somewhere that returns the current width of that region’s scroll bar so you can probably get as you accurate as you can stand. I think, but not sure, that those dots might be changing their opacity near that edge so they don’t just pop in and out abruptly.

Anyway, there’s lots in there to have fun with. Don’t hesitate to ask questions.

The link to my PR above should point you at the code nicely and you’ll probably find it fun to play with. The complications here are how we want things to scale. Generally we want everything scaling linearly. But… we also have “line width” adjustment which we use like a “minimum feature size”, so small things like lines become thicker independent of interface scaling. In this case with the dot grid we want the line width to affect the size of each dot but only use ui scale for the dot placement. For this particular issue, if we want to make sure the dots don’t show in the scroll bar space you need to make sure this applies when you change scale and when selecting “wide lines” because that makes those wider. There is probably a function somewhere that returns the current width of that region’s scroll bar so you can probably get as you accurate as you can stand. I think, but not sure, that those dots might be changing their opacity near that edge so they don’t just pop in and out abruptly. Anyway, there’s lots in there to have fun with. Don’t hesitate to ask questions.

Iliya Katueshenock commented

2023-10-26 15:49:31 +02:00

In this case with the dot grid we want the line width to affect the size of each dot

Hm? No, i don't see the issues in the fact that dot's is drawn under scrollbar.
In the fact, i'd not like idea of changing grid density by hovering cursor over scrollbar.

> In this case with the dot grid we want the line width to affect the size of each dot Hm? No, i don't see the issues in the fact that dot's is drawn under scrollbar. In the fact, i'd not like idea of changing grid density by hovering cursor over scrollbar.

Douglas Paul commented

2023-10-26 15:59:34 +02:00

Thanks, @Harley! I definitely respect the complexity here, and I appreciate you taking the time to explain it (in the midst of BCON 2023, no less!). If I'm able to make an improvement here, it will only be because I have the luxury of investing as much time as I choose—no pressure to move on to other priorities.

Douglas Paul referenced a pull request that will close this issue

2023-10-28 06:03:54 +02:00

WIP: Fix #114110: Nodes editor background dots clipping is visible #114219

Douglas Paul commented

2023-10-28 07:52:47 +02:00

Looks like this is just a matter of needing to scale V2D_SCROLL_WIDTH and V2D_SCROLL_WIDTH based on the zoom factor.

I noticed that when I zoomed in the amount of empty space got even bigger, and that whan I zoomed out the amount of space got very small:

If I divide V2D_SCROLL_WIDTH and V2D_SCROLL_WIDTH by zoom_x, then the amount of space looks correct at multiple zoom levels:

I created #114219 with that fix, but there is maybe one more detail to work out...

The dots are clipped when their center would overlap with the scrollbar area, which means that a dot can still overlap the scrollbar by up to its radius:

I can fix that by also subtracting the dot radius from the rectangle's width/height, but there's a catch:

If I subtract the point radius for the current grid level, then we can get cases where larger dots clip, but the smaller dots underneath them are not clipped.
If I instead subtract max_point_size then I've made the margin a bit bigger than it needs to be in most cases.

So @Harley please let me know if you'd like me to add one of those two adjustments to my PR, or if it's fine to allow that little bit of overlap.

Looks like this is just a matter of needing to scale `V2D_SCROLL_WIDTH` and `V2D_SCROLL_WIDTH` based on the zoom factor. I noticed that when I zoomed in the amount of empty space got even bigger, and that whan I zoomed out the amount of space got very small: ![Scaled 114110_bad-margins-zoomed-in.png](/attachments/6d540767-8501-4ddd-a284-1cd076ca08b5) ![Scaled 114110_bad-margins-zoomed-out.png](/attachments/ff990b40-a5b1-4f02-8ce9-4c292e9d2957) If I divide `V2D_SCROLL_WIDTH` and `V2D_SCROLL_WIDTH` by `zoom_x`, then the amount of space looks correct at multiple zoom levels: ![Scaled 114110_good-margins-zoomed-in.png](/attachments/e436da04-a3cd-44b9-b31f-46b2380d9d1a) ![Scaled 114110_good-margins-zoomed-out.png](/attachments/3679f99d-faf6-4f64-bbf3-e4bbf06035dd) I created #114219 with that fix, but there is maybe one more detail to work out... The dots are clipped when their _center_ would overlap with the scrollbar area, which means that a dot can still overlap the scrollbar by up to its radius: ![Scaled 114110_dot-overlaps-scrollbar.png](/attachments/521d360d-ee7c-4c0e-96c9-8b49300c37d8) I can fix that by also subtracting the dot radius from the rectangle's width/height, but there's a catch: * If I subtract the point radius for the current grid level, then we can get cases where larger dots clip, but the smaller dots underneath them are _not_ clipped. * If I instead subtract `max_point_size` then I've made the margin a bit bigger than it needs to be in most cases. So @Harley please let me know if you'd like me to add one of those two adjustments to my PR, or if it's fine to allow that little bit of overlap.

Scaled 114110_bad-margins-zoomed-out.png

69 KiB

Scaled 114110_good-margins-zoomed-out.png

65 KiB

Scaled 114110_bad-margins-zoomed-in.png

18 KiB

Scaled 114110_good-margins-zoomed-in.png

29 KiB

Scaled 114110_dot-overlaps-scrollbar.png

20 KiB

Douglas Paul commented

2023-10-28 08:22:37 +02:00

I'd also like to add that I personally don't think this clipping around the scrollbars is necessary at all. I think it looks perfectly fine for the grid dots to go underneath the scrollbars, just like it's fine for the nodes and noodles to be underneath them.

Douglas Paul commented

2023-11-16 14:38:46 +01:00

@Harley I posted a question for you in one of my previous comments, but I suspect it may have slipped through the cracks as it was in the midst of the conference. Could you take a look when you get a chance?

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Nodes: Background dots clipping is visible #114110