blender/blender

VSE: Thicker strip handles on selection #123332

New Issue

Closed

opened 2024-06-17 20:02:17 +02:00 by Pablo Vazquez · 12 comments

Pablo Vazquez commented

2024-06-17 20:02:17 +02:00

Member

In the recent redesign of the strip handles, while the new dark inner outline helps with contrast, it gets on the way of handles.

In the following mockup image, the current design is above, the proposal below.

Dark outline is rounded and does not obscure the selection handles.
Selection handles are wider, and have rounded corners.
Visible gap between two adjacent strips. (this could be either a real gap, or an additional dark outline)

In the recent redesign of the strip handles, while the new dark inner outline helps with contrast, it gets on the way of handles. In the following mockup image, the current design is above, the proposal below. 1. Dark outline is rounded and does not obscure the selection handles. 2. Selection handles are wider, and have rounded corners. 3. Visible gap between two adjacent strips. (this could be either a real gap, or an additional dark outline) ![mockup](/attachments/d6567aef-f137-4a70-aa45-7d728cfb42cf)

108 KiB

Pablo Vazquez added the

Video Sequencer

labels 2024-06-17 20:02:18 +02:00

Aras Pranckevicius commented

2024-06-18 10:43:26 +02:00

Member

@pablovazquez what would also help, is a mockup of how things should look like when Preferences -> Editing -> Video Sequencer -> Tweak Handles is off, i.e. "previous handle tweaking workflow". Currently it looks like this, i.e. all strips have semitransparent "wide" handles on them (except when they are selected, then they are wide and opaque):

@pablovazquez what would also help, is a mockup of how things should look like when Preferences -> Editing -> Video Sequencer -> Tweak Handles is off, i.e. "previous handle tweaking workflow". Currently it looks like this, i.e. all strips have semitransparent "wide" handles on them (except when they are selected, then they are wide and opaque): ![Screenshot 2024-06-18 at 11.42.23.png](/attachments/b3d56eba-d9da-40ee-9e8c-3441a58c65e2)

Screenshot 2024-06-18 at 11.42.23.png

99 KiB

Aras Pranckevicius commented

2024-06-18 11:52:03 +02:00

Member

@pablovazquez @fsiddi what I have right now is this.

I think this looks/feels alright for the "new way" of handle tweaking:

However for the "old way" of handle tweaking, I think it almost works, except I'm not too sold on the inner "dark inset" of einar_00_src. The logic is that the dark inset is "inside the handles", but when the handles are semitransparent, it looks a bit weird. What do you think?

@pablovazquez @fsiddi what I have right now is this. I think this looks/feels alright for the "new way" of handle tweaking: ![Screenshot 2024-06-18 at 12.45.26.png](/attachments/555e071c-34da-468e-9de1-9cc51bb9c098) However for the "old way" of handle tweaking, I think it _almost_ works, except I'm not too sold on the inner "dark inset" of einar_00_src. The logic is that the dark inset is "inside the handles", but when the handles are semitransparent, it looks a bit weird. What do you think? ![Screenshot 2024-06-18 at 12.45.37.png](/attachments/4f92149c-183d-428c-b90a-065aa44c2a8c)

Screenshot 2024-06-18 at 12.45.26.png

143 KiB

Screenshot 2024-06-18 at 12.45.37.png

140 KiB

Pablo Vazquez commented

2024-06-18 13:18:01 +02:00

Author

Member

Looking great already!

For the tweak handles, I think the semi transparent nature of it adds noise while not really helping.

What if:

The tweak handles had a darker shade but fully opaque, not transparent.
The darker outline followed the orange/white outlines.
When tweak handles are enabled, the thumbnail takes the handle space into account (otherwise we'd overlay too much of it)

Here's a (terrible) mockup we made with Francesco:

Looking great already! For the tweak handles, I think the semi transparent nature of it adds noise while not really helping. What if: 1. The tweak handles had a darker shade but fully opaque, not transparent. 2. The darker outline followed the orange/white outlines. 3. When tweak handles are enabled, the thumbnail takes the handle space into account (otherwise we'd overlay too much of it) Here's a (terrible) mockup we made with Francesco: ![mockup](/attachments/b0c47b27-f12b-4132-800a-487d07c92bae)

231 KiB

Aras Pranckevicius commented

2024-06-18 13:39:36 +02:00

Member

The tweak handles had a darker shade but fully opaque, not transparent

Bbbut that would take away a lot of otherwise useful space from all the strips? Since they are displayed on all strips (even unselected ones). My impression for why they are semitransparent, is that they are kind of indication "hey you can maybe click here and then something would happen" (and before there were cursors indicating this, it was useful). If they would be opaque now, isn't that a lot of space wasted?

> The tweak handles had a darker shade but fully opaque, not transparent Bbbut that would take away _a lot_ of otherwise useful space from all the strips? Since they are displayed on all strips (even unselected ones). My impression for why they are semitransparent, is that they are kind of indication "hey you can maybe click here and then something would happen" (and before there were cursors indicating this, it was useful). If they would be opaque now, isn't that a lot of space wasted?

Aras Pranckevicius commented

2024-06-18 14:22:21 +02:00

Member

Tried this now, which I think looks better than in my previous shot. And again, this one is not the default, i.e. you have to go into preferences and turn "tweak handles" setting off (i.e. "back to previous way of interacting with handles").

Now the darker inset does follow the handle, but only if it is selected/active.

Thoughts?

Tried this now, which I think looks better than in my previous shot. And again, this one is _not the default_, i.e. you have to go into preferences and turn "tweak handles" setting off (i.e. "back to previous way of interacting with handles"). Now the darker inset does follow the handle, but only if it is selected/active. Thoughts? ![Screenshot 2024-06-18 at 15.20.09.png](/attachments/0bba2582-2700-4821-b5ff-87dd1c6af4f1)

Screenshot 2024-06-18 at 15.20.09.png

162 KiB

Pablo Vazquez commented

2024-06-18 15:35:50 +02:00

Author

Member

Good point about the wasted space. This last image of yours looks so much better.

Could you please make it a PR so we can test it? Thanks!

Good point about the wasted space. This last image of yours looks so much better. Could you please make it a PR so we can test it? Thanks!

Aras Pranckevicius referenced a pull request that will close this issue

2024-06-18 18:10:22 +02:00

Fix #123332: VSE strip transform handles look tweaks #123391

Aras Pranckevicius commented

2024-06-18 18:11:15 +02:00

Member

@pablovazquez sure, #123391

@pablovazquez sure, #123391

tintwotin commented

2024-06-18 18:33:25 +02:00

How does it work when strips become narrow? Is it possible to distinguish what is a selected handle, and what is outline only, when outlines and handles have the same color?

How does it work when strips become narrow? Is it possible to distinguish what is a selected handle, and what is outline only, when outlines and handles have the same color?

Aras Pranckevicius commented

2024-06-18 18:37:35 +02:00

Member

How does it work when strips become narrow? Is it possible to distinguish what is a selected handle, and what is outline only, when outlines and handles have the same color?

My guess is on a "no change compared to previous behavior", i.e.:

When strip is too narrow to contain handles, it does not have handles to begin with,
Selected strip outline color was always the same the selected handle color, right?

> How does it work when strips become narrow? Is it possible to distinguish what is a selected handle, and what is outline only, when outlines and handles have the same color? My guess is on a "no change compared to previous behavior", i.e.: - When strip is too narrow to contain handles, it does not have handles to begin with, - Selected strip outline color was always the same the selected handle color, right?

tintwotin commented

2024-06-18 18:52:54 +02:00

Originally, the handles where lighter than outlines, in the design A.Monti and I did back in the day (I believe it was already in the triangle handles design). But handles in contrasting colors could maybe be better, or no outline + bracket handle, or something else? But anyway, improving the design, should mean solving the problems the problems of the current design, no?

Originally, the handles where lighter than outlines, in the design A.Monti and I did back in the day (I believe it was already in the triangle handles design). But handles in contrasting colors could maybe be better, or no outline + bracket handle, or something else? But anyway, improving the design, should mean solving the problems the problems of the current design, no?

Aras Pranckevicius commented

2024-06-18 18:56:57 +02:00

Member

I don't know what is "back in the day" or who A.Monti is, sorry.

I don't know what is "back in the day" or who A.Monti is, sorry.

tintwotin commented

2024-06-18 19:03:19 +02:00

A. Monti and I did the design update in 2.83, which I referenced this this thread: https://blender.chat/channel/sequencer-module?msg=HMoh6rfXJvqREsyHB

Not that it matters much, moving forward should mean moving forward.

A. Monti and I did the design update in 2.83, which I referenced this this thread: https://blender.chat/channel/sequencer-module?msg=HMoh6rfXJvqREsyHB Not that it matters much, moving forward should mean moving forward.

Aras Pranckevicius referenced this issue from a commit

2024-06-19 11:49:33 +02:00

Fix #123332: VSE strip transform handles look tweaks

Aras Pranckevicius closed this issue

2024-06-19 11:49:37 +02:00

Blender Bot added the

label 2024-06-19 11:49:40 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#123332

No description provided.