blender/blender
149
475
Fork 703
Code Issues 6.7k Pull Requests 895 Projects 18 Wiki Activity

Regression: Tooltip missing from open URL preset operator #123735

New Issue
Closed
opened 2024-06-25 17:06:24 +02:00 by Pablo Vazquez · 7 comments
Pablo Vazquez commented 2024-06-25 17:06:24 +02:00
Member
Copy Link

System Information
Operating system: macOS-14.5-arm64-arm-64bit 64 Bits
Graphics card: Metal API Apple M2 Max 1.2

Blender Version
Broken: version: 4.3.0 Alpha, branch: main, commit date: 2024-06-25 12:21, hash: fb0f4092375f
Worked: 3.6 LTS

Short description of error
The tooltips for open URL presets is missing in recent releases.

Defined in WM_OT_url_open_preset in wm.py.

scripts/startup/bl_operators/wm.py Line 1133 in b53ae4745c
tip_("The donation program to support maintenance and improvements")),

Blender 3.6 LTS main
Blender 3.6 LTS main

Seems to have broken already in 4.0:
Blender 4.0

Exact steps for others to reproduce the error

  1. Open Blender
  2. Hover over the splash screen Donate or What's New buttons.
**System Information** Operating system: macOS-14.5-arm64-arm-64bit 64 Bits Graphics card: Metal API Apple M2 Max 1.2 **Blender Version** Broken: version: 4.3.0 Alpha, branch: main, commit date: 2024-06-25 12:21, hash: `fb0f4092375f` Worked: 3.6 LTS **Short description of error** The tooltips for open URL presets is missing in recent releases. Defined in `WM_OT_url_open_preset` in `wm.py`. https://projects.blender.org/blender/blender/src/commit/b53ae4745c78019183becd4e88587af4ee69b156/scripts/startup/bl_operators/wm.py#L1133 |Blender 3.6 LTS|main| |----|----| ![Blender 3.6 LTS](/attachments/5b135a67-8aea-4b47-bee6-3efff77cbf5a)|![main](/attachments/cd7f00c2-9096-4fdc-87ae-b2c6ed755d8e)| Seems to have broken already in 4.0: ![Blender 4.0](/attachments/1621f7da-f7e6-4f5c-ba62-9c685a7f5317) **Exact steps for others to reproduce the error** 1. Open Blender 2. Hover over the splash screen `Donate` or `What's New` buttons.
image.png
853 KiB
image.png
514 KiB
image.png
442 KiB
Iliya Katushenock changed title from Tooltip missing from open URL preset operator to Regression: Tooltip missing from open URL preset operator 2024-06-25 17:09:20 +02:00
Iliya Katushenock added
Interest
User Interface
 and removed
Module
User Interface
 labels 2024-06-25 17:09:25 +02:00
Iliya Katushenock added this to the 4.2 LTS milestone 2024-06-25 17:09:29 +02:00
Pratik Borhade commented 2024-06-26 06:30:26 +02:00
Member
Copy Link

Hi, can confirm. Tooltip of all preset_items is missing

Hi, can confirm. Tooltip of all `preset_items` is missing
Pratik Borhade commented 2024-06-26 07:00:59 +02:00
Member
Copy Link

Appears to be caused by 8b610723b6
@JulianEisel ^

Broke between 264c3e7bd7a6 - 407e2b9f700f

Appears to be caused by 8b610723b6d395988f10368f842aba84c13885cf @JulianEisel ^ Broke between `264c3e7bd7a6 - 407e2b9f700f`
Harley Acheson commented 2024-07-05 00:25:44 +02:00
Member
Copy Link

@pablovazquez @JulianEisel

It is likely that what you are wanting here is just how it was before. But, just in case - or if we run out of time - we could just quickly do something like this:

diff --git a/scripts/startup/bl_operators/wm.py b/scripts/startup/bl_operators/wm.py
index 66bbbf11261..5791ef0b69e 100644
--- a/scripts/startup/bl_operators/wm.py
+++ b/scripts/startup/bl_operators/wm.py
@@ -1062,6 +1062,10 @@ class WM_OT_url_open(Operator):
         version = bpy.app.version_string
         return "blender-" + version.replace(" ", "-").lower()
 
+    @classmethod
+    def description(cls, context, props):
+        return props.url
+
     def execute(self, _context):
         import webbrowser
         complete_url = self._add_utm_param_to_url(self.url, self._get_utm_source())
@@ -1143,6 +1147,16 @@ class WM_OT_url_open_preset(Operator):
          "https://extensions.blender.org/"),
     ]
 
+    @classmethod
+    def description(cls, context, props):
+        desc = None
+        for (item_id, _, description), url in cls.preset_items:
+            if item_id == props.type:
+                desc = description
+                break
+
+        return desc
+
     def execute(self, context):
         url = None
         type = self.type

This gets us the description for WM_OT_url_open_preset and the url for WM_OT_url_open

image

@pablovazquez @JulianEisel It is likely that what you are wanting here is just how it was before. But, just in case - or if we run out of time - we _could_ just quickly do something like this: ```Diff diff --git a/scripts/startup/bl_operators/wm.py b/scripts/startup/bl_operators/wm.py index 66bbbf11261..5791ef0b69e 100644 --- a/scripts/startup/bl_operators/wm.py +++ b/scripts/startup/bl_operators/wm.py @@ -1062,6 +1062,10 @@ class WM_OT_url_open(Operator): version = bpy.app.version_string return "blender-" + version.replace(" ", "-").lower() + @classmethod + def description(cls, context, props): + return props.url + def execute(self, _context): import webbrowser complete_url = self._add_utm_param_to_url(self.url, self._get_utm_source()) @@ -1143,6 +1147,16 @@ class WM_OT_url_open_preset(Operator): "https://extensions.blender.org/"), ] + @classmethod + def description(cls, context, props): + desc = None + for (item_id, _, description), url in cls.preset_items: + if item_id == props.type: + desc = description + break + + return desc + def execute(self, context): url = None type = self.type ``` This gets us the description for `WM_OT_url_open_preset` and the url for `WM_OT_url_open` ![image](/attachments/d16653c6-79b2-44d9-a1e2-749dc9733d22)
image.png
32 KiB
Pratik Borhade commented 2024-07-15 10:50:39 +02:00
Member
Copy Link

I think we can take off 4.2 milestone from this (not so critical) 🙂

I think we can take off 4.2 milestone from this (not so critical) 🙂
Pratik Borhade removed this from the 4.2 LTS milestone 2024-07-15 10:50:57 +02:00
Pablo Vazquez commented 2024-07-15 15:21:11 +02:00
Author
Member
Copy Link

I think we can take off 4.2 milestone from this (not so critical) 🙂

Not so critical but I think it's important enough to be fixed soonish (4.3 and backported to LTS), since it was broken not long ago either. Giving context on what the preset is is important.

> I think we can take off 4.2 milestone from this (not so critical) 🙂 Not so critical but I think it's important enough to be fixed soonish (4.3 and backported to LTS), since it was broken not long ago either. Giving context on what the preset is is important.
Pratik Borhade commented 2024-07-15 15:23:56 +02:00
Member
Copy Link

Indeed, this is still high priority bug.
And, Of course you can add back the 4.2 milestone :)

Indeed, this is still high priority bug. And, Of course you can add back the 4.2 milestone :)
👍 1
Julian Eisel commented 2024-07-25 12:15:17 +02:00
Member
Copy Link

This is actually caused by 7bc34283ea. @ideasman42 mind having a look?

Appears to be caused by 8b610723b6
@JulianEisel ^

Broke between 264c3e7bd7a6 - 407e2b9f700f

The situation is a bit confusing, since the tooltip changed multiple times.

Before 7bc34283ea After 7bc34283ea After 9d0907560a After 8b610723b6

The first image is the expected result.

This is actually caused by 7bc34283eacc. @ideasman42 mind having a look? > Appears to be caused by 8b610723b6d395988f10368f842aba84c13885cf > @JulianEisel ^ > > Broke between `264c3e7bd7a6 - 407e2b9f700f` The situation is a bit confusing, since the tooltip changed multiple times. | Before 7bc34283ea | After 7bc34283ea | After 9d0907560a | After 8b610723b6 | | --- | --- | --- | --- | | ![](/attachments/9481b894-4749-4766-8ac1-56d0b98a4896) | ![](/attachments/36f85c58-78d1-42d8-b940-d3b50ddd3445) | ![](/attachments/75e9c215-0c12-4614-b8b7-1bd6d1af1ee5) | ![](/attachments/36f85c58-78d1-42d8-b940-d3b50ddd3445) | The first image is the expected result.
Screenshot from 2024-07-23 16-51-27.png
36 KiB
Screenshot from 2024-07-25 12-10-12.png
41 KiB
Screenshot from 2024-07-23 16-43-03.png
39 KiB
👍 1 ❤️ 1
Blender Bot added
Status
Resolved
 and removed
Status
Confirmed
 labels 2024-07-25 12:31:41 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#123735
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?