VSE: prefetch frames crashes with some scene strips #125401

New Issue

LOIC BRAMOULLE · 2024-07-25T08:58:00+02:00

LOIC BRAMOULLE commented

2024-07-25 08:58:00 +02:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 552.22

Blender Version
Broken: version: 4.2.0, branch: blender-v4.2-release, commit date: 2024-07-16 06:20, hash: a51f293548ad
Worked: (newest version of Blender that worked as expected)

Short description of error
Ticking prefetch frames crashes.

Exact steps for others to reproduce the error
Not sure how to reproduce but here is a file where it happens:
https://www.dropbox.com/t/JMQNeI9dkPUuKfjM

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 552.22 **Blender Version** Broken: version: 4.2.0, branch: blender-v4.2-release, commit date: 2024-07-16 06:20, hash: `a51f293548ad` Worked: (newest version of Blender that worked as expected) **Short description of error** Ticking prefetch frames crashes. **Exact steps for others to reproduce the error** Not sure how to reproduce but here is a file where it happens: https://www.dropbox.com/t/JMQNeI9dkPUuKfjM

LOIC BRAMOULLE added the

labels 2024-07-25 08:58:00 +02:00

Aras Pranckevicius changed title from ~~systematic crash on "prefetch frames" in VSE~~ to VSE: prefetch frames crashes with some scene strips

2024-07-25 09:43:59 +02:00

Aras Pranckevicius added

and removed

labels 2024-07-25 09:44:08 +02:00

Aras Pranckevicius commented

2024-07-25 09:48:49 +02:00

At least in 4.3 / current main, the crash happens when the prefetch thread renders a scene strip, and inside of it DEG is evaluated, and view layer is copied:

BKE_view_layer_copy_data :542
scene_copy_data :300
BKE_id_copy_in_lib :697
BKE_id_copy_ex :756
blender::deg::scene_copy_inplace_no_main :317
blender::deg::deg_expand_eval_copy_datablock :804
blender::deg::deg_update_eval_copy_datablock :905
blender::deg::depsgraph_ensure_view_layer :368
blender::deg::deg_evaluate_on_refresh :404
deg_flush_updates_and_refresh :49
render_update_depsgraph :1952
render_init_depsgraph :1968
RE_RenderFrame :2028
seq_render_scene_strip :1672

In the code, it seems like the lc_scene_dst is null:

  view_layer_dst->active_collection = nullptr;
  layer_collections_copy_data(view_layer_dst,
                              view_layer_src,
                              &view_layer_dst->layer_collections,
                              &view_layer_src->layer_collections);

  LayerCollection *lc_scene_dst = static_cast<LayerCollection *>(
      view_layer_dst->layer_collections.first);
  lc_scene_dst->collection = scene_dst->master_collection; //<---- crash here

Blender 3.6, 4.0 and 4.1 all seem to crash on this file as well, so it does not look like a regression.

At least in 4.3 / current main, the crash happens when the prefetch thread renders a scene strip, and inside of it DEG is evaluated, and view layer is copied: ``` BKE_view_layer_copy_data :542 scene_copy_data :300 BKE_id_copy_in_lib :697 BKE_id_copy_ex :756 blender::deg::scene_copy_inplace_no_main :317 blender::deg::deg_expand_eval_copy_datablock :804 blender::deg::deg_update_eval_copy_datablock :905 blender::deg::depsgraph_ensure_view_layer :368 blender::deg::deg_evaluate_on_refresh :404 deg_flush_updates_and_refresh :49 render_update_depsgraph :1952 render_init_depsgraph :1968 RE_RenderFrame :2028 seq_render_scene_strip :1672 ``` In the code, it seems like the `lc_scene_dst` is null: ``` view_layer_dst->active_collection = nullptr; layer_collections_copy_data(view_layer_dst, view_layer_src, &view_layer_dst->layer_collections, &view_layer_src->layer_collections); LayerCollection *lc_scene_dst = static_cast<LayerCollection *>( view_layer_dst->layer_collections.first); lc_scene_dst->collection = scene_dst->master_collection; //<---- crash here ``` Blender 3.6, 4.0 and 4.1 all seem to crash on this file as well, so it does not look like a regression.

Iliya Katushenock added the

Module

VFX & Video

label 2024-07-25 18:44:51 +02:00

Philipp Oeser commented

2024-08-04 13:01:24 +02:00

Prefer if crashes are always High priority

Philipp Oeser added

and removed

labels 2024-08-04 13:01:41 +02:00

Richard Antalik commented

2024-08-06 08:15:27 +02:00

@loicbramoulle Can you upload the file to this site? Upload is expired and I don't have dropbox account, neither want one.

LOIC BRAMOULLE commented

2024-08-06 17:16:56 +02:00

@iss sure, I'll try right now to reduce the file size while making sure the crash still happens in a nearly empty file. (that I can paste here)

But in the meantime if you want, you can download transfers without a dropbox account, at the bottom of the download popup:
(but yes sorry the file stay online only a week I think.)
https://www.dropbox.com/t/dpjrao5HnLvpRHlS

@iss sure, I'll try right now to reduce the file size while making sure the crash still happens in a nearly empty file. (that I can paste here) But in the meantime if you want, you can download transfers without a dropbox account, at the bottom of the download popup: (but yes sorry the file stay online only a week I think.) https://www.dropbox.com/t/dpjrao5HnLvpRHlS

LOIC BRAMOULLE commented

2024-08-06 17:23:24 +02:00

@iss ah nice 84MB fits, and the crash still happens. (just go in the Video sequencer workstpace, and click prefetch on the n-panel of the video preview.)

@iss ah nice 84MB fits, and the crash still happens. (just go in the Video sequencer workstpace, and click **prefetch** on the n-panel of the video preview.)

ENVIRO_old_02_EMPTY_2.blend

80 MiB

Bart van der Braak added

and removed

labels 2024-08-14 12:54:57 +02:00

Richard Antalik referenced a pull request that will close this issue

2024-08-14 14:52:47 +02:00

Fix #125401: Crash when enabling prefetching #126092

Richard Antalik referenced this issue from a commit

2024-08-14 22:36:33 +02:00

Fix #125401: Crash when enabling prefetching

Richard Antalik closed this issue

2024-08-14 22:36:34 +02:00

Blender Bot added

and removed

labels 2024-08-14 22:36:36 +02:00

Richard Antalik referenced this issue

2024-08-16 06:22:31 +02:00

Blender LTS: Maintenance Task 4.2 #124452

Philipp Oeser referenced this issue from a commit

2024-08-16 12:13:28 +02:00

Fix #125401: Crash when enabling prefetching

LOIC BRAMOULLE commented

2024-08-29 07:02:26 +02:00

testing in 4.2.1 prefetch frames doesn't crash instantly anymore, but it does systematically crash after maybe 1 minute, scrolling a few times over a scene strip.

LOIC BRAMOULLE reopened this issue

2024-08-29 07:02:30 +02:00

Blender Bot added

and removed

labels 2024-08-29 07:02:32 +02:00

Pratik Borhade commented

2024-08-29 07:11:02 +02:00

@loicbramoulle hi, best to open a new report with necessary info.