blender/blender
147
471
Fork 688
Code Issues 6.7k Pull Requests 885 Projects 18 Wiki Activity

Regression: Toggle Maximize Area slower with geometry nodes #126205

New Issue
Open
opened 2024-08-11 21:02:28 +02:00 by Jan Kadeřábek · 9 comments
Jan Kadeřábek commented 2024-08-11 21:02:28 +02:00
Copy Link

System Information
Operating system: Windows 10
Graphics card: 3060 Ti

Blender Version
Broken: 4.2.0 LTS and higher
Worked: 4.0.2 and lower

Short description of error
When a large number of instances are generated using G.Nodes, and a Collection Info node is present (even if it's disconnected but has an actual collection set), the Toggle Maximize Area becomes significantly slower compared to version 4.0.2 and earlier.
This makes nearly impossible to work on projects where G.Nodes are utilized heavily (i.e. vegetation scattering).

Exact steps for others to reproduce the error

  1. Open the attached .blend.
  2. Toggle Maximize Area of the 3D viewport first in 4.0.2 (or earlier like 3.4.x), and then in 4.2 and higher).
  3. Delete the Collection Info node (or remove the Suzanne collection from it) and try it again.
  4. Disabling Realize Instances also makes it fast again.
**System Information** Operating system: Windows 10 Graphics card: 3060 Ti **Blender Version** Broken: 4.2.0 LTS and higher Worked: 4.0.2 and lower **Short description of error** When a large number of instances are generated using G.Nodes, and a Collection Info node is present (even if it's disconnected but has an actual collection set), the Toggle Maximize Area becomes significantly slower compared to version 4.0.2 and earlier. This makes nearly impossible to work on projects where G.Nodes are utilized heavily (i.e. vegetation scattering). **Exact steps for others to reproduce the error** 1. Open the attached .blend. 2. Toggle Maximize Area of the 3D viewport first in 4.0.2 (or earlier like 3.4.x), and then in 4.2 and higher). 3. Delete the Collection Info node (or remove the Suzanne collection from it) and try it again. 4. Disabling Realize Instances also makes it fast again.
toggle-maximize-gnodes.blend
7.1 MiB
Jan Kadeřábek added the
Type
Report
Status
Needs Triage
Severity
Normal
 labels 2024-08-11 21:02:29 +02:00
Pratik Borhade commented 2024-08-12 05:30:21 +02:00
Member
Copy Link

Hi, thanks for the report. Unable to confirm. Both 4.0 and 4.2 looks fast when playing with the nodes (changing socket value does take few seconds but that's expected due to evaluation).
Any improvements after factory reset inn 4.2?: File > Defaults > Load Factory Settings -> ctrl +o to open "toggle-maximize-gnodes.blend" (Don't close blender otherwise factory preferences are lost)

Hi, thanks for the report. Unable to confirm. Both 4.0 and 4.2 looks fast when playing with the nodes (changing socket value does take few seconds but that's expected due to evaluation). Any improvements after factory reset inn 4.2?: `File > Defaults > Load Factory Settings` -> ctrl +o to open "toggle-maximize-gnodes.blend" (Don't close blender otherwise factory preferences are lost)
Pratik Borhade added
Status
Needs Information from User
 and removed
Status
Needs Triage
 labels 2024-08-12 05:30:43 +02:00
Tom Smalley commented 2024-08-12 09:40:55 +02:00
Copy Link

Hi, thanks for the report. Unable to confirm. Both 4.0 and 4.2 looks fast when playing with the nodes (changing socket value does take few seconds but that's expected due to evaluation).
Any improvements after factory reset inn 4.2?: File > Defaults > Load Factory Settings -> ctrl +o to open "toggle-maximize-gnodes.blend" (Don't close blender otherwise factory preferences are lost)

I don’t think the issue is node manipulation being slow, nor the viewport itself being slow, but rather the ~second delay when toggling one of the areas to maximise (ctrl+space I believe). I can reproduce it in 4.2, and indeed removing the unused collection info node fixes it.

> Hi, thanks for the report. Unable to confirm. Both 4.0 and 4.2 looks fast when playing with the nodes (changing socket value does take few seconds but that's expected due to evaluation). > Any improvements after factory reset inn 4.2?: `File > Defaults > Load Factory Settings` -> ctrl +o to open "toggle-maximize-gnodes.blend" (Don't close blender otherwise factory preferences are lost) I don’t think the issue is node manipulation being slow, nor the viewport itself being slow, but rather the ~second delay when toggling one of the areas to maximise (ctrl+space I believe). I can reproduce it in 4.2, and indeed removing the unused collection info node fixes it.
👍 1
Jan Kadeřábek commented 2024-08-12 09:52:39 +02:00
Author
Copy Link

Hi, thanks for the report. Unable to confirm. Both 4.0 and 4.2 looks fast when playing with the nodes (changing socket value does take few seconds but that's expected due to evaluation).
Any improvements after factory reset inn 4.2?: File > Defaults > Load Factory Settings -> ctrl +o to open "toggle-maximize-gnodes.blend" (Don't close blender otherwise factory preferences are lost)

It's the Toggle Maximize Area which gets slow, not the actual nodes.
In the attached video I am using Blender 4.2.0 LTS & factory defaults.

> Hi, thanks for the report. Unable to confirm. Both 4.0 and 4.2 looks fast when playing with the nodes (changing socket value does take few seconds but that's expected due to evaluation). > Any improvements after factory reset inn 4.2?: `File > Defaults > Load Factory Settings` -> ctrl +o to open "toggle-maximize-gnodes.blend" (Don't close blender otherwise factory preferences are lost) It's the Toggle Maximize Area which gets slow, not the actual nodes. In the attached video I am using Blender 4.2.0 LTS & factory defaults.
2024-08-12 09-47-02.mp4
10 MiB
Pratik Borhade commented 2024-08-12 10:18:15 +02:00
Member
Copy Link

I see, can confirm. Sorry for the confusion 😅

I see, can confirm. Sorry for the confusion 😅
👍 1
Pratik Borhade changed title from Toggle Maximize Area & Geometry Nodes slow in Blender >4.2 to Regression: Toggle Maximize Area slower with geometry nodes 2024-08-12 10:19:26 +02:00
Pratik Borhade commented 2024-08-12 10:31:55 +02:00
Member
Copy Link

Broke between d0359d066db9 - 4effcd33a3f9

Broke between `d0359d066db9 - 4effcd33a3f9`
Iliya Katushenock added this to the 4.2 LTS milestone 2024-08-12 11:35:59 +02:00
Bastien Montagne commented 2024-08-12 16:31:42 +02:00
Owner
Copy Link

@mod_moder It's usually a good practice to explain why you move an issue to a module you are not a member of. I would assume you did some investigations to make that decision, would also be nice to have them documented here.

@mod_moder It's usually a good practice to explain why you move an issue to a module you are not a member of. I would assume you did some investigations to make that decision, would also be nice to have them documented here.
Iliya Katushenock commented 2024-08-12 17:32:33 +02:00
Member
Copy Link

@mont29 issue not in geometry nodes modifier but in updates tagging for things which depends on the collection. You change the view (in this case) and collection is tagged to update.

@mont29 issue not in geometry nodes modifier but in updates tagging for things which depends on the collection. You change the view (in this case) and collection is tagged to update.
Bastien Montagne commented 2024-08-12 17:58:56 +02:00
Owner
Copy Link

@mod_moder Please be a bit more specific about what you found so far about that issue (i.e. places in code that are the source of it e.g.). So far, this sounds like an Node Editor issue? Core module is not responsible of which code tags which ID for updates...

@mod_moder Please be a bit more specific about what you found so far about that issue (i.e. places in code that are the source of it e.g.). So far, this sounds like an Node Editor issue? Core module is not responsible of which code tags which ID for updates...
Iliya Katushenock commented 2024-08-12 18:25:42 +02:00
Member
Copy Link

Any modifier that do depend on the collection ID is get update tag when something does in this switch (mixize area -> back...). @mont29 is this looks more correct for you to change this to UI module?

Any modifier that do depend on the collection ID is get update tag when something does in this switch (mixize area -> back...). @mont29 is this looks more correct for you to change this to UI module?
👀 1
Iliya Katushenock added
Module
User Interface
 and removed
Module
Core
 labels 2024-08-12 18:34:52 +02:00
Bart van der Braak added
Type
Bug
 and removed
Type
Report
 labels 2024-08-14 12:52:37 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
4.2 LTS
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#126205
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?