Crash on appending collection twice that contains a nested liboverride collection (request to backport, fixed in main) #126879

New Issue

Albert-OShea · 2024-08-28T11:10:02+02:00

Albert-OShea commented

2024-08-28 11:10:02 +02:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.99

Blender Version
Broken: version: 4.2.1 LTS, branch: blender-v4.2-release, commit date: 2024-08-19 11:21, hash: 396f546c9d82
Worked: ?

Short description of error
Blender crashes when appending the same collection two times, if that collection contains a liboverride collection linked from a different file (this may not be the exact reason/process that causes the crash, but I think I have simplified the setup more than enough to narrow it down).

Exact steps for others to reproduce the error

Download both attached blend files and store them in the same directory.
Open a new startup file.
Do File > Append, navigate to library.blend, select Collection, select and Append CH-mav-hiviz_worker_01
Once the collection is appended, repeat above step (append the same collection again)
Blender crashes.
Note: Enabling the Instance Collections option when appending also causes the crash, and same with appending the collection from the asset browser.

To repro this ERROR from scratch

add a cube with a lattice modifier (also a lattice target) and save as lib_nested.blend
in a new file, link the collection from lib_nested.blend
make a library override on the collection
make a library override on the cube as well
add a new (local to that file) lattice
override the cube's modifier target to be the local lattice
save as lib.blend
once again in a new file, append the Collection from lib.blend with default settings
(this will already give the "Existing override hierarchy root is invalid, will try to find a new valid one" ERROR )
append the Collection from lib.blend with default settings again
(this will give the "Local ID found as part of the linked data hierarchy, this should never happen" ERROR )

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.99 **Blender Version** Broken: version: 4.2.1 LTS, branch: blender-v4.2-release, commit date: 2024-08-19 11:21, hash: `396f546c9d82` Worked: ? **Short description of error** Blender crashes when appending the same collection two times, if that collection contains a liboverride collection linked from a different file (this may not be the exact reason/process that causes the crash, but I think I have simplified the setup more than enough to narrow it down). **Exact steps for others to reproduce the error** - Download both attached blend files and store them in the same directory. - Open a new startup file. - Do `File > Append`, navigate to `library.blend`, select `Collection`, select and Append `CH-mav-hiviz_worker_01` - Once the collection is appended, repeat above step (append the same collection again) - Blender crashes. - Note: Enabling the `Instance Collections` option when appending also causes the crash, and same with appending the collection from the asset browser. **To repro this ERROR from scratch** - add a cube with a lattice modifier (also a lattice target) and save as `lib_nested.blend` - in a new file, link the collection from `lib_nested.blend` - make a library override on the collection - make a library override on the cube as well - add a new (local to that file) lattice - override the cube's modifier target to be the local lattice - save as `lib.blend` - once again in a new file, append the `Collection` from `lib.blend` with default settings - (this will already give the "Existing override hierarchy root is invalid, will try to find a new valid one" ERROR ) - append the `Collection` from `lib.blend` with default settings **again** - (this will give the "Local ID found as part of the linked data hierarchy, this should never happen" ERROR )

nested_library.blend

452 KiB

library.blend

647 KiB

Albert-OShea added the

labels 2024-08-28 11:10:03 +02:00

Philipp Oeser commented

2024-08-28 13:13:10 +02:00

Can confirm the crash in 4.2.1

4.3 alpha does not seem to crash anymore (will check which commit fixed it -- and if it is on the backport list already)

However, even in 4.3, I am getting the following:

ERROR (bke.liboverride): source/blender/blenkernel/intern/lib_override.cc:1908 BKE_lib_override_library_main_hierarchy_root_ensure: Existing override hierarchy root ('GRmav-head-pete') for ID 'OBGEO-mav-head-pete' is invalid, will try to find a new valid one
ERROR (bke.blendfile_link_append): source/blender/blenkernel/intern/blendfile_link_append.cc:982 foreach_libblock_link_append_common_processing: Local ID 'OBRIG-mav' found as part of the linked data hierarchy, this should never happen
ERROR (bke.blendfile_link_append): source/blender/blenkernel/intern/blendfile_link_append.cc:982 foreach_libblock_link_append_common_processing: Local ID 'OBRIG-mav' found as part of the linked data hierarchy, this should never happen

Can confirm the crash in 4.2.1 4.3 alpha does not seem to crash anymore (will check which commit fixed it -- and if it is on the backport list already) However, even in 4.3, I am getting the following: ```C ERROR (bke.liboverride): source/blender/blenkernel/intern/lib_override.cc:1908 BKE_lib_override_library_main_hierarchy_root_ensure: Existing override hierarchy root ('GRmav-head-pete') for ID 'OBGEO-mav-head-pete' is invalid, will try to find a new valid one ERROR (bke.blendfile_link_append): source/blender/blenkernel/intern/blendfile_link_append.cc:982 foreach_libblock_link_append_common_processing: Local ID 'OBRIG-mav' found as part of the linked data hierarchy, this should never happen ERROR (bke.blendfile_link_append): source/blender/blenkernel/intern/blendfile_link_append.cc:982 foreach_libblock_link_append_common_processing: Local ID 'OBRIG-mav' found as part of the linked data hierarchy, this should never happen ```

Philipp Oeser commented

2024-08-28 13:21:42 +02:00

fixed between 7c68ac258f and d5e591b3dc (probably by dcadb3301e)
@mont29 : dcadb3301e seems safe enough to put on #124452 ?

fixed between 7c68ac258f34 and d5e591b3dc8c (probably by dcadb3301ef0d09fa5969f2109eeb73e3c8a8d0a) @mont29 : dcadb3301ef0d09fa5969f2109eeb73e3c8a8d0a seems safe enough to put on #124452 ?

Philipp Oeser added

and removed

labels 2024-08-28 13:21:58 +02:00

Philipp Oeser added this to the 4.2 LTS milestone 2024-08-28 13:22:05 +02:00

Philipp Oeser changed title from ~~Crash on appending collection twice that contains a nested liboverride collection~~ to Crash on appending collection twice that contains a nested liboverride collection (request to backport, fixed in main)

2024-08-28 13:22:29 +02:00

Albert-OShea commented

2024-08-28 13:31:18 +02:00

Pardon my 2 cents but could this be a flaw with the Localize All option that is enabled by default when appending? Theoretically this should remove all linked references in the first place, correct?

Pardon my 2 cents but could this be a flaw with the `Localize All` option that is enabled by default when appending? Theoretically this should remove all linked references in the first place, correct?

Philipp Oeser commented

2024-08-28 14:20:51 +02:00

To repro this ERROR from scratch:

add a cube with a lattice modifier (also a lattice target) and save as lib_nested.blend
in a new file, link the collection from lib_nested.blend
make a library override on the collection
make a library override on the cube as well
add a new (local to that file) lattice
override the cube's modifier target to be the local lattice
save as lib.blend
once again in a new file, append the Collection from lib.blend with default settings
(this will already give the "Existing override hierarchy root is invalid, will try to find a new valid one" ERROR )
append the Collection from lib.blend with default settings again
(this will give the "Local ID found as part of the linked data hierarchy, this should never happen" ERROR )

@mont29 : this does not sound like the "dirty hacks. Ideally we could fully forbid such assignement in BPY/RNA API" case mentioned in the commit message from dcadb3301e ?

To repro this ERROR from scratch: - add a cube with a lattice modifier (also a lattice target) and save as `lib_nested.blend` - in a new file, link the collection from `lib_nested.blend` - make a library override on the collection - make a library override on the cube as well - add a new (local to that file) lattice - override the cube's modifier target to be the local lattice - save as `lib.blend` - once again in a new file, append the `Collection` from `lib.blend` with default settings - (this will already give the "Existing override hierarchy root is invalid, will try to find a new valid one" ERROR ) - append the `Collection` from `lib.blend` with default settings **again** - (this will give the "Local ID found as part of the linked data hierarchy, this should never happen" ERROR ) @mont29 : this does not sound like the "dirty hacks. Ideally we could fully forbid such assignement in BPY/RNA API" case mentioned in the commit message from dcadb3301ef0d09fa5969f2109eeb73e3c8a8d0a ?

Bastien Montagne commented

2024-08-28 15:49:35 +02:00

This is going to be an interesting one... Thing is, we do specific handling of liboverrides on append, with the assumption that user want to get a local liboverride, and not a completely 'flat local' data, when they append a liboverride from another library. Will see when I can dig and understand the root of this issue.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash on appending collection twice that contains a nested liboverride collection (request to backport, fixed in main) #126879