Regression: Sculpt: Hovering with pose brush on dense mesh freezes Blender #127259

New Issue

Nika Kutsniashvili · 2024-09-06T17:18:29+02:00

2024-09-06 17:18:29 +02:00

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 560.70

Blender Version
Broken: version: 4.3.0 Alpha, branch: main, commit date: 2024-07-09 23:04, hash: 3b23dc4b4d47
Broken: version: 4.3.0 Alpha, branch: main, commit date: 2024-09-06 09:15, hash: 73f2bdd1ed1b
Worked: version: 4.3.0 Alpha, branch: main, commit date: 2024-06-21 23:31, hash: 8f95c2ce9fcf

Short description of error
While checking performance in 4.2 vs 4.3 I noticed that on subdivided mesh (6.2mil faces) choosing pose brush and trying to hover over the mesh freezes Blender for a while, and performance doesn't improve. After its unfrozen, trying to hover again freezes again.

Exact steps for others to reproduce the error

Subdivide default cube 10 times to get 6.2 mil faces, apply subdivision
Go to sculpt mode, choose Pose brush and try to hover over the mesh

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 560.70 **Blender Version** Broken: version: 4.3.0 Alpha, branch: main, commit date: 2024-07-09 23:04, hash: `3b23dc4b4d47` Broken: version: 4.3.0 Alpha, branch: main, commit date: 2024-09-06 09:15, hash: `73f2bdd1ed1b` Worked: version: 4.3.0 Alpha, branch: main, commit date: 2024-06-21 23:31, hash: `8f95c2ce9fcf` **Short description of error** While checking performance in 4.2 vs 4.3 I noticed that on subdivided mesh (6.2mil faces) choosing pose brush and trying to hover over the mesh freezes Blender for a while, and performance doesn't improve. After its unfrozen, trying to hover again freezes again. **Exact steps for others to reproduce the error** 1. Subdivide default cube 10 times to get 6.2 mil faces, apply subdivision 2. Go to sculpt mode, choose Pose brush and try to hover over the mesh

Nika Kutsniashvili added the

labels 2024-09-06 17:18:30 +02:00

Nika Kutsniashvili changed title from ~~Regression: Hovering with pose brush on dense mesh freezes Blender~~ to Regression: Sculpt: Hovering with pose brush on dense mesh freezes Blender

2024-09-06 17:26:46 +02:00

Sean Kim commented

2024-09-07 00:23:45 +02:00

Can confirm

Sean Kim added

Module

Sculpt, Paint & Texture

and removed

labels 2024-09-07 00:24:15 +02:00

Sean Kim commented

2024-09-07 00:57:54 +02:00

Updated original post, regression happened between

8f95c2ce9fcf ~ 3b23dc4b4d47

Updated original post, regression happened between `8f95c2ce9fcf` ~ `3b23dc4b4d47`

Sean Kim commented

2024-09-07 02:36:40 +02:00

Doing some profiling on this, the vast majority of processing time (86%) is spent on vert_neighbors_get_mesh

Doing some profiling on this, the vast majority of processing time (86%) is spent on `vert_neighbors_get_mesh`

Sean Kim commented

2024-09-07 07:13:03 +02:00

Somehow the bad commit here is 7b0ea0f1b4

Somehow the bad commit here is 7b0ea0f1b4309d8445b5027f1bfe8e0cbe90a91c

Sean Kim commented

2024-09-09 18:30:37 +02:00

The cause of the slowdown is the "Pose Origin Offset" field changing from a default of 0.0 to 0.35, requiring more preprocessing of data both when using the brush and updating the preview

@JulienKaspar - Do you have more context here on the decision to update this value as part of the Brush Asset project? Is this something we should revert, or is this something we'll need to find a way to optimize?

The cause of the slowdown is the "Pose Origin Offset" field changing from a default of 0.0 to 0.35, requiring more preprocessing of data both when using the brush and updating the preview @JulienKaspar - Do you have more context here on the decision to update this value as part of the Brush Asset project? Is this something we should revert, or is this something we'll need to find a way to optimize?

Julien Kaspar commented

2024-09-10 09:59:32 +02:00

I never realized that this setting is what caused the brush to perform so terribly ...
For now I'm totally in favor of setting the Pose Origin setting to 0.0 for the brush asset.

I'm even if favor of removing it until it is optimized and working like intended. It always offsets the pose origin in a straight line between itself and the cursor center, which is often very unintuitive and leads to the offset being off-target, or even completely outside of the object.

I never realized that this setting is what caused the brush to perform so terribly ... For now I'm totally in favor of setting the Pose Origin setting to 0.0 for the brush asset. I'm even if favor of removing it until it is optimized and working like intended. It always offsets the pose origin in a straight line between itself and the cursor center, which is often very unintuitive and leads to the offset being off-target, or even completely outside of the object.

Sean Kim referenced this issue from blender/blender-assets

2024-09-10 22:07:00 +02:00

Assets: Sculpt: Update default pose brush offset value #10

Sean Kim referenced this issue from a commit

2024-09-11 19:49:34 +02:00

Assets: Sculpt: Update default pose brush offset value (#10)

Sean Kim referenced a pull request that will close this issue

2024-09-11 20:04:58 +02:00

Fix #127259: Slow pose brush performance on dense mesh #127466

Sean Kim referenced this issue from a commit

2024-09-11 20:07:53 +02:00

Fix #127259: Slow pose brush performance on dense mesh