blender/blender
167
522
Fork 797
Code Issues 6.8k Pull Requests 947 Projects 21 Wiki Activity

Markers selection seems inconsistent #129630

New Issue
Closed
opened 2024-10-31 13:13:43 +01:00 by magnative · 6 comments
magnative commented 2024-10-31 13:13:43 +01:00
Copy Link

System Information
Operating system: macOS-14.7-arm64-arm-64bit 64 Bits
Graphics card: Metal API Apple M2 Pro 1.2

Blender Version
Broken: version: 4.1.1, branch: blender-v4.1-release, commit date: 2024-04-15 15:11, hash: e1743a0317bc
Worked: 3.1.2
Short description of error

I'm not sure if this is enough for a bug report
I think markers selection behavior should be similar to selection of keyframe since they are next to each other

Task 3.1.2 3.2-4.2.3 Is Work with keyframe? Notes
Select All with A (and Alt A to deselect all) ✅ ✅ ✅ --------
Hold Shift then Click on to select more/less ✅ ✅ ✅ --------
Click and Hold then Drag mouse to box select ✅ ❌ ✅ Do in markers area, From 3.2 you can't even click/hold drag to box select
Hold Shift then Drag to box select more ❌ ❌ ✅ It will deselect all markers
Hold Ctrl(or Command) then Drag to select less ❌ ❌ ✅ It will deselect all markers
Hold Ctrl(or Command) then Drag with opposite select mouse to lasso select ❌ ❌ ✅ --------
Press B then click drag to Box select ✅ ✅ ✅ --------
Press C then click drag to Circle select ❌ ❌ ✅ --------

So box selection work only when you press B to do it from 3.2
I hope it just Shift + Drag to select more and Ctrl + Drag to select less markers just like keyframes

Exact steps for others to reproduce the error

  • Open Blender.
  • Use LMB selection mode in preferences.
  • Add multiple markers (press M at different points on the timeline) and keyframes to the timeline area.
  • Try using the selection methods described (like dragging to box select, etc.) and observe the inconsistent behavior.
**System Information** Operating system: macOS-14.7-arm64-arm-64bit 64 Bits Graphics card: Metal API Apple M2 Pro 1.2 **Blender Version** Broken: version: 4.1.1, branch: blender-v4.1-release, commit date: 2024-04-15 15:11, hash: `e1743a0317bc` Worked: 3.1.2 **Short description of error** I'm not sure if this is enough for a bug report I think markers selection behavior should be similar to selection of keyframe since they are next to each other | Task | 3.1.2 | 3.2-4.2.3 | Is Work with keyframe? | Notes | | -------- | -------- | -------- | -------- | -------- | | Select All with A (and Alt A to deselect all) | ✅ | ✅ | ✅ | -------- | | Hold Shift then Click on to select more/less | ✅ | ✅ | ✅ | -------- | | Click and Hold then Drag mouse to box select | ✅ | ❌ | ✅ | Do in markers area, From 3.2 you can't even click/hold drag to box select | | Hold Shift then Drag to box select more | ❌ | ❌ | ✅ | It will deselect all markers | | Hold Ctrl(or Command) then Drag to select less | ❌ | ❌ | ✅ | It will deselect all markers | | Hold Ctrl(or Command) then Drag with opposite select mouse to lasso select | ❌ | ❌ | ✅ | -------- | | Press B then click drag to Box select | ✅ | ✅ | ✅ | -------- | | Press C then click drag to Circle select | ❌ | ❌ | ✅ | -------- | So box selection work only when you press B to do it from 3.2 I hope it just Shift + Drag to select more and Ctrl + Drag to select less markers just like keyframes **Exact steps for others to reproduce the error** - Open Blender. - Use LMB selection mode in preferences. - Add multiple markers (press M at different points on the timeline) and keyframes to the timeline area. - Try using the selection methods described (like dragging to box select, etc.) and observe the inconsistent behavior.
magnative added the
Status
Needs Triage
Severity
Normal
Type
Bug
 labels 2024-10-31 13:13:43 +01:00
Germano Cavalcante commented 2024-10-31 15:25:49 +01:00
Member
Copy Link

I can confirm the issue.
It worked in Blender 3.1.2, and the inconsistency in 4.2 can be classified as a regression bug.
Not sure if it is related, but the release notes states:

Markers are easier to select (f1ae6952a8), with new operators to select all of them, or left/right of the current frame (including the current frame, if it's on a marker).

Cc @dr.sybren

I can confirm the issue. It worked in Blender 3.1.2, and the inconsistency in 4.2 can be classified as a regression bug. Not sure if it is related, but the [release notes](https://developer.blender.org/docs/release_notes/3.2/animation_rigging/) states: > Markers are easier to select (f1ae6952a8), with new operators to select all of them, or left/right of the current frame (including the current frame, if it's on a marker). Cc @dr.sybren
❤️ 1
Sybren A. Stüvel changed title from Markers selection seem inconsistance to Markers selection seems inconsistent 2024-10-31 17:03:37 +01:00
Sybren A. Stüvel self-assigned this 2024-11-04 11:25:44 +01:00
Sybren A. Stüvel commented 2024-11-04 11:37:18 +01:00
Member
Copy Link

I can't reproduce the inconsistency with "Click and Hold then Drag mouse to box select" on Blender 4.3-alpha, so it seems like that got fixed already.

This is me dragging with left mouse, with Left Mouse Select in the prefs:

I can't reproduce the inconsistency with "Click and Hold then Drag mouse to box select" on Blender 4.3-alpha, so it seems like that got fixed already. This is me dragging with left mouse, with Left Mouse Select in the prefs: <video src="/attachments/5d8a2d7c-3c0c-4686-a4f8-5039e353370a" title="recording-2024-11-04_11.36.05.mp4" controls></video>
recording-2024-11-04_11.36.05.mp4
40 KiB
Sybren A. Stüvel commented 2024-11-04 11:52:35 +01:00
Member
Copy Link

I think markers selection behavior should be similar to selection of keyframe since they are next to each other

I don't fully agree with this reasoning, by the way. Editing keys is a much more common operation than editing markers. The fact that the former has more possible ways to select & manipulate things than the latter is not a bug.

It worked in Blender 3.1.2, and the inconsistency in 4.2 can be classified as a regression bug.

That I agree with, but it seems to have been fixed already? I can't reproduce this issue in 4.2.3.

> I think markers selection behavior should be similar to selection of keyframe since they are next to each other I don't fully agree with this reasoning, by the way. Editing keys is a much more common operation than editing markers. The fact that the former has more possible ways to select & manipulate things than the latter is not a bug. > It worked in Blender 3.1.2, and the inconsistency in 4.2 can be classified as a regression bug. That I agree with, but it seems to have been fixed already? I can't reproduce this issue in 4.2.3.
Sybren A. Stüvel added
Status
Needs Information from User
 and removed
Status
Confirmed
 labels 2024-11-04 11:53:12 +01:00
magnative commented 2024-11-04 14:13:50 +01:00
Author
Copy Link

It worked in Blender 3.1.2, and the inconsistency in 4.2 can be classified as a regression bug.

That I agree with, but it seems to have been fixed already? I can't reproduce this issue in 4.2.3.

I test again with 4.2.3

Seem like that work with only some mode

Mode that work

  • Graph Editor
  • Action Editor
  • Shape Key Editor
  • Nonlinear Animation

Mode that doesn't work

  • Dope Sheet
  • Timeline
  • Grease Pencil
  • Mask
  • Cache File

> > > It worked in Blender 3.1.2, and the inconsistency in 4.2 can be classified as a regression bug. > > That I agree with, but it seems to have been fixed already? I can't reproduce this issue in 4.2.3. > I test again with 4.2.3 Seem like that work with only some mode Mode that work - Graph Editor - Action Editor - Shape Key Editor - Nonlinear Animation Mode that doesn't work - Dope Sheet - Timeline - Grease Pencil - Mask - Cache File <video src="/attachments/52ee43b0-661f-455d-aa01-91c0416b7a30" title="Marker2.mp4" controls></video>
Marker2.mp4
9.5 MiB
❤️ 1
Sybren A. Stüvel added
Status
Confirmed
 and removed
Status
Needs Information from User
 labels 2024-11-04 16:29:17 +01:00
Sybren A. Stüvel commented 2024-11-04 16:30:18 +01:00
Member
Copy Link

It seems to be a conflict between these two keymap items. If I remove the first one, the box-drag-select works just fine.

        ("marker.select", {"type": params.select_mouse, "value": 'PRESS'}, None),
        ("marker.select_box", {"type": params.select_mouse, "value": 'CLICK_DRAG'},
         {"properties": [("tweak", True)]}),

I'll discuss with the UI module what's the best way to get this fixed.

It seems to be a conflict between these two keymap items. If I remove the first one, the box-drag-select works just fine. ```python ("marker.select", {"type": params.select_mouse, "value": 'PRESS'}, None), ("marker.select_box", {"type": params.select_mouse, "value": 'CLICK_DRAG'}, {"properties": [("tweak", True)]}), ``` I'll discuss with the UI module what's the best way to get this fixed.
❤️ 1
Sybren A. Stüvel added
Severity
Normal
Interest
User Interface
 and removed
Severity
High
 labels 2024-11-07 12:48:29 +01:00
Campbell Barton commented 2024-11-08 00:11:55 +01:00
Owner
Copy Link

From looking into this, some notes for the record:

Selection in animation/2D views uses fairly intricate logic to activate either: select-picking / tweak (select + translate) / box-select / de-select all. Internally a press event may start a modal operator that waits for release or drag.

The marker region attempts to activate selection operators for both the dope-sheet & markers - where both are attempting to handle the press/release/drag actions. Which isn't working - it's not even clear to me how this would be expected to work.

Since two keymaps attempting to handle the events is fragile & error prone - changes to event handling in this area is likely to cause user visible changes, so I don't think it's especially useful to dig into when behavior changed, unless the previous functionality was fully functional.

As far as I can see it's simply not practical to attempt to handle the selection logic with two key-maps at once, submitted PR to address this !129841.

From looking into this, some notes for the record: Selection in animation/2D views uses fairly intricate logic to activate either: select-picking / tweak (select + translate) / box-select / de-select all. Internally a press event may start a modal operator that waits for release or drag. The marker region attempts to activate selection operators for both the dope-sheet & markers - where both are attempting to handle the press/release/drag actions. Which isn't working - it's not even clear to me how this would be expected to work. Since two keymaps attempting to handle the events is fragile & error prone - changes to event handling in this area is likely to cause user visible changes, so I don't think it's especially useful to dig into when behavior changed, unless the previous functionality was fully functional. As far as I can see it's simply not practical to attempt to handle the selection logic with two key-maps at once, submitted PR to address this !129841.
Blender Bot added
Status
Resolved
 and removed
Status
Confirmed
 labels 2024-11-12 10:38:20 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
FBX
FBX I/O related topics

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
glTF
glTF format I/O topics

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Asset System

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Sybren A. Stüvel
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#129630
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?