Multi-Button Drag: not working properly for Object Dimensions #38587

New Issue

CodeManX · 2014-02-11T02:32:35+01:00

CodeManX commented

2014-02-11 02:32:35 +01:00

System Information
Windows 7

Blender Version
Broken: 2014-02-11

Short description of error
Multi-Button Drag - https://developer.blender.org/D270 - doesn't work properly in N panel for Dimensions

If you drag over all 3, only X and Z change, Y remains unchanged. As mouse button is released, the first selected property will reset, only the last hovered is kept (and scale changed)

**System Information** Windows 7 **Blender Version** Broken: 2014-02-11 **Short description of error** Multi-Button Drag - https://developer.blender.org/D270 - doesn't work properly in N panel for Dimensions If you drag over all 3, only X and Z change, Y remains unchanged. As mouse button is released, the first selected property will reset, only the last hovered is kept (and scale changed)

CodeManX commented

2014-02-11 02:32:35 +01:00

Changed status to: 'Open'

CodeManX commented

2014-02-11 02:32:35 +01:00

Added subscriber: @CodeManX

blender-admin commented

2014-02-11 02:32:35 +01:00

#64496 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#55225 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#47977 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#46025 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#44340 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#42657 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#41347 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#42759 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#42433 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#40511 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#38760 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#39019 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#39227 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#39665 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#38820 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#50043 was marked as duplicate of this issue

blender-admin commented

2014-02-11 02:32:35 +01:00

#49638 was marked as duplicate of this issue

CodeManX changed title from ~~Multi-Button Drag: Only X and Z work for Object Dimensions~~ to Multi-Button Drag: not working properly for Object Dimensions

2014-02-11 02:36:06 +01:00

Joshua Leung commented

2014-02-11 04:31:14 +01:00

Added subscriber: @JoshuaLeung

Campbell Barton was assigned by Sergey Sharybin

2014-02-12 10:43:26 +01:00

Sergey Sharybin commented

2014-02-12 10:43:26 +01:00

Added subscriber: @Sergey

Campbell Barton commented

2014-02-12 18:45:43 +01:00

Object dimensions are broken and an abuse of RNA, IMHO - the same problem happens from Python and we had it reported too.

Basically they rely on one axis being set, then updating - before the other values are set.

This is in fact the same bug:

However since this is so user visible, it really should be addressed somehow, leaving open.

Object dimensions are broken and an abuse of RNA, IMHO - the same problem happens from Python and we had it reported too. Basically they rely on one axis being set, then updating - before the other values are set. This is in fact the same bug: - https://developer.blender.org/T31760 - https://developer.blender.org/T36958 However since this is so user visible, it really should be addressed somehow, leaving open.

Brecht Van Lommel commented

2014-02-22 16:49:41 +01:00

Added subscriber: @lucacustom

Brecht Van Lommel commented

2014-02-22 16:49:41 +01:00

◀ Merged tasks: #38760.

Campbell Barton commented

2014-02-25 02:15:42 +01:00

Added subscribers: @candreacchio, @dfelinto

Campbell Barton commented

2014-02-25 02:15:42 +01:00

◀ Merged tasks: #38820.

Angel Pat commented

2014-03-01 00:59:30 +01:00

Added subscriber: @AngelPat

Campbell Barton commented

2014-03-08 02:07:05 +01:00

Added subscribers: @PabloGilFernandez, @mont29, @DuarteRamos

Campbell Barton commented

2014-03-08 02:07:05 +01:00

◀ Merged tasks: #39019.

Bastien Montagne commented

2014-03-15 13:00:16 +01:00

Uh, well, decided to have a quick look at this one, and I realized BKE_object_dimensions_set() was quite broken (just add two objects, parent one to the other, scale parent e.g. 0.5, and try setting dimension of child…). So I wrote this patch, and to my surprise it seems to also fix that bug!

P24: Fix "Dimension" issues?

diff --git a/source/blender/blenkernel/intern/object.c b/source/blender/blenkernel/intern/object.c
index 0970af4..cbb29d4 100644
--- a/source/blender/blenkernel/intern/object.c
+++ b/source/blender/blenkernel/intern/object.c
@@ -2529,13 +2529,13 @@ void BKE_object_dimensions_set(Object *ob, const float *value)
                
                mat4_to_size(scale, ob->obmat);
                
-               len- [x] = bb->vec- [x]- [x] - bb->vec- [x][0];
-               len- [x] = bb->vec- [x]- [x] - bb->vec- [x][1];
-               len- [x] = bb->vec- [x]- [x] - bb->vec- [x][2];
+               len- [x] = fabsf(scale- [x]) * (bb->vec- [x]- [x] - bb->vec- [x][0]);
+               len- [x] = fabsf(scale- [x]) * (bb->vec- [x]- [x] - bb->vec- [x][1]);
+               len- [x] = fabsf(scale- [x]) * (bb->vec- [x]- [x] - bb->vec- [x][2]);
                
-               if (len- [x] > 0.f) ob->size- [x] = value- [x] / len[0];
-               if (len- [x] > 0.f) ob->size- [x] = value- [x] / len[1];
-               if (len- [x] > 0.f) ob->size- [x] = value- [x] / len[2];
+               if (len- [x] > 0.f) ob->size- [x] *= value- [x] / len[0];
+               if (len- [x] > 0.f) ob->size- [x] *= value- [x] / len[1];
+               if (len- [x] > 0.f) ob->size- [x] *= value- [x] / len[2];
        }
 }

Not sure this covers all possible situation (as already said in another related report, dimension can become rather involved in complex setups), but think it makes it at least less broken. ;)

Uh, well, decided to have a quick look at this one, and I realized BKE_object_dimensions_set() was quite broken (just add two objects, parent one to the other, scale parent e.g. 0.5, and try setting dimension of child…). So I wrote this patch, and to my surprise it seems to also fix that bug! [P24: Fix "Dimension" issues?](https://archive.blender.org/developer/P24.txt) ```diff diff --git a/source/blender/blenkernel/intern/object.c b/source/blender/blenkernel/intern/object.c index 0970af4..cbb29d4 100644 --- a/source/blender/blenkernel/intern/object.c +++ b/source/blender/blenkernel/intern/object.c @@ -2529,13 +2529,13 @@ void BKE_object_dimensions_set(Object *ob, const float *value) mat4_to_size(scale, ob->obmat); - len- [x] = bb->vec- [x]- [x] - bb->vec- [x][0]; - len- [x] = bb->vec- [x]- [x] - bb->vec- [x][1]; - len- [x] = bb->vec- [x]- [x] - bb->vec- [x][2]; + len- [x] = fabsf(scale- [x]) * (bb->vec- [x]- [x] - bb->vec- [x][0]); + len- [x] = fabsf(scale- [x]) * (bb->vec- [x]- [x] - bb->vec- [x][1]); + len- [x] = fabsf(scale- [x]) * (bb->vec- [x]- [x] - bb->vec- [x][2]); - if (len- [x] > 0.f) ob->size- [x] = value- [x] / len[0]; - if (len- [x] > 0.f) ob->size- [x] = value- [x] / len[1]; - if (len- [x] > 0.f) ob->size- [x] = value- [x] / len[2]; + if (len- [x] > 0.f) ob->size- [x] *= value- [x] / len[0]; + if (len- [x] > 0.f) ob->size- [x] *= value- [x] / len[1]; + if (len- [x] > 0.f) ob->size- [x] *= value- [x] / len[2]; } } ``` Not sure this covers all possible situation (as already said in another related report, dimension can become rather involved in complex setups), but think it makes it at least less broken. ;)

Bastien Montagne commented

2014-03-15 22:36:41 +01:00

Added subscriber: @ideasman42

Bastien Montagne commented

2014-03-15 22:36:41 +01:00

Ok, so @ideasman42 noticed previous patch failed when reaching zero value… Here is a new one, there are still some glitches around 0 in case of "grouped drag", but it’s still better (do not have yet idea to fix completely the zero-issue):

void BKE_object_dimensions_set(Object *ob, const float *value)
{
	BoundBox *bb = NULL;

	bb = BKE_object_boundbox_get(ob);
	if (bb) {
		float scale[3], len[3];
		int i = 3;

		mat4_to_size(scale, ob->obmat);

		len[0] = bb->vec[4][0] - bb->vec[0][0];
		len[1] = bb->vec[2][1] - bb->vec[0][1];
		len[2] = bb->vec[1][2] - bb->vec[0][2];

		while (i--) {
			float l = len[i], s = scale[i], v = value[i];

			if (l > 0.0f) {
				if (ELEM(0.0f, s, ob->size[i])) {
					ob->size[i] = v / l;
				}
				else {
					ob->size[i] *= v / (l * fabsf(s));
				}
			}
		}
	}
}

Ok, so @ideasman42 noticed previous patch failed when reaching zero value… Here is a new one, there are still some glitches around 0 in case of "grouped drag", but it’s still better (do not have yet idea to fix completely the zero-issue): ``` void BKE_object_dimensions_set(Object *ob, const float *value) { BoundBox *bb = NULL; bb = BKE_object_boundbox_get(ob); if (bb) { float scale[3], len[3]; int i = 3; mat4_to_size(scale, ob->obmat); len[0] = bb->vec[4][0] - bb->vec[0][0]; len[1] = bb->vec[2][1] - bb->vec[0][1]; len[2] = bb->vec[1][2] - bb->vec[0][2]; while (i--) { float l = len[i], s = scale[i], v = value[i]; if (l > 0.0f) { if (ELEM(0.0f, s, ob->size[i])) { ob->size[i] = v / l; } else { ob->size[i] *= v / (l * fabsf(s)); } } } } }

Bastien Montagne commented

2014-03-17 16:36:37 +01:00

Added subscriber: @EvandroFerreiradaCosta

Bastien Montagne commented

2014-03-17 16:36:37 +01:00

◀ Merged tasks: #39227.

Bastien Montagne commented

2014-04-09 21:32:00 +02:00

Added subscriber: @bliblubli

Bastien Montagne commented

2014-04-09 21:32:01 +02:00

◀ Merged tasks: #39665.

Campbell Barton commented

2014-04-10 04:16:43 +02:00

@mont29, the patch mostly works well, but it has one strange behavior I noticed.

Pasting values into the buttons now fails.

Default cube
Set X scale to 2.0 (so X dimension is 4.0)
Copy the Y scale (1.0) and paste into the Y dimension (2.0) (Ctrl+C, Ctrl+V).
Keep pressing Ctrl+V
Y dimension cycles between 2.0 and 0.5 but never reaches 1.0.

I really think how this button works is broken, probably it shouldn't be using RNA at all and we could instead use callbacks so each situation can be handled better.

@mont29, the patch mostly works well, but it has one strange behavior I noticed. Pasting values into the buttons now fails. - Default cube - Set X scale to 2.0 (so X dimension is 4.0) - Copy the Y scale (1.0) and paste into the Y dimension (2.0) (Ctrl+C, Ctrl+V). - Keep pressing Ctrl+V - Y dimension cycles between 2.0 and 0.5 but never reaches 1.0. I really think how this button works is broken, probably it shouldn't be using RNA at all and we could instead use callbacks so each situation can be handled better.

Bastien Montagne commented

2014-04-10 20:01:57 +02:00

@ideasman42 imho, it’s not RNA the issue here, it’s that (to handle correctly things like parent-related scaling), we need to use ob->obmat to get current object's scale, and yet we set ob->size. The problem is that in some cases (like e.g. pasting values), BKE_object_dimensions_set() is called twice or more without any object update in between, so ob->obmat becomes obsolete.

This quick (and dirty, obviously not a good solution as is, just could not find a nice way to get current scene here) hack “fixes” it:

P35: #38587 related

void BKE_object_dimensions_set(Object *ob, const float value[3])
{
	BoundBox *bb = NULL;

	bb = BKE_object_boundbox_get(ob);
	if (bb) {
		float obmat- [x][4];
		float scale- [x], len[3];
		int i = 3;

		mat4_to_size(scale, ob->obmat);

		len- [x] = bb->vec- [x]- [x] - bb->vec- [x][0];
		len- [x] = bb->vec- [x]- [x] - bb->vec- [x][1];
		len- [x] = bb->vec- [x]- [x] - bb->vec- [x][2];

		print_v3("value", value);
		print_v3("scale", scale);
		print_v3("ob->size", ob->size);
		print_v3("len", len);
		printf("\n");

		while (i--) {
			float l = len- [x], s = scale- [x], v = value[i];

			if (l > 0.0f) {
				if (ELEM(0.0f, s, ob->size[i])) {
					ob->size- [x] = v / l;
				}
				else {
					ob->size- [x] *= v / (l * fabsf(s));
				}
			}
		}
		BKE_object_where_is_calc_mat4(G.main->scene.first, ob, ob->obmat);
	}
}

Now how to do this properly, I do not know really. Is it possible to get a valid scene from on object pointer? Or, probably better, to flush tagged updates in RNA update func?

@ideasman42 imho, it’s not RNA the issue here, it’s that (to handle correctly things like parent-related scaling), we need to use `ob->obmat` to get current object's scale, and yet we set `ob->size`. The problem is that in some cases (like e.g. pasting values), `BKE_object_dimensions_set()` is called twice or more without any object update in between, so `ob->obmat` becomes obsolete. This quick (and dirty, obviously not a good solution as is, just could not find a nice way to get current scene here) hack “fixes” it: [P35: #38587 related](https://archive.blender.org/developer/P35.txt) ```c void BKE_object_dimensions_set(Object *ob, const float value[3]) { BoundBox *bb = NULL; bb = BKE_object_boundbox_get(ob); if (bb) { float obmat- [x][4]; float scale- [x], len[3]; int i = 3; mat4_to_size(scale, ob->obmat); len- [x] = bb->vec- [x]- [x] - bb->vec- [x][0]; len- [x] = bb->vec- [x]- [x] - bb->vec- [x][1]; len- [x] = bb->vec- [x]- [x] - bb->vec- [x][2]; print_v3("value", value); print_v3("scale", scale); print_v3("ob->size", ob->size); print_v3("len", len); printf("\n"); while (i--) { float l = len- [x], s = scale- [x], v = value[i]; if (l > 0.0f) { if (ELEM(0.0f, s, ob->size[i])) { ob->size- [x] = v / l; } else { ob->size- [x] *= v / (l * fabsf(s)); } } } BKE_object_where_is_calc_mat4(G.main->scene.first, ob, ob->obmat); } } ``` Now how to do this properly, I do not know really. Is it possible to get a valid scene from on object pointer? Or, probably better, to flush tagged updates in RNA update func?

Campbell Barton commented

2014-04-22 15:51:40 +02:00

@mont29. the hack you propose could be made to work, but I would rather investigate some way to apply all buttons at once.

Or, redo the dimensions in C/ui.
dont use RNA for it, and have whatever hacks that are needed as callback functions for the C defined buttons.

@mont29. the hack you propose could be made to work, but I would rather investigate some way to apply all buttons at once. Or, redo the dimensions in C/ui. dont use RNA for it, and have whatever hacks that are needed as callback functions for the C defined buttons.

Campbell Barton commented

2014-06-06 08:13:33 +02:00

Added subscriber: @gandalf3

Campbell Barton commented

2014-06-06 08:13:33 +02:00

◀ Merged tasks: #40511.

Campbell Barton commented

2014-08-07 00:40:08 +02:00

Added subscriber: @Druban

Campbell Barton commented

2014-08-07 00:40:08 +02:00

◀ Merged tasks: #41347.

Campbell Barton commented

2014-10-29 08:58:46 +01:00

Added subscriber: @MikhailRachinskiy

Antonis Ryakiotakis commented

2014-11-20 13:18:56 +01:00

Added subscribers: @ZhangYu, @ThomasDinges

filip mond commented

2015-03-04 21:20:25 +01:00

Added subscriber: @FilipMond

filip mond commented

2015-03-04 21:20:25 +01:00

This comment was removed by @FilipMond

*This comment was removed by @FilipMond*

Campbell Barton commented

2015-03-05 00:39:25 +01:00

@FilipMond, please only add useful information in posts.

Campbell Barton commented

2015-03-09 07:39:59 +01:00

Setting as TODO because this is an error in the way the RNA attribute works and its not some mistake to correct, The rna code has to work differently to support this for Python and the UI.

http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/UserInterface#UI_Widgets

Setting as TODO because this is an error in the way the RNA attribute works and its not some mistake to correct, The rna code has to work differently to support this for Python and the UI. http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/UserInterface#UI_Widgets

Carlo Andreacchio commented

2015-03-18 00:58:51 +01:00

Removed subscriber: @candreacchio

Julian Eisel commented

2015-04-10 16:01:44 +02:00

Added subscriber: @AdamPreisler

Julian Eisel commented

2015-09-05 17:21:22 +02:00

Added subscriber: @Traverso

Seth L. commented

2015-10-21 10:11:06 +02:00

Added subscriber: @quantumanomaly

Bastien Montagne commented

2016-03-28 14:53:47 +02:00

Added subscriber: @YegorSmirnov

Chris Offner commented

2016-03-28 15:46:25 +02:00

Added subscriber: @chrisoffner3d

Campbell Barton removed their assignment 2016-08-11 06:35:00 +02:00

Julian Eisel commented

2016-10-12 12:30:55 +02:00

Added subscriber: @GeorgesDahdouh

Dalai Felinto commented

2016-11-16 11:36:04 +01:00

Closed as duplicate of #50043

Dalai Felinto closed this issue

2016-11-16 11:36:04 +01:00

Dalai Felinto commented

2016-11-16 11:40:40 +01:00

Changed status from 'Duplicate' to: 'Open'

Dalai Felinto reopened this issue

2016-11-16 11:40:40 +01:00

Dalai Felinto commented

2016-11-16 11:40:40 +01:00

Sorry, merged them the wrong way.

Dalai Felinto commented

2016-11-16 11:40:58 +01:00

Added subscriber: @Leroy-Xie

Philipp Oeser commented

2018-05-28 15:22:39 +02:00

Added subscribers: @Baeronius, @lichtwerk

Philipp Oeser commented

2019-05-14 09:56:42 +02:00

Added subscriber: @infrabread

Martin Capitanio commented

2019-09-05 22:29:31 +02:00

Added subscriber: @capnm

Martin Capitanio commented

2019-09-05 22:29:31 +02:00

If you drag over all 3, only X and Z change, Y remains unchanged. As mouse button is released, the first selected property will reset, only the last hovered is kept (and scale changed)

Update (ca58936f2f)
Works in the sidebar for some time, but is now broken in the object properties widget clone created in D5577.

> If you drag over all 3, only X and Z change, Y remains unchanged. As mouse button is released, the first selected property will reset, only the last hovered is kept (and scale changed) Update (ca58936f2f) Works in the sidebar for some time, but is now broken in the object properties widget clone created in [D5577](https://archive.blender.org/developer/D5577).

filip mond commented

2020-06-26 17:58:06 +02:00

Works in a glance under OSX, at least from 2.81a

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Multi-Button Drag: not working properly for Object Dimensions #38587