Blender Internal: Render tiles do not appear until render is finished if Save Buffers enabled #39029

Closed
opened 9 years ago by ZauberParacelsus · 19 comments

System Information
64bit Linux Mint 16
Linux Kernel 3.11.0
nVidia GTX 650 Ti, driver 319.32

Blender Version
Broken: 2.70 Release Candidate 1
Worked: 2.69.0 r60991

Short description of error
When you Render a scene, the rendering tiles appear completely blank and remain so until the entire image is rendered. This only occurs if the "Save Buffers"

Exact steps for others to reproduce the error

  1. Create a scene
  2. Enable the "Save Buffers" setting under Performance.
  3. Render
**System Information** 64bit Linux Mint 16 Linux Kernel 3.11.0 nVidia GTX 650 Ti, driver 319.32 **Blender Version** Broken: 2.70 Release Candidate 1 Worked: 2.69.0 r60991 **Short description of error** When you Render a scene, the rendering tiles appear completely blank and remain so until the entire image is rendered. This only occurs if the "Save Buffers" **Exact steps for others to reproduce the error** 1) Create a scene 2) Enable the "Save Buffers" setting under Performance. 3) Render
Poster

Changed status to: 'Open'

Changed status to: 'Open'
Poster

Added subscriber: @ZauberParacelsus

Added subscriber: @ZauberParacelsus

Added subscriber: @joel.godin

Added subscriber: @joel.godin

Not seeing that on OSX 10.9.2

Not seeing that on OSX 10.9.2
Poster

Apparently I submitted before I was finished writing. The last sentence should read "This only occurs if the Save Buffers setting is enabled, under the Performance section of the Render tab."

Apparently I submitted before I was finished writing. The last sentence should read "This only occurs if the Save Buffers setting is enabled, under the Performance section of the Render tab."
Owner

Added subscriber: @ThomasDinges

Added subscriber: @ThomasDinges
Owner

Does not happen with Cycles, only Blender Internal.

Confirmed on Windows 7 x64, with latest master.

Does not happen with Cycles, only Blender Internal. Confirmed on Windows 7 x64, with latest master.
brecht was assigned by mont29 9 years ago
mont29 commented 9 years ago
Owner

Added subscriber: @mont29

Added subscriber: @mont29
mont29 commented 9 years ago
Owner

@ThomasDinges Even though it is present in Cycles UI, afaict Cycles completely ignores it, so I guess it could be removed from here?

Regarding BI, imho it’s not a bug - current code writes tiles into temp EXR files, and re-read it once render is finished, to display it in Blender. Reading EXR files after every tile is down could be done I guess, but not easily, and would kinda break the main purpose of this option (as we would have to keep one layer in memory during whole render). Assigning to Brecht anyway, to get its advice here!

@ThomasDinges Even though it is present in Cycles UI, afaict Cycles completely ignores it, so I guess it could be removed from here? Regarding BI, imho it’s not a bug - current code writes tiles into temp EXR files, and re-read it once render is finished, to display it in Blender. Reading EXR files after every tile is down could be done I guess, but not easily, and would kinda break the main purpose of this option (as we would have to keep one layer in memory during whole render). Assigning to Brecht anyway, to get its advice here!
brecht commented 9 years ago
Owner

Save buffers works for Cycles. If I had to guess then I think this is related to color management. It should be possible to have this preview work for BI too.

Save buffers works for Cycles. If I had to guess then I think this is related to color management. It should be possible to have this preview work for BI too.
brecht removed their assignment 9 years ago
Poster

@mont29: It is an undesirable behavior that did not occur prior to 2.70. So it is not only a bug, it is also a regression.

@mont29: It is an undesirable behavior that did not occur prior to 2.70. So it is not only a bug, it is also a regression.
mont29 self-assigned this 9 years ago
mont29 commented 9 years ago
Owner

Uh… well, then, the least I can do is fix it :/

Uh… well, then, the least I can do is fix it :/
Poster

@mont29: Sorry if I came down a little hard. Due to previous bad experiences in life, I get agitated whenever I feel like something I've said was ignored. So, my apologies.

@mont29: Sorry if I came down a little hard. Due to previous bad experiences in life, I get agitated whenever I feel like something I've said was ignored. So, my apologies.
mont29 commented 9 years ago
Owner

Added subscriber: @Sergey

Added subscriber: @Sergey
mont29 commented 9 years ago
Owner

Gah… spent hours on this one, for a rather poor result… :/ So far:

  • Issue appeared in c5d7ea091 (but I do not see what’s the culprit it in this commit).
  • Issue is caused by temp renderresults used to generate preview (in e.g. RE_AcquireResultImage()) having neither rectf nor rect32 buffer, when using SaveBuffer.
  • When saving renderlayers in EXR instead of mem, code seems to allocate a dedicated buffer (in render_result_new(), rl->display_buffer), but never use it anywhere, as far as I can tell?

@Sergey, I think (hope!) you know/understand this stuff better than me, maybe it wouldn't be that hard for you to find a solution (or at least, understand what went wrong)?

Gah… spent hours on this one, for a rather poor result… :/ So far: * Issue appeared in c5d7ea091 (but I do not see what’s the culprit it in this commit). * Issue is caused by temp renderresults used to generate preview (in e.g. `RE_AcquireResultImage()`) having neither `rectf` nor `rect32` buffer, when using SaveBuffer. * When saving renderlayers in EXR instead of mem, code seems to allocate a dedicated buffer (in `render_result_new()`, `rl->display_buffer`), but never use it anywhere, as far as I can tell? @Sergey, I think (hope!) you know/understand this stuff better than me, maybe it wouldn't be that hard for you to find a solution (or at least, understand what went wrong)?
Collaborator

This issue was referenced by blender/blender-addons-contrib@89c793f70f

This issue was referenced by blender/blender-addons-contrib@89c793f70f2cc65c7ae2a903a8b747a3fb799f38
Collaborator

This issue was referenced by 89c793f70f

This issue was referenced by 89c793f70f2cc65c7ae2a903a8b747a3fb799f38
Sergey commented 9 years ago
Owner

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sergey closed this issue 9 years ago
Sergey commented 9 years ago
Owner

Closed by commit 89c793f70f.

Closed by commit 89c793f70f.
Sign in to join this conversation.
No Label
Interest/Alembic
Interest/Animation & Rigging
Interest/Asset Browser
Interest/Asset Browser Project Overview
Interest/Audio
Interest/Automated Testing
Interest/Blender Asset Bundle
Interest/Collada
Interest/Compositing
Interest/Core
Interest/Cycles
Interest/Dependency Graph
Interest/Development Management
Interest/Eevee & Viewport
Interest/Freestyle
Interest/Geometry Nodes
Interest/Grease Pencil
Interest/ID Management
Interest/Images & Movies
Interest/Import/Export
Interest/Line Art
Interest/Masking
Interest/Modeling
Interest/Modifiers
Interest/Motion Tracking
Interest/Nodes & Physics
Interest/Overrides
Interest/Performance
Interest/Performance
Interest/Physics
Interest/Pipeline, Assets & I/O
Interest/Platforms, Builds, Tests & Devices
Interest/Python API
Interest/Render & Cycles
Interest/Render Pipeline
Interest/Sculpt, Paint & Texture
Interest/Text Editor
Interest/Translations
Interest/Triaging
Interest/Undo
Interest/USD
Interest/User Interface
Interest/UV Editing
Interest/VFX & Video
Interest/Video Sequencer
Interest/Virtual Reality
legacy module/Animation & Rigging
legacy module/Core
legacy module/Eevee & Viewport
legacy module/Grease Pencil
legacy module/Modeling
legacy module/Nodes & Physics
legacy module/Pipeline, Assets & IO
legacy module/Platforms, Builds, Tests & Devices
legacy module/Python API
legacy module/Sculpt, Paint & Texture
legacy module/User Interface
legacy module/VFX & Video
legacy project/BF Blender: 2.8
legacy project/Milestone 1: Basic, Local Asset Browser
legacy project/OpenGL Error
legacy project/Retrospective
Meta/Good First Issue
Meta/Papercut
migration/requires-manual-verification
Module › Animation & Rigging
Module › Core
Module › Development Management
Module › Eevee & Viewport
Module › Grease Pencil
Module › Modeling
Module › Nodes & Physics
Module › Pipeline, Assets & IO
Module › Platforms, Builds, Tests & Devices
Module › Python API
Module › Render & Cycles
Module › Sculpt, Paint & Texture
Module › Triaging
Module › User Interface
Module › VFX & Video
Platform/FreeBSD
Platform/Linux
Platform/macOS
Platform/Windows
Priority › High
Priority › Low
Priority › Normal
Priority › Unbreak Now!
Status › Archived
Status › Confirmed
Status › Duplicate
Status › Needs Information from Developers
Status › Needs Information from User
Status › Needs Triage
Status › Resolved
Type › Bug
Type › Design
Type › Known Issue
Type › Patch
Type › Report
Type › To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#39029
Loading…
There is no content yet.