After cancelling moving bones with X-Mirror, the mirror-bones have new location. #40991

Closed
opened 9 years ago by MarioSottile · 26 comments
  • Open the file
  • Move the bones.
  • Cancel with Esc or Righ-click.

The bones in right, now, have the new location.

55-bones-x-mirror.blend

- Open the file - Move the bones. - Cancel with Esc or Righ-click. The bones in right, now, have the new location. [55-bones-x-mirror.blend](https://archive.blender.org/developer/F97085/55-bones-x-mirror.blend)
Poster

Changed status to: 'Open'

Changed status to: 'Open'
Poster

Added subscriber: @MarioSottile

Added subscriber: @MarioSottile
Psy-Fi commented 9 years ago
Collaborator

Added subscriber: @Psy-Fi

Added subscriber: @Psy-Fi
Psy-Fi commented 9 years ago
Collaborator

I can see this on 2af99b7

I can see this on 2af99b7
Psy-Fi self-assigned this 9 years ago
Collaborator

This issue was referenced by b617d6d5e6

This issue was referenced by b617d6d5e6604cb259740e486bf1ac6c07cf42d9
Psy-Fi commented 9 years ago
Collaborator

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Psy-Fi closed this issue 9 years ago
Psy-Fi commented 9 years ago
Collaborator

Closed by commit b617d6d5e6.

Closed by commit b617d6d5e6.
zanqdo commented 9 years ago
Collaborator

Added subscriber: @zanqdo

Added subscriber: @zanqdo
zanqdo commented 9 years ago
Collaborator

I prefer the old behavior better, used to rely on it to mirror selections of bones without the fear of introducing changes to the selected bones. IMO this is a regression

I prefer the old behavior better, used to rely on it to mirror selections of bones without the fear of introducing changes to the selected bones. IMO this is a regression

Added subscriber: @BassamKurdali

Added subscriber: @BassamKurdali

yeah same here, I used to depend on the old behavior; works similar if you do enter instead of esc but with esc you know you didn't change anything.

yeah same here, I used to depend on the old behavior; works similar if you do enter instead of esc but with esc you *know* you didn't change anything.

Added subscriber: @jpbouza-4

Added subscriber: @jpbouza-4

Yep, old behavior was better and I relied on it too. -1 for mariomey, I will take care of him when I see him in some conference....

Yep, old behavior was better and I relied on it too. -1 for mariomey, I will take care of him when I see him in some conference....
Psy-Fi commented 9 years ago
Collaborator

Transform, 0, enter does the same, while it was impossible to restore the positions with old behaviour. This sounds to me like a convenient bug rather than a feature.

Maybe make it an option? :p

http://xkcd.com/1172/

Transform, 0, enter does the same, while it was impossible to restore the positions with old behaviour. This sounds to me like a convenient bug rather than a feature. Maybe make it an option? :p http://xkcd.com/1172/
Poster

Well, I reported this bug because its similarity to this one: https://developer.blender.org/T40548

I used to use this "convenient bug", too... but, some days ago, I moved some non-mirrored bones and this bug broke my armature. It doesn't matter that armature, I just think it is a bug...

Well, the new way to make the armature mirrored without change the selected bones is by pressing G and Return, quickly. It's just practice... :P

Well, I reported this bug because its similarity to this one: https://developer.blender.org/T40548 I used to use this "convenient bug", too... but, some days ago, I moved some non-mirrored bones and this bug broke my armature. It doesn't matter that armature, I just think it is a bug... Well, the new way to make the armature mirrored without change the selected bones is by pressing G and Return, quickly. It's just practice... :P
zanqdo commented 9 years ago
Collaborator

@Psy-Fi Transform 0 does NOT work. Try it, move the bone a bit, hit 0, Enter.

I'm not sure it was a bug to begin with, Esc is not the same as Undo, it just cancels current operator. IMO The mirror effect should still be applied.

@Psy-Fi Transform 0 does NOT work. Try it, move the bone a bit, hit 0, Enter. I'm not sure it was a bug to begin with, Esc is not the same as Undo, it just cancels current operator. IMO The mirror effect should still be applied.
Sergey commented 9 years ago
Owner

Changed status from 'Resolved' to: 'Open'

Changed status from 'Resolved' to: 'Open'
Sergey reopened this issue 9 years ago
Sergey commented 9 years ago
Owner

Added subscriber: @Sergey

Added subscriber: @Sergey
Sergey commented 9 years ago
Owner

@Psy-Fi, re-opening so it doesn't get lost. Mind having a closer look on what's zan and slick reports? Thanks!

@Psy-Fi, re-opening so it doesn't get lost. Mind having a closer look on what's zan and slick reports? Thanks!

TBH I'm on the fence here. I understand the abstract 'least surprise' argument for this bug. However, it was nice having such a quick simple way to mirror things. I don't think the 'destroyed my rig' argument is quite appropriate, since undo works?

destructive changes to Non-mirrored mirrored bones* with the X-mirror option on (does this make sense?)
however:

  • you might want to move the non mirrored mirrored bone on one side (here you undo and turn off xmirror), then redo if you want to.
  • undo here does work.

the case where you have an unmirrored, mirrored bone is pretty rare

however, G 0 Enter and ctrl R 0 Enter are only one extra keypress, so long as they work, and not that big a deal imo.

  • Non-mirrored mirrored bones = bones with .L and .R suffixes that are not supposed to be geometrically mirrored in the rig.
TBH I'm on the fence here. I understand the abstract 'least surprise' argument for this bug. However, it was nice having such a quick simple way to mirror things. I don't think the 'destroyed my rig' argument is quite appropriate, since undo works? destructive changes to Non-mirrored mirrored bones* with the X-mirror option on (does this make sense?) however: - you might want to move the non mirrored mirrored bone on one side (here you undo and turn off xmirror), then redo if you want to. - undo here does work. # the case where you have an unmirrored, mirrored bone is pretty rare however, G 0 Enter and ctrl R 0 Enter are only one extra keypress, so long as they work, and not that big a deal imo. * Non-mirrored mirrored bones = bones with .L and .R suffixes that are not supposed to be geometrically mirrored in the rig.
Psy-Fi commented 9 years ago
Collaborator

Hi,

Undo did not work on the original, the positions would be lost forever (try on 2.71). Transform 0 does not work indeed, you need to either grab, x, 0 or rotate 0 to make it work.

However given that you couldn't get the original back and that it's just an extra quite intuitive keypress (given blender workflow) to have a mirrored armature, I'd vote for keeping the fix.

Hi, Undo did not work on the original, the positions would be lost forever (try on 2.71). Transform 0 does not work indeed, you need to either grab, x, 0 or rotate 0 to make it work. However given that you couldn't get the original back and that it's just an extra quite intuitive keypress (given blender workflow) to have a mirrored armature, I'd vote for keeping the fix.

hmm, then I think it is acceptable to keep the fix, use R 0 Enter / ctrl R 0 enter to do the mirroring (one extra key press) and continue;
ZanQdo, JPBouza, Mariomey, what do you think?
PS since this affects usability it should also be documented as a change in release notes, not just a bug fix.

hmm, then I think it is acceptable to keep the fix, use R 0 Enter / ctrl R 0 enter to do the mirroring (one extra key press) and continue; ZanQdo, JPBouza, Mariomey, what do you think? PS since this affects usability it should also be documented as a change in release notes, not just a bug fix.
Poster

IMO I don't think that leaving this bug (*) would be good to Blender development. As I wrote before, it is similar to the other bug. What makes you think that this bug didn't "make" the other bug, using as reference the bugged code to make the new one?

G - X - 0 - Enter / R - X - 0 - Enter / Ctrl-G - X - 0 - Enter ... for mirror armature without modification.

It was my mistake to try to move non-mirrored mirrored bones with X-mirror on... and Undo did work in old behaviour... however, I think the most important thing is what I said in first line of this comment (about Blender development).

I repeat, this is my opinion. I'm not a programmer and I don't know how the people create-develop-fix code for Blender (for me, they are ET).

(*): even if someone likes this "feature", for me, it is a bug. Esc and Right-click are cancel for almost everything in Blender.

IMO I don't think that leaving this bug (*) would be good to Blender development. As I wrote before, it is similar to the other bug. What makes you think that this bug didn't "make" the other bug, using as reference the bugged code to make the new one? G - X - 0 - Enter / R - X - 0 - Enter / Ctrl-G - X - 0 - Enter ... for mirror armature without modification. It was my mistake to try to move non-mirrored mirrored bones with X-mirror on... and Undo did work in old behaviour... however, I think the most important thing is what I said in first line of this comment (about Blender development). I repeat, this is my opinion. I'm not a programmer and I don't know how the people create-develop-fix code for Blender (for me, they are ET). (*): even if someone likes this "feature", for me, it is a bug. Esc and Right-click are cancel for almost everything in Blender.

Yeah, you guys have convinced me. Sorry Zan, JPBouza, I think we should keep the fix!!

Yeah, you guys have convinced me. Sorry Zan, JPBouza, I think we should keep the fix!!

Keep the fix, I'll deal with Mariomey later :p

Keep the fix, I'll deal with Mariomey later :p
Psy-Fi commented 9 years ago
Collaborator

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Psy-Fi closed this issue 9 years ago
Sign in to join this conversation.
No Label
Interest/Alembic
Interest/Animation & Rigging
Interest/Asset Browser
Interest/Asset Browser Project Overview
Interest/Audio
Interest/Automated Testing
Interest/Blender Asset Bundle
Interest/Collada
Interest/Compositing
Interest/Core
Interest/Cycles
Interest/Dependency Graph
Interest/Development Management
Interest/Eevee & Viewport
Interest/Freestyle
Interest/Geometry Nodes
Interest/Grease Pencil
Interest/ID Management
Interest/Images & Movies
Interest/Import/Export
Interest/Line Art
Interest/Masking
Interest/Modeling
Interest/Modifiers
Interest/Motion Tracking
Interest/Nodes & Physics
Interest/Overrides
Interest/Performance
Interest/Performance
Interest/Physics
Interest/Pipeline, Assets & I/O
Interest/Platforms, Builds, Tests & Devices
Interest/Python API
Interest/Render & Cycles
Interest/Render Pipeline
Interest/Sculpt, Paint & Texture
Interest/Text Editor
Interest/Translations
Interest/Triaging
Interest/Undo
Interest/USD
Interest/User Interface
Interest/UV Editing
Interest/VFX & Video
Interest/Video Sequencer
Interest/Virtual Reality
legacy module/Animation & Rigging
legacy module/Core
legacy module/Eevee & Viewport
legacy module/Grease Pencil
legacy module/Modeling
legacy module/Nodes & Physics
legacy module/Pipeline, Assets & IO
legacy module/Platforms, Builds, Tests & Devices
legacy module/Python API
legacy module/Sculpt, Paint & Texture
legacy module/User Interface
legacy module/VFX & Video
legacy project/BF Blender: 2.8
legacy project/Milestone 1: Basic, Local Asset Browser
legacy project/OpenGL Error
legacy project/Retrospective
Meta/Good First Issue
Meta/Papercut
migration/requires-manual-verification
Module › Animation & Rigging
Module › Core
Module › Development Management
Module › Eevee & Viewport
Module › Grease Pencil
Module › Modeling
Module › Nodes & Physics
Module › Pipeline, Assets & IO
Module › Platforms, Builds, Tests & Devices
Module › Python API
Module › Render & Cycles
Module › Sculpt, Paint & Texture
Module › Triaging
Module › User Interface
Module › VFX & Video
Platform/FreeBSD
Platform/Linux
Platform/macOS
Platform/Windows
Priority › High
Priority › Low
Priority › Normal
Priority › Unbreak Now!
Status › Archived
Status › Confirmed
Status › Duplicate
Status › Needs Information from Developers
Status › Needs Information from User
Status › Needs Triage
Status › Resolved
Type › Bug
Type › Design
Type › Known Issue
Type › Patch
Type › Report
Type › To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#40991
Loading…
There is no content yet.