replace OpenGL immediate mode in Blender 2.8 #49043

New Issue

Mike Erwin · 2016-08-08T08:41:56+02:00

Mike Erwin commented

2016-08-08 08:41:56 +02:00

OpenGL 3.3 core profile does not support glBegin/glEnd/glVertex and related functions.

Replace all calls with VBOs & glDrawArrays/glDrawElements, or (preferably) with Gawain's immediate mode work-alike.

We must complete this task before switching to core profile.

The call for volunteers has more information about what needs to be done and how people can get involved.

We're tracking progress on this page , where you can browse files that need work and claim a piece of the action!

OpenGL 3.3 core profile does not support glBegin/glEnd/glVertex and related functions. Replace all calls with VBOs & glDrawArrays/glDrawElements, or (preferably) with Gawain's immediate mode work-alike. We must complete this task before switching to core profile. The [call for volunteers](https://wiki.blender.org/index.php/Dev:2.8/Source/OpenGL/ImmediateModeReplacement) has more information about what needs to be done and how people can get involved. We're tracking progress on [this page ](https://wiki.blender.org/index.php/Dev:2.8/Source/OpenGL/Immediate_Mode_Replacement_Tasks), where you can browse files that need work and claim a piece of the action!

Mike Erwin self-assigned this 2016-08-08 08:41:56 +02:00

Mike Erwin commented

2016-08-08 08:41:56 +02:00

Changed status to: 'Open'

Mike Erwin commented

2016-08-08 08:41:56 +02:00

Added subscriber: @MikeErwin

Dalai Felinto commented

2016-10-03 18:33:19 +02:00

Added subscriber: @dfelinto

Anthony Edlin commented

2016-10-04 10:26:41 +02:00

Added subscriber: @AnthonyEdlin

peter lu commented

2016-10-04 17:43:26 +02:00

Added subscriber: @pdlla

peter lu commented

2016-10-04 17:43:26 +02:00

Just read through the doc. Will new tasks be created? I'm happy to to help out here.

Mike Erwin commented

2016-10-04 18:18:25 +02:00

In #49043#395707, @pdlla wrote:
Will new tasks be created?

Just add a comment to this task saying "I'm working on funcX, funkY, funcZ. Plan to finish by DATE"

As you finish, edit the comment to cross out ~~funcX~~, ~~funkY~~, funcZ.

> In #49043#395707, @pdlla wrote: > Will new tasks be created? Just add a comment to this task saying "I'm working on funcX, funkY, funcZ. Plan to finish by DATE" As you finish, edit the comment to cross out ~~funcX~~, ~~funkY~~, funcZ.

Fable Fox commented

2016-10-05 10:13:02 +02:00

Added subscriber: @fablefox

Fable Fox commented

2016-10-05 10:13:02 +02:00

Will there a spreadsheet that list all the source code that need working, person working on it, and maybe 0,25,50,75,100% completed status for people to mark?

I think having that can be helpful and lead to easier organizing. IMHO.

Will there a spreadsheet that list all the source code that need working, person working on it, and maybe 0,25,50,75,100% completed status for people to mark? I think having that can be helpful and lead to easier organizing. IMHO.

Julian Eisel commented

2016-10-05 10:23:10 +02:00

Added subscriber: @JulianEisel

Julian Eisel commented

2016-10-05 10:23:10 +02:00

In #49043#395808, @fablefox wrote:
Will there a spreadsheet that list all the source code that need working, person working on it, and maybe 0,25,50,75,100% completed status for people to mark?

I think having that can be helpful and lead to easier organizing. IMHO.

+1, this would probably help a bit. We can also use the wiki like here .

> In #49043#395808, @fablefox wrote: > Will there a spreadsheet that list all the source code that need working, person working on it, and maybe 0,25,50,75,100% completed status for people to mark? > > I think having that can be helpful and lead to easier organizing. IMHO. +1, this would probably help a bit. We can also use the wiki like [here ](https://wiki.blender.org/index.php/Dev:2.5/Source/Architecture/RNA/Tasks#Help_Wanted).

Dalai Felinto commented

2016-10-05 13:36:09 +02:00

have a list in wiki for the listing of remaining files

I can work on that. I will post on bf-viewport when it's done (there are 56 files total for glBegin at least).

> have a list in wiki for the listing of remaining files I can work on that. I will post on bf-viewport when it's done (there are 56 files total for glBegin at least).

Mike Erwin commented

2016-10-05 16:54:09 +02:00

@dfelinto created a task page where we can track progress per file. Fancy!

Use that page to claim files (or parts of files), and this task to track commits / diffs / code review.

@dfelinto created a [task page ](https://wiki.blender.org/index.php/Dev:2.8/Source/OpenGL/Immediate_Mode_Replacement_Tasks) where we can track progress per file. Fancy! Use that page to claim files (or parts of files), and this task to track commits / diffs / code review.

Khanh Ha commented

2016-10-08 03:57:02 +02:00

Added subscriber: @KhanhHa

Willian Padovani Germano commented

2016-10-11 18:10:41 +02:00

Added subscriber: @WillianPadovaniGermano

blender-admin commented

2016-10-19 02:27:24 +02:00

This issue was referenced by 05117d71a3

This issue was referenced by 05117d71a35d69a978a5e26da185b3617333d98c

Mike Erwin commented

2016-10-20 23:08:48 +02:00

This comment was removed by @MikeErwin

*This comment was removed by @MikeErwin*

Recep Aslantas commented

2016-11-13 18:34:47 +01:00

Added subscriber: @RecepAslantas

Andrew McGuire commented

2016-11-14 04:36:11 +01:00

Added subscriber: @SonicPixelation

Andrew McGuire commented

2016-11-14 04:37:57 +01:00

Removed subscriber: @SonicPixelation

Andrew McGuire commented

2016-11-14 04:38:00 +01:00

Added subscriber: @SonicPixelation

Andrew McGuire commented

2016-11-14 04:38:03 +01:00

Removed subscriber: @SonicPixelation

Brett Rieder commented

2016-11-14 19:20:59 +01:00

Added subscriber: @brieder

Benjamin Summerton commented

2016-11-15 03:40:52 +01:00

Added subscriber: @define-private-public

Benjamin Summerton commented

2016-11-15 03:40:52 +01:00

~~Does anyone mind if I claim source/blender/editors/space_action/action_draw.c?
~~

Scratch that, I was told someone else was talking that.

~~Does anyone mind if I claim `source/blender/editors/space_action/action_draw.c`? ~~ Scratch that, I was told someone else was talking that.

Benjamin Summerton commented

2016-11-15 04:01:51 +01:00

Does view2d.c have any takers?

Does `view2d.c` have any takers?

Darwin Yip commented

2016-11-15 05:26:18 +01:00

Added subscriber: @darwin

Darwin Yip commented

2016-11-15 05:26:18 +01:00

Will take on transform.c next.

Will take on `transform.c` next.

Mike Erwin commented

2016-11-15 05:41:01 +01:00

Added subscriber: @punya

Mike Erwin commented

2016-11-15 05:41:01 +01:00

Updated our todo list for contributors @define-private-public @punya @darwin

Punya Biswal commented

2016-11-15 16:25:05 +01:00

Taking on anim_markers next: D2355

Taking on `anim_markers` next: [D2355](https://archive.blender.org/developer/D2355)

Punya Biswal commented

2016-11-16 15:40:59 +01:00

Taking on area next: D2361.

Taking on `area` next: [D2361](https://archive.blender.org/developer/D2361).

Benjamin Summerton commented

2016-11-18 21:42:15 +01:00

does editors/space_text/text_draw.c have any takers? I'd like to work on it next after I'm done with view2d.c.

does `editors/space_text/text_draw.c` have any takers? I'd like to work on it next after I'm done with `view2d.c`.

Dalai Felinto commented

2016-11-19 00:17:19 +01:00

@define-private-public according to the wiki no. So go for it!

@define-private-public according to the [wiki ](https://wiki.blender.org/index.php/Dev:2.8/Source/OpenGL/Immediate_Mode_Replacement_Tasks) no. So go for it!

Darwin Yip commented

2016-11-19 01:50:23 +01:00

While I wait for review on transform.c, I will tackle clip_utils.c

While I wait for review on `transform.c`, I will tackle `clip_utils.c`

Brett Rieder commented

2016-11-19 01:52:38 +01:00

Removed subscriber: @brieder

Benjamin Summerton commented

2016-11-19 04:57:01 +01:00

Could someone mark that on the wiki for me? I don't have an account there yet.

Ryan Reyes commented

2016-11-20 02:47:43 +01:00

Added subscriber: @ryry-1

Ryan Reyes commented

2016-11-20 02:48:07 +01:00

I'd like to help! Could I grab glutil.c?

Mike Erwin commented

2016-11-20 04:52:57 +01:00

In #49043#405376, @ryry-1 wrote:
I'd like to help! Could I grab glutil.c?

Welcome @ryry-1! Sooo many other files depend on glutil so it's not a very good place to start. Please redirect your enthusiasm to another file that uses deprecated functions from glutil.

Functions in there starting with "imm" use the new API so can help when porting code in other files.

> In #49043#405376, @ryry-1 wrote: > I'd like to help! Could I grab glutil.c? Welcome @ryry-1! Sooo many other files depend on glutil so it's not a very good place to start. Please redirect your enthusiasm to another file that *uses* deprecated functions from glutil. Functions in there starting with "imm" use the new API so can help when porting code in other files.

Ryan Reyes commented

2016-11-20 05:57:11 +01:00

Okay! I'll do mask_draw.c and try to have it done by tomorrow evening EST.

Benjamin Summerton commented

2016-11-21 02:11:27 +01:00

I'm going to start on interface_regions.c if there are no takers. I'm skipping text_draw.c for now, so if anyone else wants it. It's up for grabs,.

I'm going to start on `interface_regions.c` if there are no takers. I'm skipping `text_draw.c` for now, so if anyone else wants it. It's up for grabs,.

Fable Fox commented

2016-11-21 02:44:19 +01:00

Added subscriber: @benjamin-19

Fable Fox commented

2016-11-21 02:44:19 +01:00

@define-private-public, I've marked interface_regions.c on the wiki for you (moved from text_draw.c).

Darwin Yip commented

2016-11-21 03:01:02 +01:00

Taking on keyframes_draw.c if there are no objections.

Taking on `keyframes_draw.c` if there are no objections.

Darwin Yip commented

2016-11-21 05:45:36 +01:00

Can someone please mark clip_utils.c for me?

Can someone please mark `clip_utils.c` for me?

Benjamin Summerton commented

2016-11-24 04:37:17 +01:00

I'm going to take anim_channels_defines.c in the meantime actually. I need to talk to merwin before moving on with the other two things I said I was going to do.

I'm going to take `anim_channels_defines.c` in the meantime actually. I need to talk to merwin before moving on with the other two things I said I was going to do.

Benjamin Mizera commented

2016-12-04 11:38:12 +01:00

Added subscriber: @mizerb

Benjamin Mizera commented

2016-12-04 11:38:12 +01:00

Hello, I'll try to help. Looking at starting at text_draw.c if that's ok?

Mike Erwin commented

2016-12-04 16:23:34 +01:00

Welcome @mizerb! Go ahead with text_draw.c

Benjamin Summerton commented

2016-12-05 02:02:53 +01:00

I'm going to be working on paint_stroke.c for now.

I'm going to be working on `paint_stroke.c` for now.

Tobias Mertz commented

2016-12-20 18:36:34 +01:00

Added subscriber: @TCMBoby

Tobias Mertz commented

2016-12-21 15:03:07 +01:00

I want to help as well. Would anyone mind if I claimed clip_draw.c to start with?

Benjamin Summerton commented

2016-12-27 05:03:37 +01:00

Removed subscriber: @define-private-public

Benjamin Summerton commented

2016-12-27 05:07:55 +01:00

@MikeErwin I'd like to thank you for helping me with the few diffs that I made, but I'm going to have to sign off from helping with the blender project right now. I have some other priorities that I need to focus on right now. I'd like to come back and help sometime down the road, but I have too much on my plate right now.

I still have D2377 alive, and I'd like to get that in (if it's acceptable).

If you have any new people who are looking for some low hanging fruit to start out with, I scouted these files out:

view3d_ruler.c
transfrom_generics.c
transform_constraints.c
text_draw.c (I think it might be taken by someone else)
space_graph.c
sculpt_uv.c
screen_edit.c
paint_stroke.c

Thanks again.

@MikeErwin I'd like to thank you for helping me with the few diffs that I made, but I'm going to have to sign off from helping with the blender project right now. I have some other priorities that I need to focus on right now. I'd like to come back and help sometime down the road, but I have too much on my plate right now. I still have [D2377](https://archive.blender.org/developer/D2377) alive, and I'd like to get that in (if it's acceptable). If you have any new people who are looking for some low hanging fruit to start out with, I scouted these files out: - view3d_ruler.c - transfrom_generics.c - transform_constraints.c - text_draw.c (I think it might be taken by someone else) - space_graph.c - sculpt_uv.c - screen_edit.c - paint_stroke.c Thanks again.

Benjamin Summerton commented

2016-12-27 05:08:04 +01:00

Added subscriber: @define-private-public

Mike Erwin commented

2016-12-27 06:58:00 +01:00

Thank you @define-private-public for your code & for helping other people get started. Welcome back anytime.

I'll look at D2377 again tomorrow, try to get it in.

Thank you @define-private-public for your code & for helping other people get started. Welcome back anytime. I'll look at [D2377](https://archive.blender.org/developer/D2377) again tomorrow, try to get it in.

Antonio Vazquez commented

2017-01-18 18:29:20 +01:00

Added subscriber: @antoniov

blender-admin commented

2017-01-19 06:46:01 +01:00

This issue was referenced by 8aa8165e85

This issue was referenced by 8aa8165e85d4abcf9025c687863d0c41bc41a348

Oliver Weissbarth commented

2017-02-02 09:33:29 +01:00

Added subscriber: @oweissbarth

Oliver Weissbarth commented

2017-02-02 21:18:23 +01:00

Hi i would like to help. Can i take uvedit_draw.c or should i start somewhere else?

Darwin Yip commented

2017-02-03 03:51:37 +01:00

I'm taking screen_draw.c. Thanks.

I'm taking `screen_draw.c`. Thanks.

blender-admin commented

2017-02-07 20:43:58 +01:00

This issue was referenced by a39a459a1ecbe3ab0cb772b9eae58ffc0a4d3e08

blender-admin commented

2017-02-08 05:43:17 +01:00

This issue was referenced by dbe23c5456

This issue was referenced by dbe23c5456496a179b956b545c24c311b69c1c62

Jonathan Hale commented

2017-02-10 15:54:48 +01:00

Added subscriber: @Squareys

Dalai Felinto commented

2017-02-24 10:56:06 +01:00

Added subscriber: @SebastianWitt

Dalai Felinto commented

2017-02-24 10:56:06 +01:00

@ryry-1 @punya @SebastianWitt @darwin I couldn't find your contact. But we've just sent a round of emails to get in touch with past contributors of this taskforce. The message goes as follow:

Hi there,

This is a friendly email to invite you to get back at our beloved
OpenGL TaskForce :) I understand life makes it hard some times. But in
case your distance from the development process is due to the process
itself, please do tell us. We would love to hear and address it.

Very well, we are close to one of our initial marks. That said we will
start a new stage soon. Once the immediate mode replacement is over
and the new matrix API is finished and documented. So yes, plenty of
work ahead indeed.

Anyways, thanks for your involvement in the task force. We hope you
can back on this or any future projects.

Best regards,
Dalai and Mike

If you have any question don't hesitate in contacting us directly via email, irc, or through here.

@ryry-1 @punya @SebastianWitt @darwin I couldn't find your contact. But we've just sent a round of emails to get in touch with past contributors of this taskforce. The message goes as follow: ``` Hi there, This is a friendly email to invite you to get back at our beloved OpenGL TaskForce :) I understand life makes it hard some times. But in case your distance from the development process is due to the process itself, please do tell us. We would love to hear and address it. Very well, we are close to one of our initial marks. That said we will start a new stage soon. Once the immediate mode replacement is over and the new matrix API is finished and documented. So yes, plenty of work ahead indeed. Anyways, thanks for your involvement in the task force. We hope you can back on this or any future projects. Best regards, Dalai and Mike ``` If you have any question don't hesitate in contacting us directly via email, irc, or through here.

Mike Erwin commented

2017-02-24 19:42:14 +01:00

Hey everyone, I updated the call for help wiki page with recommended coding style. It's worth another read even if you've been doing this a while, to clarify how the new API works.

We're getting closer to done!

Hey everyone, I updated the [call for help ](https://wiki.blender.org/index.php/Dev:2.8/Source/OpenGL/ImmediateModeReplacement) wiki page with recommended coding style. It's worth another read even if you've been doing this a while, to clarify how the new API works. We're getting closer to done!

Khanh Ha commented

2017-02-27 10:05:37 +01:00

Mike Erwin have told me a about the task editarmature_sketch.c, please someone mark this file in wike page for me

Erick Tukuniata commented

2017-03-15 22:55:58 +01:00

Added subscriber: @ErickNyanduKabongo

Khanh Ha commented

2017-03-16 10:25:11 +01:00

I am working on paint_cursor.c

Khanh Ha commented

2017-03-16 11:08:26 +01:00

can't work on paint_cursor.c because the line circle drawing was refactored, and circle/line drawing feature crashes while evaluating curve.
I am looking for a new file

can't work on paint_cursor.c because the line circle drawing was refactored, and circle/line drawing feature crashes while evaluating curve. I am looking for a new file

Khanh Ha commented

2017-03-16 11:08:29 +01:00

This comment was removed by @KhanhHa

*This comment was removed by @KhanhHa*

Dalai Felinto commented

2017-03-16 12:20:52 +01:00

@KhanhHa why not tackling this crash then? we will need to fix it anyways :)