Rigid body point cache jumps #50230

New Issue

Kai Kostack · 2016-12-11T11:29:27+01:00

Kai Kostack commented

2016-12-11 11:29:27 +01:00

We noticed some unclean behaviour when working with rigid bodies, which leads to bad simulation results. When scrubbing through the timeline the last simulation state is being used for later continuation of the "main" simulation, which doesn't always work as shown in the following example.

Steps to reproduce based on the attached blend file:

Start simulation (Alt+a)
Stop simulation (Alt+a)
Jump to a future point in the timeline and simulate a bit further and stop again
Jump back to start range and continue the already cached simulation (or press Bake)

Resulting simulation with motion path and frame numbers:

rigid-body-cache-jump.blend

Tested on Windows 7 x64 with the official buildbot version.

We noticed some unclean behaviour when working with rigid bodies, which leads to bad simulation results. When scrubbing through the timeline the last simulation state is being used for later continuation of the "main" simulation, which doesn't always work as shown in the following example. Steps to reproduce based on the attached blend file: ![rigid-body-cache-jump.png](https://archive.blender.org/developer/F416619/rigid-body-cache-jump.png) 1. Start simulation (Alt+a) 2. Stop simulation (Alt+a) 3. Jump to a future point in the timeline and simulate a bit further and stop again 4. Jump back to start range and continue the already cached simulation (or press Bake) Resulting simulation with motion path and frame numbers: ![rigid-body-cache-jump2.png](https://archive.blender.org/developer/F416621/rigid-body-cache-jump2.png) [rigid-body-cache-jump.blend](https://archive.blender.org/developer/F416626/rigid-body-cache-jump.blend) Tested on Windows 7 x64 with the official buildbot version.

Kai Kostack commented

2016-12-11 11:29:27 +01:00

Changed status to: 'Open'

Kai Kostack commented

2016-12-11 11:29:27 +01:00

Added subscriber: @KaiKostack-3

Luca Rood commented

2017-01-08 04:54:20 +01:00

Added subscriber: @LucaRood-3

Luca Rood commented

2017-01-08 04:54:20 +01:00

Changed status from 'Open' to: 'Archived'

Luca Rood closed this issue

2017-01-08 04:54:20 +01:00

Luca Rood self-assigned this 2017-01-08 04:54:20 +01:00

Luca Rood commented

2017-01-08 04:54:20 +01:00

I finally had some time to look into this...

The issue is that the rigid body simulation state isn't updated when read from cache. But the greater issue is that rigid body cache is currently only storing positions and rotations, so even if the simulation state is updated from the cache, we can only update the positions/rotations, and not the velocities.

This little diff calls a simulation state update when the cache is read, and thus correctly sets the position even when the timeline is set back to the initial cached bit after having jumped a few frames... But notice that the speed is reset to 0, so despite being in the correct location, you'll see your objects suddenly stopping, and re-accelerating.

P435: Rigid body cache update

diff --git a/source/blender/blenkernel/intern/rigidbody.c b/source/blender/blenkernel/intern/rigidbody.c
index b5f34a2..447f459 100644
--- a/source/blender/blenkernel/intern/rigidbody.c
+++ b/source/blender/blenkernel/intern/rigidbody.c
@@ -1583,6 +1583,7 @@ void BKE_rigidbody_do_simulation(Scene *scene, float ctime)
 	bool can_simulate = (ctime == rbw->ltime + 1) && !(cache->flag & PTCACHE_BAKED);
 
 	if (BKE_ptcache_read(&pid, ctime, can_simulate)) {
+		rigidbody_update_simulation(scene, rbw, true);
 		BKE_ptcache_validate(cache, (int)ctime);
 		rbw->ltime = ctime;
 		return;

So this diff is only really a demonstration, and doesn't really fix the issue at all. To resolve this, the velocities would have to be cached as well, which isn't really worth the trouble for now, especially with this outdated caching system...

So I'm closing this for the time being... But I have added this to ToDo, and this shall probably be addressed with an eventual cache overhaul (provided it is even possible to get/set the velocities from Bullet...).
https://wiki.blender.org/index.php/Dev:Source/Development/Todo/Tools#Rigid_Body

I finally had some time to look into this... The issue is that the rigid body simulation state isn't updated when read from cache. But the greater issue is that rigid body cache is currently only storing positions and rotations, so even if the simulation state is updated from the cache, we can only update the positions/rotations, and not the velocities. This little diff calls a simulation state update when the cache is read, and thus correctly sets the position even when the timeline is set back to the initial cached bit after having jumped a few frames... But notice that the speed is reset to 0, so despite being in the correct location, you'll see your objects suddenly stopping, and re-accelerating. [P435: Rigid body cache update](https://archive.blender.org/developer/P435.txt) ``` diff --git a/source/blender/blenkernel/intern/rigidbody.c b/source/blender/blenkernel/intern/rigidbody.c index b5f34a2..447f459 100644 --- a/source/blender/blenkernel/intern/rigidbody.c +++ b/source/blender/blenkernel/intern/rigidbody.c @@ -1583,6 +1583,7 @@ void BKE_rigidbody_do_simulation(Scene *scene, float ctime) bool can_simulate = (ctime == rbw->ltime + 1) && !(cache->flag & PTCACHE_BAKED); if (BKE_ptcache_read(&pid, ctime, can_simulate)) { + rigidbody_update_simulation(scene, rbw, true); BKE_ptcache_validate(cache, (int)ctime); rbw->ltime = ctime; return; ``` So this diff is only really a demonstration, and doesn't really fix the issue at all. To resolve this, the velocities would have to be cached as well, which isn't really worth the trouble for now, especially with this outdated caching system... So I'm closing this for the time being... But I have added this to ToDo, and this shall probably be addressed with an eventual cache overhaul (provided it is even possible to get/set the velocities from Bullet...). https://wiki.blender.org/index.php/Dev:Source/Development/Todo/Tools#Rigid_Body

Luca Rood commented

2017-01-10 06:09:34 +01:00

Changed status from 'Archived' to: 'Open'

Luca Rood reopened this issue

2017-01-10 06:09:34 +01:00

Luca Rood commented

2017-01-10 06:09:34 +01:00

I'm reopening this, because I realized that I shouldn't try to fix it by having everything cached and then rolling back once you go to to a point in time before a cache gap. Having a simulation with a time gap in it doesn't actually make any sense at all, so I realized that I should rather prevent the cache from forming such a gap in the first place.

That is a trivial fix, and should prevent accidental rigid body cache corruption by the user if playing outside of the currently cached period.

I'm reopening this, because I realized that I shouldn't try to fix it by having everything cached and then rolling back once you go to to a point in time before a cache gap. Having a simulation with a time gap in it doesn't actually make any sense at all, so I realized that I should rather prevent the cache from forming such a gap in the first place. That is a trivial fix, and should prevent accidental rigid body cache corruption by the user if playing outside of the currently cached period.

blender-admin commented

2017-06-30 15:56:44 +02:00

This issue was referenced by 9cd6b03187

This issue was referenced by 9cd6b03187b91bb2c267a45eac3cee7738e0e220

Luca Rood commented

2017-06-30 16:02:34 +02:00

Changed status from 'Open' to: 'Resolved'

Luca Rood closed this issue

2017-06-30 16:02:34 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Rigid body point cache jumps #50230