gawain doesn't build with MSVC #51740
inline is not defined in MSVC:
We should use __inline in those cases, with a conditional ifdef for linux/win. We have this in Blender itself, but we can't bring GPL code into Mozilla, so gawain gotta decide how to best address this.
(It fails in shader_interface.c)
this doesn't look like a function that will be called enough to justify the inline? so short term i suggest just removing the keyword so things get building again, for future things you might want to inline just toss a
- ifdef _MSV_VER - define inline __inline #endif
^^^ live typed in this ticket, no license issues
in a generic gawain headers somewhere
I agree with @LazyDodo about removing "inline". Simplest solution & I've found static private functions to be as effective as inline. If we ever need public inline functions we can define this in gawain/common.h
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?