Multi-Object-Mode: Edit MetaBall Tools #54649

New Issue

Campbell Barton · 2018-04-16T12:58:23+02:00

Campbell Barton commented

2018-04-16 12:58:23 +02:00

~~MBALL_OT_select_all~~ 0a893c0901
~~MBALL_OT_select_random_metaelems~~ f897d95372
~~MBALL_OT_select_similar~~ 5f8d369495

~~Note: Selection pick is not working either.~~

~~MBALL_OT_delete_metaelems~~ 6bee49eca4
~~MBALL_OT_duplicate_metaelems~~ 046ec863ff

## Select Menu: - ~~MBALL_OT_select_all~~ 0a893c0901 - ~~MBALL_OT_select_random_metaelems~~ f897d95372 - ~~MBALL_OT_select_similar~~ 5f8d369495 ~~Note: Selection pick is not working either.~~ ## MetaBall Menu: - ~~MBALL_OT_delete_metaelems~~ 6bee49eca4 - ~~MBALL_OT_duplicate_metaelems~~ 046ec863ff

Campbell Barton self-assigned this 2018-04-16 12:58:23 +02:00

Campbell Barton commented

2018-04-16 12:58:23 +02:00

Added subscriber: @ideasman42

Nick Milios commented

2018-05-10 18:04:28 +02:00

Added subscriber: @semaphore

Nick Milios commented

2018-05-10 18:04:28 +02:00

Done all the above.

The right click select is not working
i tried chanege

ED_mball_select_pick

like

EDBM_select_pick, ED_armature_edit_select_pick, ED_lattice_select_pick, ED_curve_editfont_select_pick

but i failed.

Also the following functions uses old code.

hide_metaelems_exec
reveal_metaelems_exec

Done all the above. The right click select is not working i tried chanege ``` ED_mball_select_pick ``` like > EDBM_select_pick, ED_armature_edit_select_pick, ED_lattice_select_pick, ED_curve_editfont_select_pick but i failed. Also the following functions uses old code. ``` hide_metaelems_exec reveal_metaelems_exec ```

Dalai Felinto commented

2018-05-11 12:52:12 +02:00

Added subscriber: @dfelinto

Dalai Felinto commented

2018-05-11 12:52:12 +02:00

@semaphore

The patches overall are fine, but we need to skip the for loop when there is no selected elements. There is no equivalent of totvertsel/edge/face in metaballs. You need to add this (as its own patch), so we can proceed with the other patches? It should be straight forward.

The right click select may be a different issue, but let's focus on the other operators first?

@semaphore The patches overall are fine, but we need to skip the for loop when there is no selected elements. There is no equivalent of `totvertsel`/edge/face in metaballs. You need to add this (as its own patch), so we can proceed with the other patches? It should be straight forward. The right click select may be a different issue, but let's focus on the other operators first?

Nick Milios commented

2018-05-11 17:15:49 +02:00

@dfelinto

In MetaBall there is a double list mb->editelems of nodes type MetaElem and foreach of them a bitmask flag for ml->flag in first bit to check if it is selected..

To be clear...

Do you want me to edit struct MetaBall and add an int totelemsel?
Find all references functions that changes totvertsel and change all respective functions on mball to change the new totelemsel accordingly?
Then submit it as a pach and then re submit all aabove paches to check it?

@dfelinto In MetaBall there is a double list mb->editelems of nodes type MetaElem and foreach of them a bitmask flag for ml->flag in first bit to check if it is selected.. To be clear... Do you want me to edit struct MetaBall and add an int totelemsel? Find all references functions that changes totvertsel and change all respective functions on mball to change the new totelemsel accordingly? Then submit it as a pach and then re submit all aabove paches to check it?

Dalai Felinto commented

2018-05-13 13:11:10 +02:00

@semaphore that's what I meant yes, but Campbell just implemented BKE_mball_is_any_selected and BKE_mball_is_any_unselected, so you are good to update them (not re-submit as new patches, but update the existent ones).

@semaphore that's what I meant yes, but Campbell just implemented `BKE_mball_is_any_selected` and `BKE_mball_is_any_unselected`, so you are good to update them (not re-submit as new patches, but update the existent ones).

Philippe Schmid commented

2018-05-28 15:42:27 +02:00

Added subscriber: @Quetzal

Philippe Schmid commented

2018-05-28 15:42:27 +02:00

I made a differential two weeks ago for MBALL_OT_select_all, but just realized that it didn't get linked back to the parent task, so if it's still current, there it is: D3347 .

hmm... I mentioned the wrong task, that's why.

I made a differential two weeks ago for `MBALL_OT_select_all`, but just realized that it didn't get linked back to the parent task, so if it's still current, there it is: [D3347](https://archive.blender.org/developer/D3347) . hmm... I mentioned the wrong task, that's why.

Dalai Felinto commented

2018-11-07 03:20:02 +01:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2018-11-07 03:20:02 +01:00

Dalai Felinto commented

2018-11-07 03:20:02 +01:00

I will address the selection issues and bugs separately. But overall as far as the main multi-objects operators is concerned, this is done.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Multi-Object-Mode: Edit MetaBall Tools #54649

Select Menu:

MetaBall Menu: