Stabilize boolean's epsilon use, write tests #56160

New Issue

Campbell Barton · 2018-07-31T03:52:36+02:00

Campbell Barton commented

2018-07-31 03:52:36 +02:00

Motivation: resolve bugs in boolean code.

Description:

Currently booleans use epsilon comparisons in a non-uniform way,
causing near edge-cases for fall in-between detecting a segment and an end-point intersection.

This would resolve some of the open bug reports we have now.

Estimated Time: 2 weeks

1 week writing tests, make sure existing bug reports are covered by these tests.

This is very important since currently there aren't any good ways to know if a change to boolean code breaks edge cases.
1 week (max) to go over current boolean code and make all comparisons uniform

(may be a day or two as well, just needs to be done carefully, possibly re-working intersection code)

**Motivation:** resolve bugs in boolean code. **Description:** Currently booleans use epsilon comparisons in a non-uniform way, causing near edge-cases for fall *in-between* detecting a segment and an end-point intersection. This would resolve some of the open bug reports we have now. **Estimated Time:** 2 weeks - 1 week writing tests, make sure existing bug reports are covered by these tests. *This is very important since currently there aren't any good ways to know if a change to boolean code breaks edge cases.* - 1 week (max) to go over current boolean code and make all comparisons uniform *(may be a day or two as well, just needs to be done carefully, possibly re-working intersection code)* ```

Campbell Barton self-assigned this 2018-07-31 03:52:36 +02:00

Campbell Barton commented

2018-07-31 03:52:36 +02:00

Added subscribers: @ideasman42, @dfelinto, @mont29, @Sergey, @brecht

Habib Gahbiche commented

2020-03-22 14:29:05 +01:00

Added subscriber: @zazizizou

Akshat Dixit (:baka) commented

2021-04-08 21:21:15 +02:00

Added subscriber: @baka

Akshat Dixit (:baka) commented

2021-04-08 21:21:15 +02:00

I would like to work on this issue...I just need a little information, what can I do to explore and understand the issue!

Edit: I found out about what booleans are in the blender. I know and understand testing works in the blender, I would like some pre-information.

What kind of tests are expected ('Edge cases')?
What way should I implement them(make a new test file for booleans in test/ directory with a new blend file or add something to an existing one )?

I would like to work on this issue...I just need a little information, what can I do to explore and understand the issue! Edit: I found out about what booleans are in the blender. I know and understand testing works in the blender, I would like some pre-information. - What kind of tests are expected ('Edge cases')? - What way should I implement them(make a new test file for booleans in test/ directory with a new blend file or add something to an existing one )?

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Stabilize boolean's epsilon use, write tests #56160