Sequencer cut loses animation data for the right strip #60194

New Issue

Guillaume M · 2019-01-05T11:25:48+01:00

Guillaume M commented

2019-01-05 11:25:48 +01:00

System Information
Operating system: Ubuntu 18.04.1 LTS

Blender Version
Broken: Latest master branch commit : 95736683a9

When cutting a strip using the VSE (this affects all types of strips), the animation data is duplicated in the resulting right-hand strip, but is not copied to the left-hand strip.

Exact steps for others to reproduce the error
Open the VSE, add a sound strip. Animate the "volume" property using two keyframes.
Open the Graph editor, visualize the "Volume" F-curve.
Soft-cut the sound strip, and examine the F-curves for the two resulting strips :

The left strip has no animation data
The right strip has TWO identical "Volume" F-curves

Possibly linked to the following code tag :
blenkernel/intern/sequencer.c:5448 (95736683a9)

static Sequence *seq_dupli(const Scene *scene_src, Scene *scene_dst, Sequence *seq, int dupe_flag, const int flag)
{
        Sequence *seqn = MEM_dupallocN(seq);

        seq->tmp = seqn;
        seqn->strip = MEM_dupallocN(seq->strip);

        seqn->stereo3d_format = MEM_dupallocN(seq->stereo3d_format);

        /* XXX: add F-Curve duplication stuff? */

**System Information** Operating system: Ubuntu 18.04.1 LTS **Blender Version** Broken: Latest master branch commit : 95736683a96d33a8a7220788502250fa9e109132 When cutting a strip using the VSE (this affects all types of strips), the animation data is duplicated in the resulting right-hand strip, but is not copied to the left-hand strip. **Exact steps for others to reproduce the error** Open the VSE, add a sound strip. Animate the "volume" property using two keyframes. Open the Graph editor, visualize the "Volume" F-curve. Soft-cut the sound strip, and examine the F-curves for the two resulting strips : - The left strip has no animation data - The right strip has TWO identical "Volume" F-curves Possibly linked to the following code tag : blenkernel/intern/sequencer.c:5448 (95736683a96d33a8a7220788502250fa9e109132) ``` static Sequence *seq_dupli(const Scene *scene_src, Scene *scene_dst, Sequence *seq, int dupe_flag, const int flag) { Sequence *seqn = MEM_dupallocN(seq); seq->tmp = seqn; seqn->strip = MEM_dupallocN(seq->strip); seqn->stereo3d_format = MEM_dupallocN(seq->stereo3d_format); /* XXX: add F-Curve duplication stuff? */ ```

Guillaume M commented

2019-01-05 11:25:48 +01:00

Added subscriber: @mathers

blender-admin commented

2019-01-05 11:25:48 +01:00

#60370 was marked as duplicate of this issue

Guillaume M commented

2019-01-05 12:28:27 +01:00

Hi,
After investigation, I believe I can submit a patch that solves this issue. Please let me know what you think and how much testing this requires
patch_T60194.patch

Hi, After investigation, I believe I can submit a patch that solves this issue. Please let me know what you think and how much testing this requires [patch_T60194.patch](https://archive.blender.org/developer/F6184336/patch_T60194.patch)

ChristopherAnderssarian commented

2019-01-06 11:30:44 +01:00

Added subscriber: @ChristopherAnderssarian

ChristopherAnderssarian commented

2019-01-06 11:30:44 +01:00

Mind adding the #video_sequencer tag?

CC @iss

Mind adding the #video_sequencer tag? CC @iss

ChristopherAnderssarian commented

2019-01-06 11:48:54 +01:00

Added subscriber: @iss

Richard Antalik self-assigned this 2019-01-09 00:19:56 +01:00

Richard Antalik commented

2019-01-09 00:19:56 +01:00

@mathers Thanks for patch!

You can post patch for review or I can do it instead if you want.
I will look at it tomorrow.

@mathers Thanks for patch! You can post patch for review or I can do it instead if you want. I will look at it tomorrow.

Richard Antalik commented

2019-01-09 22:18:22 +01:00

Added subscriber: @mont29

Richard Antalik commented

2019-01-09 22:18:22 +01:00

I looked at this.

Your patch would undo some changes in bb98e83b99 by @mont29.

If I understood it correctly, problem was that meta strips did generate non-unique names
Not totally sure, what removal of SEQ_DUPE_UNIQUE_NAME solved, as this caused all strips to generate non-unique name.

Will try to reproduce and patch actual problem.

I looked at this. Your patch would undo some changes in bb98e83b99e63348e0396a5ffe5bb2a20ff1607a by @mont29. If I understood it correctly, problem was that meta strips did generate non-unique names Not totally sure, what removal of SEQ_DUPE_UNIQUE_NAME solved, as this caused all strips to generate non-unique name. Will try to reproduce and patch actual problem.

Guillaume M commented

2019-01-10 00:12:04 +01:00

After applying my patch, I was unable to reproduce #55668 . It looks like each strip its given a unique name properly, even with nested Meta-Strips.

I was able however to find a similar bug, reported as #60370 , but I believe it is unrelated.

Therefore I am submitting patch [D4186 ](https://developer.blender.org/D4186)

After applying my patch, I was unable to reproduce [#55668 ](https://developer.blender.org/T55668). It looks like each strip its given a unique name properly, even with nested Meta-Strips. I was able however to find a similar bug, reported as [#60370 ](https://developer.blender.org/T60370), but I believe it is unrelated. Therefore I am submitting patch [[D4186](https://archive.blender.org/developer/D4186) ](https://developer.blender.org/D4186)

Guillaume M commented

2019-01-10 11:24:07 +01:00

After a bit more testing, it looks like this patch indeed solves this bug, but also introduces a new minor bug #60194 .

I don't see how to solve #60370, has anyone experienced this type of problem ? Maybe there is a flag to set on the newly animated strip, or some kind of cache to clear ?

Youtube video demonstrating the problem

After a bit more testing, it looks like this patch indeed solves this bug, but also introduces a new minor bug [#60194 ](https://developer.blender.org/T60370). I don't see how to solve #60370, has anyone experienced this type of problem ? Maybe there is a flag to set on the newly animated strip, or some kind of cache to clear ? [Youtube video demonstrating the problem ](https://youtu.be/CZowk2XVoXk)

Richard Antalik was unassigned by Bastien Montagne

2019-01-10 22:34:21 +01:00

Bastien Montagne self-assigned this 2019-01-10 22:34:21 +01:00

Bastien Montagne commented

2019-01-10 22:34:21 +01:00

bb98e83b99 is indeed a wrong fix (breaking animation), need to redo that in another way that also handles animation well… :/

bb98e83b99 is indeed a wrong fix (breaking animation), need to redo that in another way that also handles animation well… :/

blender-admin commented

2019-01-11 19:48:56 +01:00

This issue was referenced by 1ded3d2f7c

This issue was referenced by 1ded3d2f7c04100698afdee356e2ba8d4ae2d6bd

Bastien Montagne commented

2019-01-11 19:53:33 +01:00

Added subscriber: @JacquesLucke

Bastien Montagne commented

2019-01-11 20:03:43 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2019-01-11 20:03:43 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Sequencer cut loses animation data for the right strip #60194