Unparenting after transforming in an operator fails to update the depsgraph when using Redo Last #64300

Closed
opened 4 years ago by MACHIN3 · 9 comments

System Information
Operating system: Linux-4.13.10-041310-generic-x86_64-with-debian-stretch-sid 64 Bits
Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.67

Blender Version
Broken: version: 2.80 (sub 60), branch: blender2.7, commit date: 2019-05-07 19:17, hash: 3dc9da3a74
Worked: 2.79

Short description of error
I have a plane and a cube being parented to it. I have an operator, that rotates the plane utilizing Redo Last, to tweak the amount.
After the rotation, the operator unparents the cube.
The expected behavior would be that the cube is rotated with the plane(as it is parented to it), and is unparented only at the end, after the rotation. This works fine in 2.79, as long as a scene.update() is done in between the rotation and the unparenting.
In 2.80 however the rotation(and likey any other transformation) of the plane doesn't carry through to the cube, if you use Redo Last.
There is a video demo , so you can better vizualize what I'm talking about.

Exact steps for others to reproduce the error

  • open unparent_after_parent_rotation279.blend in Blender 2.79
    • notice how the cube is parented to the plane
    • run the script to register the Rotator operator and run the op in the 3d view
    • bring up the Redo Last panel to change the amount of the rotation
    • notice how the cube is rotated with the plane, but is unparented at the end
    • comment out the scene.update() to break the op
      • without the scene.update(), the depsgraph(?) doesn't know about the rotation when unparented, this is expected
  • open unparent_after_parent_rotation.blend in Blender 2.80
    • notice again that the cube is parented to the plane
    • run the script to register the Rotator operator and run the op in the 3d view
    • bring up the Redo Last panel to change the amount of the rotation
    • notice how the cube is NOT ROTATED with the plane this time, DESPITE the scene.update()
      • it still is unparented but it looks like at the time of the unparenting, the depsgraph is not aware of the transformation done previously
    • reset the scene and change the default value of self.degrees
      • notice how the op works fine on its initial run, but as soon as you use Redo Last it breaks

I think this is one for @sergey.

**System Information** Operating system: Linux-4.13.10-041310-generic-x86_64-with-debian-stretch-sid 64 Bits Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.67 **Blender Version** Broken: version: 2.80 (sub 60), branch: blender2.7, commit date: 2019-05-07 19:17, hash: `3dc9da3a74` Worked: 2.79 **Short description of error** I have a plane and a cube being parented to it. I have an operator, that rotates the plane utilizing *Redo Last*, to tweak the amount. After the rotation, the operator unparents the cube. The expected behavior would be that the cube is rotated with the plane(as it is parented to it), and is unparented only at the end, after the rotation. This works fine in 2.79, as long as a scene.update() is done in between the rotation and the unparenting. In 2.80 however the rotation(and likey any other transformation) of the plane doesn't carry through to the cube, if you use *Redo Last*. There is [a video demo ](https://www.youtube.com/watch?v=Gkw0UFPUGUw), so you can better vizualize what I'm talking about. **Exact steps for others to reproduce the error** * open [unparent_after_parent_rotation279.blend](https://archive.blender.org/developer/F7014815/unparent_after_parent_rotation279.blend) in Blender 2.79 * notice how the cube is parented to the plane * run the script to register the Rotator operator and run the op in the 3d view * bring up the *Redo Last* panel to change the amount of the rotation * notice how the cube is rotated with the plane, but is unparented at the end * comment out the scene.update() to break the op * without the scene.update(), the depsgraph(?) doesn't know about the rotation when unparented, this is expected * open [unparent_after_parent_rotation.blend](https://archive.blender.org/developer/F7014820/unparent_after_parent_rotation.blend) in Blender 2.80 * notice again that the cube is parented to the plane * run the script to register the Rotator operator and run the op in the 3d view * bring up the *Redo Last* panel to change the amount of the rotation * notice how the cube is NOT ROTATED with the plane this time, DESPITE the scene.update() * it still is unparented but it looks like at the time of the unparenting, the depsgraph is not aware of the transformation done previously * reset the scene and change the default value of self.degrees * notice how the op works fine on its initial run, but as soon as you use *Redo Last* it breaks I think this is one for @sergey.
Poster

Added subscribers: @Sergey, @MACHIN3

Added subscribers: @Sergey, @MACHIN3
Poster

FWIW, if you rotate an object and then parent it, you will have the same problem. The object won't be parented in it's new rotated orientation, as you'd expect.

FWIW, if you rotate an object and then parent it, you will have the same problem. The object won't be parented in it's new rotated orientation, as you'd expect.
ideasman42 was assigned by ZedDB 4 years ago
ZedDB commented 4 years ago
Collaborator

Added subscriber: @ZedDB

Added subscriber: @ZedDB
ZedDB commented 4 years ago
Collaborator

I just note that this might be a duplicate of #64307 but I'll not merged them as I am quite uncertain.

I just note that this might be a duplicate of #64307 but I'll not merged them as I am quite uncertain.
Poster

The issues persists, even after the recent depsgraph changes.
I have update the blend: unparent_after_parent_rotation_depsgraph.blend

@Sergey

The issues persists, even after the recent depsgraph changes. I have update the blend: [unparent_after_parent_rotation_depsgraph.blend](https://archive.blender.org/developer/F7043708/unparent_after_parent_rotation_depsgraph.blend) @Sergey
ideasman42 was unassigned by Sergey 4 years ago
Sergey self-assigned this 4 years ago
Sergey commented 4 years ago
Owner

Added subscriber: @ideasman42

Added subscriber: @ideasman42
Sergey commented 4 years ago
Owner

@MACHIN3 thanks for the updated file!

Re-assigning to me, think it's nothing to do with Campbell.

@MACHIN3 thanks for the updated file! Re-assigning to me, think it's nothing to do with Campbell.
Collaborator

This issue was referenced by be5fd9c09f

This issue was referenced by be5fd9c09f2539b9268f422252d9a1d01bc1769c
Sergey commented 4 years ago
Owner

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sergey closed this issue 4 years ago
Sign in to join this conversation.
No Label
Interest/Alembic
Interest/Animation & Rigging
Interest/Asset Browser
Interest/Asset Browser Project Overview
Interest/Audio
Interest/Automated Testing
Interest/Blender Asset Bundle
Interest/Collada
Interest/Compositing
Interest/Core
Interest/Cycles
Interest/Dependency Graph
Interest/Development Management
Interest/Eevee & Viewport
Interest/Freestyle
Interest/Geometry Nodes
Interest/Grease Pencil
Interest/ID Management
Interest/Images & Movies
Interest/Import/Export
Interest/Line Art
Interest/Masking
Interest/Modeling
Interest/Modifiers
Interest/Motion Tracking
Interest/Nodes & Physics
Interest/Overrides
Interest/Performance
Interest/Performance
Interest/Physics
Interest/Pipeline, Assets & I/O
Interest/Platforms, Builds, Tests & Devices
Interest/Python API
Interest/Render & Cycles
Interest/Render Pipeline
Interest/Sculpt, Paint & Texture
Interest/Text Editor
Interest/Translations
Interest/Triaging
Interest/Undo
Interest/USD
Interest/User Interface
Interest/UV Editing
Interest/VFX & Video
Interest/Video Sequencer
Interest/Virtual Reality
legacy module/Animation & Rigging
legacy module/Core
legacy module/Development Management
legacy module/Eevee & Viewport
legacy module/Grease Pencil
legacy module/Modeling
legacy module/Nodes & Physics
legacy module/Pipeline, Assets & IO
legacy module/Platforms, Builds, Tests & Devices
legacy module/Python API
legacy module/Rendering & Cycles
legacy module/Sculpt, Paint & Texture
legacy module/Triaging
legacy module/User Interface
legacy module/VFX & Video
legacy project/1.0.0-beta.2
legacy project/Asset Browser (Archived)
legacy project/BF Blender: 2.8
legacy project/BF Blender: After Release
legacy project/BF Blender: Next
legacy project/BF Blender: Regressions
legacy project/BF Blender: Unconfirmed
legacy project/Blender 2.70
legacy project/Code Quest
legacy project/Datablocks and Libraries
legacy project/Eevee
legacy project/Game Animation
legacy project/Game Audio
legacy project/Game Data Conversion
legacy project/Game Engine
legacy project/Game Logic
legacy project/Game Physics
legacy project/Game Python
legacy project/Game Rendering
legacy project/Game UI
legacy project/GPU / Viewport
legacy project/GSoC
legacy project/Infrastructure: Websites
legacy project/LibOverrides - Usability and UX
legacy project/Milestone 1: Basic, Local Asset Browser
legacy project/Nodes
legacy project/OpenGL Error
legacy project/Papercut
legacy project/Pose Library Basics
legacy project/Retrospective
legacy project/Tracker Curfew
legacy project/Wintab High Frequency
Meta/Good First Issue
Meta/Papercut
migration/requires-manual-verification
Module › Animation & Rigging
Module › Core
Module › Development Management
Module › Eevee & Viewport
Module › Grease Pencil
Module › Modeling
Module › Nodes & Physics
Module › Pipeline, Assets & IO
Module › Platforms, Builds, Tests & Devices
Module › Python API
Module › Render & Cycles
Module › Sculpt, Paint & Texture
Module › Triaging
Module › User Interface
Module › VFX & Video
Platform/FreeBSD
Platform/Linux
Platform/macOS
Platform/Windows
Priority › High
Priority › Low
Priority › Normal
Priority › Unbreak Now!
Status › Archived
Status › Confirmed
Status › Duplicate
Status › Needs Information from Developers
Status › Needs Information from User
Status › Needs Triage
Status › Resolved
Type › Bug
Type › Design
Type › Known Issue
Type › Patch
Type › Report
Type › To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#64300
Loading…
There is no content yet.