Popovers scroll arrows glitch #65351

System Information
Operating system: Darwin-18.2.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-2.4.10

Blender Version
Broken: version: 2.80 (sub 72), branch: blender2.7, commit date: 2019-05-29 18:17, hash: fee600f479

Short description of error

When you scroll popovers, the content goes beyond the boundaries:

The active area of scroll arrows that responds to mouse hover is shifted:

There is an offset for backdrop, in ui_draw_popover_back_impl, but not for the content itself, this causes this error.

  rect->ymax -= unit_half;
  rect->ymin += unit_half;

Added subscriber: @jenkm

Added subscriber: @WilliamReynish

This comment was removed by @jenkm

Removed subscriber: @WilliamReynish

There is an offset for backdrop, in ui_draw_popover_back_impl, but not for the content itself, this causes this error.

  rect->ymax -= unit_half;
  rect->ymin += unit_half;

Added subscriber: @iss

Changed status from 'Confirmed' to: 'Needs User Info'

I have re-triaged this report and can not reproduce it.
Can you please check if this is still an issue in latest build?
https://builder.blender.org/download/

Added subscriber: @brecht

It's become less noticeable after the D6483, but it's still here.

You can just check where the on mouse hover scrolling active zone is, and see it is shifted relative to the arrow that marks it.

Anyway, I have a patch for that. I think @brecht can take a look at this.
Maybe there's a more elegant solution.

diff --git a/source/blender/editors/interface/interface_region_popup.c b/source/blender/editors/interface/interface_region_popup.c
index 867ac652505..56652bf170a 100644
--- a/source/blender/editors/interface/interface_region_popup.c
+++ b/source/blender/editors/interface/interface_region_popup.c
@@ -708,6 +708,15 @@ uiBlock *ui_popup_block_refresh(bContext *C,
     }
   }
   else {
+    /* Add an offset to draw the popover arrow. */
+    if ((block->flag & UI_BLOCK_POPOVER) && ELEM(block->direction, UI_DIR_UP, UI_DIR_DOWN)) {
+      /* Keep sync with the 'ui_draw_popover_back'. */
+      const float unit_size = U.widget_unit / block->aspect;
+      const float unit_half = unit_size * (block->direction == UI_DIR_DOWN ? 0.5 : -0.5);
+
+      UI_block_translate(block, 0, -unit_half);
+    }
+
     /* clip block with window boundary */
     ui_popup_block_clip(window, block);
 
diff --git a/source/blender/editors/interface/interface_widgets.c b/source/blender/editors/interface/interface_widgets.c
index 92032c3b18c..8c28b29f5ab 100644
--- a/source/blender/editors/interface/interface_widgets.c
+++ b/source/blender/editors/interface/interface_widgets.c
@@ -4970,8 +4970,6 @@ static void ui_draw_popover_back_impl(const uiWidgetColors *wcol,
                                              rect->xmin + unit_size,
                                              rect->xmax - unit_size) :
                                      BLI_rcti_cent_x(rect);
-  rect->ymax -= unit_half;
-  rect->ymin += unit_half;
 
   GPU_blend(true);

It's become less noticeable after the [D6483](https://archive.blender.org/developer/D6483), but it's still here. ![popover-offset.png](https://archive.blender.org/developer/F8320760/popover-offset.png) You can just check where the on mouse hover scrolling active zone is, and see it is shifted relative to the arrow that marks it. ![3.jpg](https://archive.blender.org/developer/F7081236/3.jpg) Anyway, I have a patch for that. I think @brecht can take a look at this. Maybe there's a more elegant solution. ``` diff --git a/source/blender/editors/interface/interface_region_popup.c b/source/blender/editors/interface/interface_region_popup.c index 867ac652505..56652bf170a 100644 --- a/source/blender/editors/interface/interface_region_popup.c +++ b/source/blender/editors/interface/interface_region_popup.c @@ -708,6 +708,15 @@ uiBlock *ui_popup_block_refresh(bContext *C, } } else { + /* Add an offset to draw the popover arrow. */ + if ((block->flag & UI_BLOCK_POPOVER) && ELEM(block->direction, UI_DIR_UP, UI_DIR_DOWN)) { + /* Keep sync with the 'ui_draw_popover_back'. */ + const float unit_size = U.widget_unit / block->aspect; + const float unit_half = unit_size * (block->direction == UI_DIR_DOWN ? 0.5 : -0.5); + + UI_block_translate(block, 0, -unit_half); + } + /* clip block with window boundary */ ui_popup_block_clip(window, block); diff --git a/source/blender/editors/interface/interface_widgets.c b/source/blender/editors/interface/interface_widgets.c index 92032c3b18c..8c28b29f5ab 100644 --- a/source/blender/editors/interface/interface_widgets.c +++ b/source/blender/editors/interface/interface_widgets.c @@ -4970,8 +4970,6 @@ static void ui_draw_popover_back_impl(const uiWidgetColors *wcol, rect->xmin + unit_size, rect->xmax - unit_size) : BLI_rcti_cent_x(rect); - rect->ymax -= unit_half; - rect->ymin += unit_half; GPU_blend(true); ```

Changed status from 'Needs User Info' to: 'Confirmed'

This patch adds spacing to the top over every popover, also without scrolling, and it doesn't look good.

I think somehow this should only be done when scrolling somehow?

The patch can also be simplified by using:

UI_block_translate(block, 0, -unit_half);

There is another problem, when you scroll down the popover and then go back it doesn't return to the original position, the margin gets smaller.

Now (initially open vs scrolled):

After patch above (initially open vs scrolled):

Ok, this extra offset comes from ui_menu_scroll_apply_offset_y.

popovers-offset-patch.patch

This issue was referenced by fe3ce61528

Changed status from 'Confirmed' to: 'Resolved'

@brecht there was a problem after this patch, the arrow is now cropped. Any ideas?

And it's only for down directional, the upward direction works fine.

{F8400498, size=full}

The upward direction works fine:

{F8400511, size=full}

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Popovers scroll arrows glitch #65351