Blender doesn't quit. #65966

Closed
opened 4 years ago by LazyDodo · 13 comments
Collaborator

System Information
Operating system: Win64
Graphics card: N/A

Blender Version
Broken: 2f77175fec
Worked: (optional)

Short description of error
Blender does not quit when there is unsaved data.

Exact steps for others to reproduce the error
With the default cube scene.

  1. Delete the cube
  2. Quit blender, by either using the menu item or the X in the upper right corner of the window
  3. This file has not been saved yet! save? Sure. why not.
  4. Enter filename, save
  5. Blender returns to the 3d view
  6. click X again.
  7. ahhh now we quit...

mentioned this informally to @Harley on chat but unsure if he's working on a fix or not.

**System Information** Operating system: Win64 Graphics card: N/A **Blender Version** Broken: 2f77175fecc7 Worked: (optional) **Short description of error** Blender does not quit when there is unsaved data. **Exact steps for others to reproduce the error** With the default cube scene. 1) Delete the cube 2) Quit blender, by either using the menu item or the X in the upper right corner of the window 3) This file has not been saved yet! save? Sure. why not. 4) Enter filename, save 5) Blender returns to the 3d view 6) click X again. 7) ahhh now we quit... mentioned this informally to @Harley on chat but unsure if he's working on a fix or not.
Poster
Collaborator

Added subscribers: @Harley, @LazyDodo

Added subscribers: @Harley, @LazyDodo
Collaborator

#66609 was marked as duplicate of this issue

#66609 was marked as duplicate of this issue

Added subscribers: @JacquesLucke, @WilliamReynish

Added subscribers: @JacquesLucke, @WilliamReynish

This is a known issue - mainly due to limitations in the operator system.

@JacquesLucke has fought with this.

It's still a valid issue, so I set it to Confirmed, but there seems to be no immediate solution.

This is a known issue - mainly due to limitations in the operator system. @JacquesLucke has fought with this. It's still a valid issue, so I set it to Confirmed, but there seems to be no immediate solution.

Added subscriber: @ChristopherAnderssarian

Added subscriber: @ChristopherAnderssarian
I think he *was...* [D5096: UI: Exit After Successful Close_Save](https://archive.blender.org/developer/D5096)
Harley commented 4 years ago
Collaborator

I did make a patch for that, and subsequently abandoned it. The patch addressed the above steps perfectly. It quit after saving a new file, and it did not quit if you selected "cancel" in the File Manager.

The problem is that it broke related behavior. So opening a blend file, or creating a new one, while you have a never-saved file open. In that case it would prompt to save and then quit when you want to carry on with the new file. Looking through all this stuff (wm_files.c) I can't see any easy way to get that early intention (quit or carry on) to where it needs to be acted on after the file manager save. It is a complicated dance and will leave it for someone else smarter. LOL

I did make [a patch ](https://developer.blender.org/D5096) for that, and subsequently abandoned it. The patch addressed the above steps perfectly. It quit after saving a new file, and it did not quit if you selected "cancel" in the File Manager. The problem is that it broke related behavior. So opening a blend file, or creating a new one, while you have a never-saved file open. In that case it would prompt to save and then quit when you want to carry on with the new file. Looking through all this stuff (wm_files.c) I can't see any easy way to get that early intention (quit or carry on) to where it needs to be acted on after the file manager save. It is a complicated dance and will leave it for someone else smarter. LOL
brecht commented 4 years ago
Owner

Added subscriber: @brecht

Added subscriber: @brecht
brecht commented 4 years ago
Owner

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
brecht closed this issue 4 years ago
brecht self-assigned this 4 years ago
brecht commented 4 years ago
Owner

We should improve this, but it's not a bug.

We should improve this, but it's not a bug.
Poster
Collaborator

what is our definition of a 'bug' ? I always used 'works as designed, but perhaps not optimal' as the cut off for closing tickets as 'not a bug'

But you surely can't be making the case here that we designed File->Quit not to quit, File->New not to give me a new file and File->Open not to open a file if there was work to be saved?

Don't get me wrong, I appreciate that the deeper underlying issues are not easy to solve, but hard to solve bugs, are bugs.

it's strange UI like this that make people go 'blender is just weird for the sake of being weird'

what is our definition of a 'bug' ? I always used 'works as designed, but perhaps not optimal' as the cut off for closing tickets as 'not a bug' But you surely can't be making the case here that we designed File->Quit not to quit, File->New not to give me a new file and File->Open not to open a file if there was work to be saved? Don't get me wrong, I appreciate that the deeper underlying issues are not easy to solve, but hard to solve bugs, are bugs. it's strange UI like this that make people go 'blender is just weird for the sake of being weird'
brecht commented 4 years ago
Owner

There was a code review for the quit dialog changes, where this was accepted as a known limitation.

There was a code review for the quit dialog changes, where this was accepted as a known limitation.
Poster
Collaborator

Added subscriber: @Rawalanche

Added subscriber: @Rawalanche
Sign in to join this conversation.
No Label
Interest/Alembic
Interest/Animation & Rigging
Interest/Asset Browser
Interest/Asset Browser Project Overview
Interest/Audio
Interest/Automated Testing
Interest/Blender Asset Bundle
Interest/Collada
Interest/Compositing
Interest/Core
Interest/Cycles
Interest/Dependency Graph
Interest/Development Management
Interest/Eevee & Viewport
Interest/Freestyle
Interest/Geometry Nodes
Interest/Grease Pencil
Interest/ID Management
Interest/Images & Movies
Interest/Import/Export
Interest/Line Art
Interest/Masking
Interest/Modeling
Interest/Modifiers
Interest/Motion Tracking
Interest/Nodes & Physics
Interest/Overrides
Interest/Performance
Interest/Performance
Interest/Physics
Interest/Pipeline, Assets & I/O
Interest/Platforms, Builds, Tests & Devices
Interest/Python API
Interest/Render & Cycles
Interest/Render Pipeline
Interest/Sculpt, Paint & Texture
Interest/Text Editor
Interest/Translations
Interest/Triaging
Interest/Undo
Interest/USD
Interest/User Interface
Interest/UV Editing
Interest/VFX & Video
Interest/Video Sequencer
Interest/Virtual Reality
legacy module/Animation & Rigging
legacy module/Core
legacy module/Development Management
legacy module/Eevee & Viewport
legacy module/Grease Pencil
legacy module/Modeling
legacy module/Nodes & Physics
legacy module/Pipeline, Assets & IO
legacy module/Platforms, Builds, Tests & Devices
legacy module/Python API
legacy module/Rendering & Cycles
legacy module/Sculpt, Paint & Texture
legacy module/Triaging
legacy module/User Interface
legacy module/VFX & Video
legacy project/1.0.0-beta.2
legacy project/Asset Browser (Archived)
legacy project/BF Blender: 2.8
legacy project/BF Blender: After Release
legacy project/BF Blender: Next
legacy project/BF Blender: Regressions
legacy project/BF Blender: Unconfirmed
legacy project/Blender 2.70
legacy project/Code Quest
legacy project/Datablocks and Libraries
legacy project/Eevee
legacy project/Game Animation
legacy project/Game Audio
legacy project/Game Data Conversion
legacy project/Game Engine
legacy project/Game Logic
legacy project/Game Physics
legacy project/Game Python
legacy project/Game Rendering
legacy project/Game UI
legacy project/GPU / Viewport
legacy project/GSoC
legacy project/Infrastructure: Websites
legacy project/LibOverrides - Usability and UX
legacy project/Milestone 1: Basic, Local Asset Browser
legacy project/Nodes
legacy project/OpenGL Error
legacy project/Papercut
legacy project/Pose Library Basics
legacy project/Retrospective
legacy project/Tracker Curfew
legacy project/Wintab High Frequency
Meta/Good First Issue
Meta/Papercut
migration/requires-manual-verification
Module › Animation & Rigging
Module › Core
Module › Development Management
Module › Eevee & Viewport
Module › Grease Pencil
Module › Modeling
Module › Nodes & Physics
Module › Pipeline, Assets & IO
Module › Platforms, Builds, Tests & Devices
Module › Python API
Module › Render & Cycles
Module › Sculpt, Paint & Texture
Module › Triaging
Module › User Interface
Module › VFX & Video
Platform/FreeBSD
Platform/Linux
Platform/macOS
Platform/Windows
Priority › High
Priority › Low
Priority › Normal
Priority › Unbreak Now!
Status › Archived
Status › Confirmed
Status › Duplicate
Status › Needs Information from Developers
Status › Needs Information from User
Status › Needs Triage
Status › Resolved
Type › Bug
Type › Design
Type › Known Issue
Type › Patch
Type › Report
Type › To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#65966
Loading…
There is no content yet.