Modifying bone's 'Custom Object' reference shape causes blender to crash #66707

New Issue

Ash Curkpatrick · 2019-07-11T13:53:08+02:00

Ash Curkpatrick commented

2019-07-11 13:53:08 +02:00

System Information
Operating system: macOS 10.14.5
Graphics card: Radeon Pro Vega 48 8 GB

Blender Version
Broken: 2.80 Beta macOS 64bit　bb7b741d2f1c

Stable
141.42MB

Short description of error

Editing the custom shapes for a bone whilst actively being referenced will crash blender and close the application. Removing the custom bone shape and editing the reference shape before re-referencing it again will work.

Exact steps for others to reproduce the error
・Create a bone
・Create an object to reference as a custom shape
・Add the object on the bone as a 'Custom Object' for the bone shape
・Select the custom object
・Go in to Edit Mode for the object
・Select the vertices
・Move the vertices
・The application will crash

**System Information** Operating system: macOS 10.14.5 Graphics card: Radeon Pro Vega 48 8 GB **Blender Version** Broken: 2.80 Beta macOS 64bit　bb7b741d2f1c Stable 141.42MB **Short description of error** Editing the custom shapes for a bone whilst actively being referenced will crash blender and close the application. Removing the custom bone shape and editing the reference shape before re-referencing it again will work. **Exact steps for others to reproduce the error** ・Create a bone ・Create an object to reference as a custom shape ・Add the object on the bone as a 'Custom Object' for the bone shape ・Select the custom object ・Go in to Edit Mode for the object ・Select the vertices ・Move the vertices ・The application will crash

Ash Curkpatrick commented

2019-07-11 13:53:08 +02:00

Added subscriber: @curkas

blender-admin commented

2019-07-11 13:53:08 +02:00

#66932 was marked as duplicate of this issue

blender-admin commented

2019-07-11 13:53:08 +02:00

#66721 was marked as duplicate of this issue

Sebastian Parborg commented

2019-07-11 14:33:55 +02:00

Added subscribers: @WilliamReynish, @Sergey, @ZedDB

Sebastian Parborg commented

2019-07-11 14:33:55 +02:00

I can see the bone flickering when editing the object, but no crashes and ASAN doesn't complain about anything either.

@Sergey @WilliamReynish can you reproduce this on a mac?

I can see the bone flickering when editing the object, but no crashes and ASAN doesn't complain about anything either. @Sergey @WilliamReynish can you reproduce this on a mac?

William Reynish commented

2019-07-11 14:35:22 +02:00

Yes indeed I can reproduce this crash.

Sergey Sharybin commented

2019-07-11 14:37:19 +02:00

Can someone upload .blend file?

Jeroen Bakker commented

2019-07-11 14:38:29 +02:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker commented

2019-07-11 14:38:29 +02:00

Hello @curkas

I am not able to reproduce. Could you provide an example file to make sure I execute the steps in exactly the same way as you describe it.

Thanks.

Hello @curkas I am not able to reproduce. Could you provide an example file to make sure I execute the steps in exactly the same way as you describe it. Thanks.

Sebastian Parborg commented

2019-07-11 14:43:02 +02:00

This is the example I came up with (note that I couldn't get it to crash):
untitled.blend

This is the example I came up with (note that I couldn't get it to crash): [untitled.blend](https://archive.blender.org/developer/F7592364/untitled.blend)

William Reynish commented

2019-07-11 14:44:56 +02:00

Here's the crash log I get, when I move those verts in Edit mode:

untitled-2.crash.txt

macOS Mojave 10.14.5

Here's the crash log I get, when I move those verts in Edit mode: [untitled-2.crash.txt](https://archive.blender.org/developer/F7592376/untitled-2.crash.txt) macOS Mojave 10.14.5

Sergey Sharybin commented

2019-07-11 14:58:06 +02:00

Added subscriber: @fclem

Sergey Sharybin commented

2019-07-11 14:58:06 +02:00

@WilliamReynish, do you have crash with the file from Sebastian?

Can reproduce the flickering on my mac. Maybe it's same source of crash.

@fclem, the backtrace shows drawing code is involved. Do you have any ideas?

@WilliamReynish, do you have crash with the file from Sebastian? Can reproduce the flickering on my mac. Maybe it's same source of crash. @fclem, the backtrace shows drawing code is involved. Do you have any ideas?

William Reynish commented

2019-07-11 14:59:27 +02:00

@Sergey yes that file crashes if I enter edit mode on the mesh object and begin to move the verts. I have no flickering, only a crash here.

Ash Curkpatrick commented

2019-07-12 04:16:11 +02:00

@Jeroen-Bakker I can't get it to always happen in a new file (though it does occur), but it will invariably occur in this file particular file here

Host02.blend

You can see the result here in this screen recording.

Screen Recording 2019-07-12 at 11.10.10.mp4

@Jeroen-Bakker I can't get it to always happen in a new file (though it does occur), but it will invariably occur in this file particular file here [Host02.blend](https://archive.blender.org/developer/F7597990/Host02.blend) You can see the result here in this screen recording. [Screen Recording 2019-07-12 at 11.10.10.mp4](https://archive.blender.org/developer/F7598097/Screen_Recording_2019-07-12_at_11.10.10.mp4)

Sebastian Parborg commented

2019-07-12 10:17:32 +02:00

Added subscribers: @linosia, @GavinScott

Sergey Sharybin commented

2019-07-12 16:47:52 +02:00

@fclem, i can not see anything obviously wrong in the dependency graph logs. My speculation here is that editing vertex causes draw batch to be invalidated, and armature somehow uses old draw batch, which gets re-created by the mesh object. At lest that's my understanding why flickering happens and why backtrace goes to the draw code.

Clément Foucault self-assigned this 2019-07-15 15:46:40 +02:00

Clément Foucault commented

2019-07-15 15:46:40 +02:00

I can reproduce the flickering and this is exactly what @Sergey was suggesting.