Modifying bone's 'Custom Object' reference shape causes blender to crash #66707

Closed
opened 4 years ago by curkas · 21 comments
curkas commented 4 years ago

System Information
Operating system: macOS 10.14.5
Graphics card: Radeon Pro Vega 48 8 GB

Blender Version
Broken: 2.80 Beta macOS 64bit bb7b741d2f1c

Stable
141.42MB

Short description of error

Editing the custom shapes for a bone whilst actively being referenced will crash blender and close the application. Removing the custom bone shape and editing the reference shape before re-referencing it again will work.

Exact steps for others to reproduce the error
・Create a bone
・Create an object to reference as a custom shape
・Add the object on the bone as a 'Custom Object' for the bone shape
・Select the custom object
・Go in to Edit Mode for the object
・Select the vertices
・Move the vertices
・The application will crash

**System Information** Operating system: macOS 10.14.5 Graphics card: Radeon Pro Vega 48 8 GB **Blender Version** Broken: 2.80 Beta macOS 64bit bb7b741d2f1c Stable 141.42MB **Short description of error** Editing the custom shapes for a bone whilst actively being referenced will crash blender and close the application. Removing the custom bone shape and editing the reference shape before re-referencing it again will work. **Exact steps for others to reproduce the error** ・Create a bone ・Create an object to reference as a custom shape ・Add the object on the bone as a 'Custom Object' for the bone shape ・Select the custom object ・Go in to Edit Mode for the object ・Select the vertices ・Move the vertices ・The application will crash
curkas commented 4 years ago
Poster

Added subscriber: @curkas

Added subscriber: @curkas
Collaborator

#66932 was marked as duplicate of this issue

#66932 was marked as duplicate of this issue
Collaborator

#66721 was marked as duplicate of this issue

#66721 was marked as duplicate of this issue
ZedDB commented 4 years ago
Collaborator

Added subscribers: @WilliamReynish, @Sergey, @ZedDB

Added subscribers: @WilliamReynish, @Sergey, @ZedDB
ZedDB commented 4 years ago
Collaborator

I can see the bone flickering when editing the object, but no crashes and ASAN doesn't complain about anything either.

@Sergey @WilliamReynish can you reproduce this on a mac?

I can see the bone flickering when editing the object, but no crashes and ASAN doesn't complain about anything either. @Sergey @WilliamReynish can you reproduce this on a mac?

Yes indeed I can reproduce this crash.

Yes indeed I can reproduce this crash.
Sergey commented 4 years ago
Owner

Can someone upload .blend file?

Can someone upload .blend file?
Collaborator

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jeroen-Bakker
Collaborator

Hello @curkas

I am not able to reproduce. Could you provide an example file to make sure I execute the steps in exactly the same way as you describe it.

Thanks.

Hello @curkas I am not able to reproduce. Could you provide an example file to make sure I execute the steps in exactly the same way as you describe it. Thanks.
ZedDB commented 4 years ago
Collaborator

This is the example I came up with (note that I couldn't get it to crash):
untitled.blend

This is the example I came up with (note that I couldn't get it to crash): [untitled.blend](https://archive.blender.org/developer/F7592364/untitled.blend)

Here's the crash log I get, when I move those verts in Edit mode:

untitled-2.crash.txt

macOS Mojave 10.14.5

Here's the crash log I get, when I move those verts in Edit mode: [untitled-2.crash.txt](https://archive.blender.org/developer/F7592376/untitled-2.crash.txt) macOS Mojave 10.14.5
Sergey commented 4 years ago
Owner

Added subscriber: @fclem

Added subscriber: @fclem
Sergey commented 4 years ago
Owner

@WilliamReynish, do you have crash with the file from Sebastian?

Can reproduce the flickering on my mac. Maybe it's same source of crash.

@fclem, the backtrace shows drawing code is involved. Do you have any ideas?

@WilliamReynish, do you have crash with the file from Sebastian? Can reproduce the flickering on my mac. Maybe it's same source of crash. @fclem, the backtrace shows drawing code is involved. Do you have any ideas?

@Sergey yes that file crashes if I enter edit mode on the mesh object and begin to move the verts. I have no flickering, only a crash here.

@Sergey yes that file crashes if I enter edit mode on the mesh object and begin to move the verts. I have no flickering, only a crash here.
curkas commented 4 years ago
Poster

@Jeroen-Bakker I can't get it to always happen in a new file (though it does occur), but it will invariably occur in this file particular file here

Host02.blend

You can see the result here in this screen recording.

Screen Recording 2019-07-12 at 11.10.10.mp4

@Jeroen-Bakker I can't get it to always happen in a new file (though it does occur), but it will invariably occur in this file particular file here [Host02.blend](https://archive.blender.org/developer/F7597990/Host02.blend) You can see the result here in this screen recording. [Screen Recording 2019-07-12 at 11.10.10.mp4](https://archive.blender.org/developer/F7598097/Screen_Recording_2019-07-12_at_11.10.10.mp4)
ZedDB commented 4 years ago
Collaborator

Added subscribers: @linosia, @GavinScott

Added subscribers: @linosia, @GavinScott
Sergey commented 4 years ago
Owner

@fclem, i can not see anything obviously wrong in the dependency graph logs. My speculation here is that editing vertex causes draw batch to be invalidated, and armature somehow uses old draw batch, which gets re-created by the mesh object. At lest that's my understanding why flickering happens and why backtrace goes to the draw code.

@fclem, i can not see anything obviously wrong in the dependency graph logs. My speculation here is that editing vertex causes draw batch to be invalidated, and armature somehow uses old draw batch, which gets re-created by the mesh object. At lest that's my understanding why flickering happens and why backtrace goes to the draw code.
fclem self-assigned this 4 years ago
fclem commented 4 years ago
Collaborator

I can reproduce the flickering and this is exactly what @Sergey was suggesting.

I can reproduce the flickering and this is exactly what @Sergey was suggesting.
ZedDB commented 4 years ago
Collaborator

Added subscriber: @Zophiekat

Added subscriber: @Zophiekat
Collaborator

This issue was referenced by 4404a0dcd4

This issue was referenced by 4404a0dcd4c593d199786d01a092105267243235
fclem commented 4 years ago
Collaborator

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
fclem closed this issue 4 years ago
Sign in to join this conversation.
No Label
Interest/Alembic
Interest/Animation & Rigging
Interest/Asset Browser
Interest/Asset Browser Project Overview
Interest/Audio
Interest/Automated Testing
Interest/Blender Asset Bundle
Interest/Collada
Interest/Compositing
Interest/Core
Interest/Cycles
Interest/Dependency Graph
Interest/Development Management
Interest/Eevee & Viewport
Interest/Freestyle
Interest/Geometry Nodes
Interest/Grease Pencil
Interest/ID Management
Interest/Images & Movies
Interest/Import/Export
Interest/Line Art
Interest/Masking
Interest/Modeling
Interest/Modifiers
Interest/Motion Tracking
Interest/Nodes & Physics
Interest/Overrides
Interest/Performance
Interest/Performance
Interest/Physics
Interest/Pipeline, Assets & I/O
Interest/Platforms, Builds, Tests & Devices
Interest/Python API
Interest/Render & Cycles
Interest/Render Pipeline
Interest/Sculpt, Paint & Texture
Interest/Text Editor
Interest/Translations
Interest/Triaging
Interest/Undo
Interest/USD
Interest/User Interface
Interest/UV Editing
Interest/VFX & Video
Interest/Video Sequencer
Interest/Virtual Reality
legacy module/Animation & Rigging
legacy module/Core
legacy module/Development Management
legacy module/Eevee & Viewport
legacy module/Grease Pencil
legacy module/Modeling
legacy module/Nodes & Physics
legacy module/Pipeline, Assets & IO
legacy module/Platforms, Builds, Tests & Devices
legacy module/Python API
legacy module/Rendering & Cycles
legacy module/Sculpt, Paint & Texture
legacy module/Triaging
legacy module/User Interface
legacy module/VFX & Video
legacy project/1.0.0-beta.2
legacy project/Asset Browser (Archived)
legacy project/BF Blender: 2.8
legacy project/BF Blender: After Release
legacy project/BF Blender: Next
legacy project/BF Blender: Regressions
legacy project/BF Blender: Unconfirmed
legacy project/Blender 2.70
legacy project/Code Quest
legacy project/Datablocks and Libraries
legacy project/Eevee
legacy project/Game Animation
legacy project/Game Audio
legacy project/Game Data Conversion
legacy project/Game Engine
legacy project/Game Logic
legacy project/Game Physics
legacy project/Game Python
legacy project/Game Rendering
legacy project/Game UI
legacy project/GPU / Viewport
legacy project/GSoC
legacy project/Infrastructure: Websites
legacy project/LibOverrides - Usability and UX
legacy project/Milestone 1: Basic, Local Asset Browser
legacy project/Nodes
legacy project/OpenGL Error
legacy project/Papercut
legacy project/Pose Library Basics
legacy project/Retrospective
legacy project/Tracker Curfew
legacy project/Wintab High Frequency
Meta/Good First Issue
Meta/Papercut
migration/requires-manual-verification
Module › Animation & Rigging
Module › Core
Module › Development Management
Module › Eevee & Viewport
Module › Grease Pencil
Module › Modeling
Module › Nodes & Physics
Module › Pipeline, Assets & IO
Module › Platforms, Builds, Tests & Devices
Module › Python API
Module › Render & Cycles
Module › Sculpt, Paint & Texture
Module › Triaging
Module › User Interface
Module › VFX & Video
Platform/FreeBSD
Platform/Linux
Platform/macOS
Platform/Windows
Priority › High
Priority › Low
Priority › Normal
Priority › Unbreak Now!
Status › Archived
Status › Confirmed
Status › Duplicate
Status › Needs Information from Developers
Status › Needs Information from User
Status › Needs Triage
Status › Resolved
Type › Bug
Type › Design
Type › Known Issue
Type › Patch
Type › Report
Type › To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#66707
Loading…
There is no content yet.