Strange drag-drop when opening an image from the shader editor and the open dialog is in thumbnail mode #67756

Closed
opened 4 years ago by erik85 · 21 comments
erik85 commented 4 years ago
Collaborator

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.35

Blender Version
Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-26 15:34, hash: 79ce2054d4
Worked: (optional)

Short description of error
Blender starts a drag-drop-operation in the "open file"-dialog when I want to open a texture in an Image node in the Shader Editor

Exact steps for others to reproduce the error
Create a shader and an image node. Click "Open Image". Go to a directory with many textures and go to "Thumbnail mode". It's easiest to reproduce if the thumbnails completely fill up the window. Open one of the images. Now click open again, and if the open button in the image node is at the same place as a thumbnail in the open dialog then it will start a drag-drop-action immediately.

bild.png

bild.png

**System Information** Operating system: Windows-10-10.0.17134 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.35 **Blender Version** Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-26 15:34, hash: `79ce2054d4` Worked: (optional) **Short description of error** Blender starts a drag-drop-operation in the "open file"-dialog when I want to open a texture in an Image node in the Shader Editor **Exact steps for others to reproduce the error** Create a shader and an image node. Click "Open Image". Go to a directory with many textures and go to "Thumbnail mode". It's easiest to reproduce if the thumbnails completely fill up the window. Open one of the images. Now click open again, and if the open button in the image node is at the same place as a thumbnail in the open dialog then it will start a drag-drop-action immediately. ![bild.png](https://archive.blender.org/developer/F7630175/bild.png) ![bild.png](https://archive.blender.org/developer/F7630179/bild.png)
erik85 commented 4 years ago
Poster
Collaborator

Added subscriber: @erik85

Added subscriber: @erik85
Collaborator

#68362 was marked as duplicate of this issue

#68362 was marked as duplicate of this issue
Collaborator

#69094 was marked as duplicate of this issue

#69094 was marked as duplicate of this issue

Added subscriber: @SpectreFirst

Added subscriber: @SpectreFirst

I have to say it's a very annoying bug, especially when you have to change textures a lot.

I have to say it's a very annoying bug, especially when you have to change textures a lot.
mano-wii self-assigned this 4 years ago
erik85 commented 4 years ago
Poster
Collaborator

I found that there is a way to avoid it when clicking "Open Image". If you left-click and hold the button, then right-click and hold, then release left and release right.. If that helps in any way to find the problem.

I found that there is a way to avoid it when clicking "Open Image". If you left-click and hold the button, then right-click and hold, then release left and release right.. If that helps in any way to find the problem.
mano-wii removed their assignment 4 years ago
ideasman42 was assigned by mano-wii 4 years ago
Collaborator

Added subscribers: @ideasman42, @mano-wii

Added subscribers: @ideasman42, @mano-wii
Collaborator

@ideasman42, have you worked on drag drop event checks recently?
I suspect the problem is in wm_handlers_do(...) that doesn't uncheck event->check_drag in this case.

@ideasman42, have you worked on drag drop event checks recently? I suspect the problem is in `wm_handlers_do(...)` that doesn't uncheck `event->check_drag` in this case.

Added subscriber: @Dalkoom

Added subscriber: @Dalkoom

To avoid dragging move the mouse immediately after clicking Open Image.

To avoid dragging move the mouse immediately after clicking Open Image.

Added subscriber: @crantisz

Added subscriber: @crantisz

I think this bug should be closed, due new file browser?

I think this bug should be closed, due new file browser?
Collaborator

Added subscriber: @sebastian_k

Added subscriber: @sebastian_k
Collaborator

No, it still happens.
If you render something Blender will now by default open the render result in a new window. If you change from Render Result to any other image in that window, and change the filepath of that image from the N-Panel, the file browser will now open in the same window. And if the file browser is in thumbnail view, the drag/drop thing still happens.
So even though it might not be as obvious as before, the bug is still there.

No, it still happens. If you render something Blender will now by default open the render result in a new window. If you change from Render Result to any other image in that window, and change the filepath of that image from the N-Panel, the file browser will now open in the same window. And if the file browser is in thumbnail view, the drag/drop thing still happens. So even though it might not be as obvious as before, the bug is still there.
AFWS commented 3 years ago

Added subscriber: @AFWS

Added subscriber: @AFWS
AFWS commented 3 years ago

I only had this happen with nodes ,but after the “new” file browser got added, I’m getting this while trying to install matcaps.

I only had this happen with nodes ,but after the “new” file browser got added, I’m getting this while trying to install matcaps.
Collaborator

This issue was referenced by e7476b667e

This issue was referenced by e7476b667e9ea94ae70792a39477472758045fd6
Collaborator

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
JulianEisel closed this issue 3 years ago
Collaborator

Added subscriber: @hfilben

Added subscriber: @hfilben

Added subscriber: @Archost

Added subscriber: @Archost
Collaborator

Added subscriber: @JulianEisel

Added subscriber: @JulianEisel
Sign in to join this conversation.
No Label
Interest/Alembic
Interest/Animation & Rigging
Interest/Asset Browser
Interest/Asset Browser Project Overview
Interest/Audio
Interest/Automated Testing
Interest/Blender Asset Bundle
Interest/Collada
Interest/Compositing
Interest/Core
Interest/Cycles
Interest/Dependency Graph
Interest/Development Management
Interest/Eevee & Viewport
Interest/Freestyle
Interest/Geometry Nodes
Interest/Grease Pencil
Interest/ID Management
Interest/Images & Movies
Interest/Import/Export
Interest/Line Art
Interest/Masking
Interest/Modeling
Interest/Modifiers
Interest/Motion Tracking
Interest/Nodes & Physics
Interest/Overrides
Interest/Performance
Interest/Performance
Interest/Physics
Interest/Pipeline, Assets & I/O
Interest/Platforms, Builds, Tests & Devices
Interest/Python API
Interest/Render & Cycles
Interest/Render Pipeline
Interest/Sculpt, Paint & Texture
Interest/Text Editor
Interest/Translations
Interest/Triaging
Interest/Undo
Interest/USD
Interest/User Interface
Interest/UV Editing
Interest/VFX & Video
Interest/Video Sequencer
Interest/Virtual Reality
legacy module/Animation & Rigging
legacy module/Core
legacy module/Development Management
legacy module/Eevee & Viewport
legacy module/Grease Pencil
legacy module/Modeling
legacy module/Nodes & Physics
legacy module/Pipeline, Assets & IO
legacy module/Platforms, Builds, Tests & Devices
legacy module/Python API
legacy module/Rendering & Cycles
legacy module/Sculpt, Paint & Texture
legacy module/Triaging
legacy module/User Interface
legacy module/VFX & Video
legacy project/1.0.0-beta.2
legacy project/Asset Browser (Archived)
legacy project/BF Blender: 2.8
legacy project/BF Blender: After Release
legacy project/BF Blender: Next
legacy project/BF Blender: Regressions
legacy project/BF Blender: Unconfirmed
legacy project/Blender 2.70
legacy project/Code Quest
legacy project/Datablocks and Libraries
legacy project/Eevee
legacy project/Game Animation
legacy project/Game Audio
legacy project/Game Data Conversion
legacy project/Game Engine
legacy project/Game Logic
legacy project/Game Physics
legacy project/Game Python
legacy project/Game Rendering
legacy project/Game UI
legacy project/GPU / Viewport
legacy project/GSoC
legacy project/Infrastructure: Websites
legacy project/LibOverrides - Usability and UX
legacy project/Milestone 1: Basic, Local Asset Browser
legacy project/Nodes
legacy project/OpenGL Error
legacy project/Papercut
legacy project/Pose Library Basics
legacy project/Retrospective
legacy project/Tracker Curfew
legacy project/Wintab High Frequency
Meta/Good First Issue
Meta/Papercut
migration/requires-manual-verification
Module › Animation & Rigging
Module › Core
Module › Development Management
Module › Eevee & Viewport
Module › Grease Pencil
Module › Modeling
Module › Nodes & Physics
Module › Pipeline, Assets & IO
Module › Platforms, Builds, Tests & Devices
Module › Python API
Module › Render & Cycles
Module › Sculpt, Paint & Texture
Module › Triaging
Module › User Interface
Module › VFX & Video
Platform/FreeBSD
Platform/Linux
Platform/macOS
Platform/Windows
Priority › High
Priority › Low
Priority › Normal
Priority › Unbreak Now!
Status › Archived
Status › Confirmed
Status › Duplicate
Status › Needs Information from Developers
Status › Needs Information from User
Status › Needs Triage
Status › Resolved
Type › Bug
Type › Design
Type › Known Issue
Type › Patch
Type › Report
Type › To Do
No Milestone
No project
No Assignees
10 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#67756
Loading…
There is no content yet.