texture opacity slider in texture paint mode not working #69172

Closed
opened 4 years ago by gabbitt · 8 comments

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.67

Blender Version
Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: f6cb5f5449
Worked: (optional)

Short description of error
the texture opacity slider when in texture paint mode does not seem to work any more in fact it just does nothing

**System Information** Operating system: Windows-10-10.0.17763 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.67 **Blender Version** Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: `f6cb5f5449` Worked: (optional) **Short description of error** the texture opacity slider when in texture paint mode does not seem to work any more in fact it just does nothing
Poster

Added subscriber: @gabbitt

Added subscriber: @gabbitt
xrg commented 4 years ago

Added subscriber: @xrg

Added subscriber: @xrg
xrg commented 4 years ago

It seems to only work with the Mask Brush texture. If that is deliberate, the overlay slider maybe should be renamed.

It seems to only work with the Mask Brush texture. If that is deliberate, the overlay slider maybe should be renamed.
YAFU commented 4 years ago

Added subscriber: @YAFU

Added subscriber: @YAFU
YAFU commented 4 years ago

Hi
It is intentional change and it has been renamed to Stencil Opacity in master/buildbot/2.81

Hi It is intentional change and it has been renamed to Stencil Opacity in master/buildbot/2.81
Collaborator

Added subscribers: @WilliamReynish, @lichtwerk

Added subscribers: @WilliamReynish, @lichtwerk
Collaborator

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
lichtwerk closed this issue 4 years ago
lichtwerk self-assigned this 4 years ago
Collaborator

Afaict, this affects the Mask/Stencil layer (and that seems to be working fine).

However, I am not quite following the naming here (seems a bit inconsistent), in code we are using use_stencil_layer, the image is the Stencil Image, the Overlay option is displayed as Stencil Opacity, however you enable the whole thing with Mask... seems a bit off. Why not do the following?
P1085: #69172 snippet



diff --git a/release/scripts/startup/bl_ui/space_view3d_toolbar.py b/release/scripts/startup/bl_ui/space_view3d_toolbar.py
index 9fd35808b4b..0fb0a9e5542 100644
--- a/release/scripts/startup/bl_ui/space_view3d_toolbar.py
+++ b/release/scripts/startup/bl_ui/space_view3d_toolbar.py
@@ -701,7 +701,7 @@ class VIEW3D_PT_slots_projectpaint(View3DPanel, Panel):
 class VIEW3D_PT_stencil_projectpaint(View3DPanel, Panel):
     bl_category = "Tool"
     bl_context = ".imagepaint"  # dot on purpose (access from topbar)
-    bl_label = "Mask"
+    bl_label = "Stencil"
     bl_options = {'DEFAULT_CLOSED'}
 
     @classmethod

That being said, this is not really a bug, (if at all could be a nice improvement for consistency?)
So, will close this as not-a-bug, but maybe there is a reaction from the UI team (could still commit this then...)?
@gabbitt : feel free to comment again if this is a misunderstanding on my side...
CC @WilliamReynish

Afaict, this affects the `Mask`/`Stencil` layer (and that seems to be working fine). However, I am not quite following the naming here (seems a bit inconsistent), in code we are using `use_stencil_layer`, the image is the `Stencil Image`, the Overlay option is displayed as `Stencil Opacity`, however you enable the whole thing with `Mask`... seems a bit off. Why not do the following? [P1085: #69172 snippet](https://archive.blender.org/developer/P1085.txt) ``` diff --git a/release/scripts/startup/bl_ui/space_view3d_toolbar.py b/release/scripts/startup/bl_ui/space_view3d_toolbar.py index 9fd35808b4b..0fb0a9e5542 100644 --- a/release/scripts/startup/bl_ui/space_view3d_toolbar.py +++ b/release/scripts/startup/bl_ui/space_view3d_toolbar.py @@ -701,7 +701,7 @@ class VIEW3D_PT_slots_projectpaint(View3DPanel, Panel): class VIEW3D_PT_stencil_projectpaint(View3DPanel, Panel): bl_category = "Tool" bl_context = ".imagepaint" # dot on purpose (access from topbar) - bl_label = "Mask" + bl_label = "Stencil" bl_options = {'DEFAULT_CLOSED'} @classmethod ``` That being said, this is not really a bug, (if at all could be a nice improvement for consistency?) So, will close this as not-a-bug, but maybe there is a reaction from the UI team (could still commit this then...)? @gabbitt : feel free to comment again if this is a misunderstanding on my side... CC @WilliamReynish
Sign in to join this conversation.
No Label
Interest/Alembic
Interest/Animation & Rigging
Interest/Asset Browser
Interest/Asset Browser Project Overview
Interest/Audio
Interest/Automated Testing
Interest/Blender Asset Bundle
Interest/Collada
Interest/Compositing
Interest/Core
Interest/Cycles
Interest/Dependency Graph
Interest/Development Management
Interest/Eevee & Viewport
Interest/Freestyle
Interest/Geometry Nodes
Interest/Grease Pencil
Interest/ID Management
Interest/Images & Movies
Interest/Import/Export
Interest/Line Art
Interest/Masking
Interest/Modeling
Interest/Modifiers
Interest/Motion Tracking
Interest/Nodes & Physics
Interest/Overrides
Interest/Performance
Interest/Performance
Interest/Physics
Interest/Pipeline, Assets & I/O
Interest/Platforms, Builds, Tests & Devices
Interest/Python API
Interest/Render & Cycles
Interest/Render Pipeline
Interest/Sculpt, Paint & Texture
Interest/Text Editor
Interest/Translations
Interest/Triaging
Interest/Undo
Interest/USD
Interest/User Interface
Interest/UV Editing
Interest/VFX & Video
Interest/Video Sequencer
Interest/Virtual Reality
legacy module/Animation & Rigging
legacy module/Core
legacy module/Development Management
legacy module/Eevee & Viewport
legacy module/Grease Pencil
legacy module/Modeling
legacy module/Nodes & Physics
legacy module/Pipeline, Assets & IO
legacy module/Platforms, Builds, Tests & Devices
legacy module/Python API
legacy module/Rendering & Cycles
legacy module/Sculpt, Paint & Texture
legacy module/Triaging
legacy module/User Interface
legacy module/VFX & Video
legacy project/1.0.0-beta.2
legacy project/Asset Browser (Archived)
legacy project/BF Blender: 2.8
legacy project/BF Blender: After Release
legacy project/BF Blender: Next
legacy project/BF Blender: Regressions
legacy project/BF Blender: Unconfirmed
legacy project/Blender 2.70
legacy project/Code Quest
legacy project/Datablocks and Libraries
legacy project/Eevee
legacy project/Game Animation
legacy project/Game Audio
legacy project/Game Data Conversion
legacy project/Game Engine
legacy project/Game Logic
legacy project/Game Physics
legacy project/Game Python
legacy project/Game Rendering
legacy project/Game UI
legacy project/GPU / Viewport
legacy project/GSoC
legacy project/Infrastructure: Websites
legacy project/LibOverrides - Usability and UX
legacy project/Milestone 1: Basic, Local Asset Browser
legacy project/Nodes
legacy project/OpenGL Error
legacy project/Papercut
legacy project/Pose Library Basics
legacy project/Retrospective
legacy project/Tracker Curfew
legacy project/Wintab High Frequency
Meta/Good First Issue
Meta/Papercut
migration/requires-manual-verification
Module › Animation & Rigging
Module › Core
Module › Development Management
Module › Eevee & Viewport
Module › Grease Pencil
Module › Modeling
Module › Nodes & Physics
Module › Pipeline, Assets & IO
Module › Platforms, Builds, Tests & Devices
Module › Python API
Module › Render & Cycles
Module › Sculpt, Paint & Texture
Module › Triaging
Module › User Interface
Module › VFX & Video
Platform/FreeBSD
Platform/Linux
Platform/macOS
Platform/Windows
Priority › High
Priority › Low
Priority › Normal
Priority › Unbreak Now!
Status › Archived
Status › Confirmed
Status › Duplicate
Status › Needs Information from Developers
Status › Needs Information from User
Status › Needs Triage
Status › Resolved
Type › Bug
Type › Design
Type › Known Issue
Type › Patch
Type › Report
Type › To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#69172
Loading…
There is no content yet.