Vertex/Weight Paint: Global undo causes brush & tool settings to be handled along with vertex paint data #70814

Closed
opened 2019-10-14 17:20:57 +02:00 by Stanislav Blinov · 19 comments

Blender Version
Broken: blender-2.81-95f020c853d6
Broken: blender-2.82-bde328352be2

Short description of error
Picking a color to paint with, brush strength and radius, etc., are undone if the brush stroke following these changes is undone.

Exact steps for others to reproduce the error

  1. Create a new scene.
  2. Select the cube and enter vertex paint mode.
  3. Pick a different color.
  4. Perform one stroke (i.e. click).
  5. Undo.

Expected: stroke is undone, new color selection remains.
Current: stroke is undone, color selection is also undone.

**Blender Version** Broken: blender-2.81-95f020c853d6 Broken: blender-2.82-bde328352be2 **Short description of error** Picking a color to paint with, brush strength and radius, etc., are undone if the brush stroke following these changes is undone. **Exact steps for others to reproduce the error** 1. Create a new scene. 2. Select the cube and enter vertex paint mode. 3. Pick a different color. 4. Perform one stroke (i.e. click). 5. Undo. Expected: stroke is undone, new color selection remains. Current: stroke is undone, color selection is also undone.

Added subscriber: @Stan_Pancakes

Added subscriber: @Stan_Pancakes

Added subscriber: @ideasman42

Added subscriber: @ideasman42

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Campbell Barton self-assigned this 2019-10-15 01:37:26 +02:00

Currently vertex/weight paint undo manages all data including brushes.

While we could support moving some settings outside of undo that's a feature request.

Closing.

Currently vertex/weight paint undo manages all data including brushes. While we could support moving some settings outside of undo that's a feature request. Closing.

A bug in the design is still a bug. The behavior is unexpected, moreover it's inconsistent across Blender's paint modes:

  • in texture paint, undoing a stroke does not undo preceding color selection
  • in sculpt mode, undoing a stroke does not undo preceding strength selection
  • in vertex color paint, undoing a stroke undoes preceding color selection
  • in weight paint, undoing a stroke undoes preceding weight selection

Why should this even need a feature request?

A bug in the design is still a bug. The behavior is unexpected, moreover it's inconsistent across Blender's paint modes: - in texture paint, undoing a stroke does *not* undo preceding color selection - in sculpt mode, undoing a stroke does *not* undo preceding strength selection - in vertex color paint, undoing a stroke *undoes* preceding color selection - in weight paint, undoing a stroke *undoes* preceding weight selection Why should this even need a feature request?

Added subscriber: @WilliamReynish

Added subscriber: @WilliamReynish

Changed status from 'Archived' to: 'Confirmed'

Changed status from 'Archived' to: 'Confirmed'

I could reproduce the issue.

I am re-opening this. IMO this is very clearly a bug - in this case one undo action goes back two steps.

Maybe it's not trivial to fix, but it's still a bug.

I could reproduce the issue. I am re-opening this. IMO this is very clearly a bug - in this case one undo action goes back two steps. Maybe it's not trivial to fix, but it's still a bug.

Perhaps it could be worded differently, I'll edit the title and description.

Perhaps it could be worded differently, I'll edit the title and description.
Stanislav Blinov changed title from Vertex Paint color selection doesn't create undo step to Vertex Paint: undoing paint stroke also undoes preceding tool changes 2020-01-28 22:34:59 +01:00
Campbell Barton changed title from Vertex Paint: undoing paint stroke also undoes preceding tool changes to Vertex/Weight Paint: Global undo causes brush & tool settings to be handled along with vertex paint data 2020-01-28 23:45:20 +01:00

Marking as TODO in the sculpt paint module, since this is working as intended (since undo was initially supported I would guess), even if it arguably should work differently.

Marking as TODO in the sculpt paint module, since this is working as intended *(since undo was initially supported I would guess)*, even if it arguably should work differently.
Member

Added subscriber: @DanielGrauer

Added subscriber: @DanielGrauer

Added subscriber: @Leul

Added subscriber: @Leul

This bug is really annoying, is there no hope for it..?

This bug is really annoying, is there no hope for it..?
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Note #69760 (Undo/Adjust Last Operation: vertex and weightpaint operators/strokes undo more then they should (change back any setting changed prior to execution)) is related (though that one is for operators)

Note #69760 (Undo/Adjust Last Operation: vertex and weightpaint operators/strokes undo more then they should (change back any setting changed prior to execution)) is related (though that one is for operators)

Added subscriber: @pwcb

Added subscriber: @pwcb

This effects everything from the vertex group you have selected, to all brush settings. So you'll switch the bone you want to paint for, change the brush size and weight, make a mark and undo it, and all these settings will be undone. Extremely annoying.

I'm guessing someone saw how Photoshop will lump any layer setting changes in with the next brushstroke you make as a single undo and thought this was a feature, when it's something everyone complains about. I can't think of any other reasoning that would make this seem appealing.

This effects everything from the vertex group you have selected, to all brush settings. So you'll switch the bone you want to paint for, change the brush size and weight, make a mark and undo it, and all these settings will be undone. Extremely annoying. I'm guessing someone saw how Photoshop will lump any layer setting changes in with the next brushstroke you make as a single undo and thought this was a feature, when it's something everyone complains about. I can't think of any other reasoning that would make this seem appealing.

am hoping D7518 will solve this

am hoping [D7518](https://archive.blender.org/developer/D7518) will solve this

Closed as duplicate of #71759

Closed as duplicate of #71759
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#70814
No description provided.