Adjust last operation: can't reset properties to default value #71472

New Issue

Stanislav Blinov · 2019-11-10T13:27:59+01:00

Stanislav Blinov commented

2019-11-10 13:27:59 +01:00

Blender Version
Broken: 2.8x

Short description of error
In the Adjust Last Operation panel, the context menu for any property has the Reset to Default Value options disabled, although they are enabled in the operator panel.

Exact steps for others to reproduce the error

Load the default scene
Enter edit mode on the cube
Bevel an edge
Expand the operator panel in the bottom left
Right click any property, note that Reset to Default Value option is enabled and works
Go Edit -> Adjust Last Operation
Right click the same property in that panel, note that Reset to Default Value option is disabled

**Blender Version** Broken: 2.8x **Short description of error** In the Adjust Last Operation panel, the context menu for any property has the Reset to Default Value options disabled, although they are enabled in the operator panel. **Exact steps for others to reproduce the error** 1. Load the default scene 2. Enter edit mode on the cube 3. Bevel an edge 4. Expand the operator panel in the bottom left 5. Right click any property, note that Reset to Default Value option is enabled and works 6. Go Edit -> Adjust Last Operation 7. Right click the same property in that panel, note that Reset to Default Value option is disabled

Stanislav Blinov commented

2019-11-10 13:27:59 +01:00

Added subscriber: @Stan_Pancakes

blender-admin commented

2019-11-10 13:27:59 +01:00

#86079 was marked as duplicate of this issue

blender-admin commented

2019-11-10 13:27:59 +01:00

#71727 was marked as duplicate of this issue

Philipp Oeser commented

2019-11-11 12:52:27 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-11-11 12:52:27 +01:00

Can confirm this one also.

Note #71470 is very related [even though in this case -- opposed to #71470 -- it doesnt work well when called via F9 either...]

Can confirm this one also. Note #71470 is very related [even though in this case -- opposed to #71470 -- it doesnt work well when called via F9 either...]

Jacques Lucke commented

2020-01-22 15:45:59 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2020-01-22 15:45:59 +01:00

The poll function of the "Reset to Default Value" operator fails in the popup menu.
This is because it cannot find the active uiBut.
This is because CTX_wm_region(C) does not return the region of the currently open menu popup in ui_context_rna_button_active.

A quick hack to make this particular case work is to replace the function with:

static uiBut *ui_context_rna_button_active(const bContext *C)
{
  bScreen *screen = CTX_wm_screen(C);
  if (screen && screen->regionbase.first) {
    return ui_context_button_active(screen->regionbase.first, ui_context_rna_button_active_test);
  }
  return ui_context_button_active(CTX_wm_region(C), ui_context_rna_button_active_test);
}

This breaks other cases though. I assume the real fix would have to make sure that CTX_wm_region(C) actually returns the popup region, don't know for sure.

The `poll` function of the "Reset to Default Value" operator fails in the popup menu. This is because it cannot find the active `uiBut`. This is because `CTX_wm_region(C)` does not return the region of the currently open menu popup in `ui_context_rna_button_active`. A quick hack to make this particular case work is to replace the function with: ``` static uiBut *ui_context_rna_button_active(const bContext *C) { bScreen *screen = CTX_wm_screen(C); if (screen && screen->regionbase.first) { return ui_context_button_active(screen->regionbase.first, ui_context_rna_button_active_test); } return ui_context_button_active(CTX_wm_region(C), ui_context_rna_button_active_test); } ``` This breaks other cases though. I assume the real fix would have to make sure that `CTX_wm_region(C)` actually returns the popup region, don't know for sure.

Julian Eisel commented

2020-01-22 16:13:53 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2020-01-22 16:13:53 +01:00

The preferable way to achieve this is using CTX_wm_menu(), it returns the menu region if there is one. If it returns NULL, the current CTX_wm_region() can be used.

However I don't know if this change is safe to do, after all this is called from many different places.

The preferable way to achieve this is using `CTX_wm_menu()`, it returns the menu region if there is one. If it returns `NULL`, the current `CTX_wm_region()` can be used. However I don't know if this change is safe to do, after all this is called from many different places.

Julian Eisel commented

2020-01-23 11:54:56 +01:00

Added subscribers: @ChristopherAnderssarian, @WilliamReynish, @dr.sybren, @mano-wii