Undo doesn't consider changes in nodetree when object is in edit and texture paint mode #71895
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
12 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#71895
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.48
Blender Version
Broken: version: 2.79-3.4
For reference: this is due to this commit
4a08b974f4From the commit message:
"don't store undo steps for property changes in paint & edit modes."
Short description of error
When in edit and texture paint mode, I can't undo changes, that I made in the shader editor.
Exact steps for others to reproduce the error
The verts move back, but the node setting remains.
#71895-undo-not-undoing-shader-nodes.blend
Added subscriber: @heini
#101385 was marked as duplicate of this issue
#100994 was marked as duplicate of this issue
#100473 was marked as duplicate of this issue
#99922 was marked as duplicate of this issue
#98990 was marked as duplicate of this issue
#93135 was marked as duplicate of this issue
#69520 was marked as duplicate of this issue
Added subscriber: @mano-wii
I can confirm.
In blender 2.79 it didn't work either.
Probably related to #63367
Added subscribers: @ideasman42, @dr.sybren
I'm setting this to Known Issue, as it's been in Blender for a while and I don't know when it'll be fixed. @ideasman42 maybe you can assess this better?
Added subscribers: @RobbieK, @brecht
Added subscriber: @blenderrocket
Added subscribers: @bird_d, @PratikPB2123
Added subscriber: @Pablo_Caracena
Added subscriber: @georgK
Added subscriber: @Masaru641
Added subscriber: @shmuel
Undo doesn't consider changes in nodetree when object is in edit modeto Undo doesn't consider changes in nodetree when object is in edit and texture paint modecan we change the Exact steps 2 to enter edit mode, because the issue still occurs when no vertices are moved.
as well the nodes do revert to the state they where in before you entered edit mode after you press ctrl z the number of times of actions your did from when you entered edit mode
Added subscribers: @imlegr, @OmarEmaraDev
Added subscribers: @MiroHorvath, @mod_moder
Added subscriber: @Zcyber
For reference: this is due to this commit
4a08b974f4From the commit message:
"don't store undo steps for property changes in paint & edit modes."
One possible solution is to not ignore every property change (but just the ones for brushes/toolsettings -- I think this would fit the original intention better). Or alternatively, certain properties could be flagged to ignore Undo (if we need finer control over this behavior).
Re original report: Philipp's findings are correct as far as I understand.
But I think this task is a bit mix of reports.
For example: We've merged #101385 which is different than the original report.
In case of #101385, undo step is created (because operations are executed, not the settings) but the step_size is 0 (i.e. no data is stored in undo step).
We may need a separate report to handle issue mentioned in #101385 / #100473