Refactor AOV writing in Cycles kernel #72293

Open
opened 2019-12-09 11:33:14 +01:00 by Brecht Van Lommel · 2 comments

After the addition of custom and light group AOVs in D3607, kernel_accumulate immediately clamping, and also writes light groups directly to the render buffer. The code here could be refactored further to work like this and simplify and hopefully optimize the kernel.

All light passes (except perhaps combined) could be written directly to the render buffer, rather than stored intermediately in PathRadiance. This would reduce kernel memory usage and data copying on the GPU, at the cost of more atomic writes. For CPU rendering without atomics this is likely a clear win, for the GPU it will have to be tested, but intermediate copies it does now are not cheap either.

As a second step, a state machine could be added that is updated on every light bounce. Each state would have a list of active AOVs to write too. This state machine would be created on the CPU side, and initially would just be for built-in AOVs and light groups, but could support light path expressions in the future too.

Further, we have a number of builtin non-light AOVs. These could be implemented as part of shader execution like custom AOVs, to simplify the kernel side code. This would be like a set of shading nodes that is automatically executed after all shaders. For users it would even be useful if they could specify a shader node group like that in the view layer, to write custom AOVs for all materials without having to add AOV output nodes for each material.

For features like adaptive sampling, we could also use an easy way to loop over all AOVs to rescale them in the kernel, right now it's hardcoded.

After the addition of custom and light group AOVs in [D3607](https://archive.blender.org/developer/D3607), `kernel_accumulate` immediately clamping, and also writes light groups directly to the render buffer. The code here could be refactored further to work like this and simplify and hopefully optimize the kernel. All light passes (except perhaps combined) could be written directly to the render buffer, rather than stored intermediately in `PathRadiance`. This would reduce kernel memory usage and data copying on the GPU, at the cost of more atomic writes. For CPU rendering without atomics this is likely a clear win, for the GPU it will have to be tested, but intermediate copies it does now are not cheap either. As a second step, a state machine could be added that is updated on every light bounce. Each state would have a list of active AOVs to write too. This state machine would be created on the CPU side, and initially would just be for built-in AOVs and light groups, but could support light path expressions in the future too. Further, we have a number of builtin non-light AOVs. These could be implemented as part of shader execution like custom AOVs, to simplify the kernel side code. This would be like a set of shading nodes that is automatically executed after all shaders. For users it would even be useful if they could specify a shader node group like that in the view layer, to write custom AOVs for all materials without having to add AOV output nodes for each material. For features like adaptive sampling, we could also use an easy way to loop over all AOVs to rescale them in the kernel, right now it's hardcoded.
Author
Owner

Added subscriber: @brecht

Added subscriber: @brecht
Brecht Van Lommel changed title from Refactor light AOV writing in Cycles kernel to Refactor AOV writing in Cycles kernel 2019-12-10 19:15:57 +01:00

Added subscriber: @Garek

Added subscriber: @Garek
Brecht Van Lommel added this to the Render & Cycles project 2023-02-07 19:08:06 +01:00
Philipp Oeser removed the
Interest
Render & Cycles
label 2023-02-09 14:01:32 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#72293
No description provided.