[WIP] Design: Painting Color Management #72424

New Issue

Jeroen Bakker · 2019-12-13T16:28:33+01:00

Jeroen Bakker commented

2019-12-13 16:28:33 +01:00

This design are based on the next principles:

When mixing colors, do it always in the linear scene reference space. For Blender that is linear REC709.
Include the color space when storing colors for color picker and don't convert it the color channels.

Issues

Current issues we try to solve:

#68242 (Color space seems wrong while painting in image editor.)
Color picker stores in sRGB or linear REC709. the storage is defined by the RNA (COLOR, COLOR_GAMMA). Since blender 2.80 the default color picker is set to HSV, what has some usability issues (HSV has multiple values that represents the same black in sRGB and linear REC709). User notice this when they set Value to 0, that the next time they open the color picker that the HUE and Saturation are also set to 0.

Scoping

The solution is focused on Sculpt/Paint brushes, but will be reusable in other areas. The solution is designed on single colors. ImBuf should be used when working with buffers. Changes to ImBuf are not in scope.

Proposal

Proposal is to implement a framework for color picking and mixing colors. To test the framework we include the first implementation in the Paint and Sculpt Brushes. The idea of this approach is to be more explicit when colors are being used.

DNA

In DNA_color_types.h add a struct that can store a color and relevant information of the color.

typedef struct Color_RUNTIME_Color {
    float color_straight_alpha[4];
    float color_premult_alpha[4];
} Color_RUNTIME_Color;

typedef struct Color_RUNTIME {
    /* flag contains the validity of the other fields */
    int flag;
    Color_RUNTIME_Color linear_scene;
    Color_RUNTIME_Color display;

    ...

} Color_RUNTIME;

typedef struct Color3 {
    float components[3];
    float alpha;
    ColorManagedColorspaceSettings color_space;
    Color_RUNTIME runtime;
} Color3;

Color3.alpha is always stored as straight alpha.
The runtime caches common conversions of the color in different OpenColorIO roles and alpha association. The Color3.runtime field will be flagged to be invalid when the scene color management is changed or a different scene is loaded. The runtime is also updated when the color management roles in the scene are changed, a another scene is loaded.

In DNA_brush_types.h deprecate the rgb and alpha and add a new field Color3 color;.

BKE

Add functions in BKE_colortools.h for getting the values for a color in a specific OCIO Role, invalidate all runtime fields in loaded data, invalidate one runtime field.

UI

Update the color picker template to support this data structure. This also means that we don't do the pixel read to find the selected color, but interpret the screen coordinate on the wheel to find our what color has been picked.

Painting/Brushes

When doing this change a lot of compile errors needs to be fixed. This gives us the opportunity to migrate them to the new implementation and make sure we tackle these cases. Textures still needs special attention.

OCIO

The color configuration needs to be adjusted with color spaces for the color picker role.

This design are based on the next principles: * When mixing colors, do it always in the linear scene reference space. For Blender that is linear REC709. * Include the color space when storing colors for color picker and don't convert it the color channels. **Issues** Current issues we try to solve: * #68242 (Color space seems wrong while painting in image editor.) * Color picker stores in sRGB or linear REC709. the storage is defined by the RNA (COLOR, COLOR_GAMMA). Since blender 2.80 the default color picker is set to HSV, what has some usability issues (HSV has multiple values that represents the same black in sRGB and linear REC709). User notice this when they set `Value` to 0, that the next time they open the color picker that the `HUE` and `Saturation` are also set to 0. **Scoping** The solution is focused on Sculpt/Paint brushes, but will be reusable in other areas. The solution is designed on single colors. `ImBuf` should be used when working with buffers. Changes to `ImBuf` are not in scope. **Proposal** Proposal is to implement a framework for color picking and mixing colors. To test the framework we include the first implementation in the Paint and Sculpt Brushes. The idea of this approach is to be more explicit when colors are being used. __DNA__ In `DNA_color_types.h` add a struct that can store a color and relevant information of the color. ``` typedef struct Color_RUNTIME_Color { float color_straight_alpha[4]; float color_premult_alpha[4]; } Color_RUNTIME_Color; typedef struct Color_RUNTIME { /* flag contains the validity of the other fields */ int flag; Color_RUNTIME_Color linear_scene; Color_RUNTIME_Color display; ... } Color_RUNTIME; typedef struct Color3 { float components[3]; float alpha; ColorManagedColorspaceSettings color_space; Color_RUNTIME runtime; } Color3; ``` `Color3.alpha` is always stored as straight alpha. The runtime caches common conversions of the color in different OpenColorIO roles and alpha association. The `Color3.runtime` field will be flagged to be invalid when the scene color management is changed or a different scene is loaded. The runtime is also updated when the color management roles in the scene are changed, a another scene is loaded. In `DNA_brush_types.h` deprecate the `rgb` and `alpha` and add a new field `Color3 color;`. __BKE__ Add functions in `BKE_colortools.h` for getting the values for a color in a specific OCIO Role, invalidate all `runtime` fields in loaded data, invalidate one `runtime` field. __UI__ Update the color picker template to support this data structure. This also means that we don't do the pixel read to find the selected color, but interpret the screen coordinate on the wheel to find our what color has been picked. __Painting/Brushes__ When doing this change a lot of compile errors needs to be fixed. This gives us the opportunity to migrate them to the new implementation and make sure we tackle these cases. Textures still needs special attention. __OCIO__ The color configuration needs to be adjusted with color spaces for the color picker role.

Jeroen Bakker self-assigned this 2019-12-13 16:28:33 +01:00

Jeroen Bakker commented

2019-12-13 16:28:33 +01:00

Added subscriber: @Jeroen-Bakker

Pablo Dobarro commented

2019-12-13 16:56:29 +01:00

Added subscriber: @PabloDobarro

Evan Wilson commented

2019-12-13 22:03:13 +01:00

Added subscriber: @EAW

Jeroen Bakker changed title from ~~Design: Painting Color Management~~ to [WIP] Design: Painting Color Management

2019-12-15 15:16:58 +01:00

Sam Van Hulle commented

2019-12-15 22:15:10 +01:00

Added subscriber: @frameshift

Sam Van Hulle commented

2019-12-15 22:26:05 +01:00

Looking good as far as I can tell. A few things:

When mixing colors, do it always in the linear scene reference space. For Blender that is linear REC709.

As Troy pointed out in Blender.chat, please get rid of any assumptions like this, anywhere. I don't think you'd find it unlikely that I can show you an instance of Blender with a reference space that's not even close to Rec. 709 ;)

Include the color space when storing colors for color picker

Is this necessary once Blender completely relies on OCIO roles?

Looking good as far as I can tell. A few things: > When mixing colors, do it always in the linear scene reference space. For Blender that is linear REC709. As Troy pointed out in Blender.chat, please get rid of any assumptions like this, anywhere. I don't think you'd find it unlikely that I can show you an instance of Blender with a reference space that's not even close to Rec. 709 ;) > Include the color space when storing colors for color picker Is this necessary once Blender completely relies on OCIO roles?

Jeroen Bakker commented

2019-12-16 08:32:45 +01:00

I will, I do want to re-validate other things in this patch.

There are several likely user stories that storing ocio roles doesn't address:

Open Blender, select different color picker role, all colors will change.
Blender has multiple color picker modes where the color space is fixed to sRGB or linear pending on what property you are working with.

From a user perspective this could also be implemented by using a color space that is able to restore the components of the different modes. But does such a color space exist? If so yes we can use a color role for storing; if not we might want to store the color space itself as proposed or another solution we can come up with.

When back in office I will update the design on this topic.

I will, I do want to re-validate other things in this patch. There are several likely user stories that storing ocio roles doesn't address: * Open Blender, select different color picker role, all colors will change. * Blender has multiple color picker modes where the color space is fixed to sRGB or linear pending on what property you are working with. From a user perspective this could also be implemented by using a color space that is able to restore the components of the different modes. But does such a color space exist? If so yes we can use a color role for storing; if not we might want to store the color space itself as proposed or another solution we can come up with. When back in office I will update the design on this topic.

Sam Van Hulle commented

2020-06-10 20:42:45 +02:00

I just reported #77736, totally forgot about this design task.
I would however like to stress that it's necessary for the colour picker to allow the user to choose between a display space and the scene linear space when colour picking. In any context. Shader nodes, texture painting, vertex colours, you name it.
Internally, always consider the scene linear values, but expose the alternative in the UI.

@Jeroen-Bakker any news on this?

I just reported #77736, totally forgot about this design task. I would however like to stress that it's necessary for the colour picker to *allow the user to choose* between **a** display space and **the** scene linear space when colour picking. *In any context.* Shader nodes, texture painting, vertex colours, you name it. Internally, always consider the scene linear values, but expose the alternative in the UI. @Jeroen-Bakker any news on this?

Ahmed Jarad commented

2022-08-18 16:55:42 +02:00

Added subscriber: @end_ahmed

Julien Kaspar added this to the Sculpt, Paint & Texture project 2023-02-08 10:26:20 +01:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

[WIP] Design: Painting Color Management #72424