Library Override: Support editing of animation data in overriden data-blocks. #72629

New Issue

Luc Revardel · 2019-12-21T19:11:51+01:00

Luc Revardel commented

2019-12-21 19:11:51 +01:00

A complete support of anim data edition in library overrides data-blocks is a rather complex and heavy task. Here is a proposed split of it into milestones. Please note that not all of those milestones will get a defined release targets yet.

Milestone 0 - Already in master

Add or replace the active action of an override data-block.

Milestone 1 - Minimal Viable Product - 2.92

Support adding new NLA tracks to overrides that already have animdata from their linked reference data-block, and make those new tracks fully editable.
Enable overrides of some properties of existing animdata (like show/hide for NLA strips, tracks, fcurves, settings of drivers?).

Milestone 2 - Potential Extensions - ???
Those will require #82160 (LibOverrides - Refactor how diffing of RNA collections is handled, and extend diffing possibilities.) to be tackled first.

Support editing of existing NLA tracks from the linked reference data-block, including adding/removing/re-ordering existing strips? Not sure how useful that would be in practice though.
Support adding/replacing FCurves in overrides of Actions and/or animdata (for drivers)? Same remarks as above.

Original report

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 980/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 432.00

Blender Version
Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-11-20 14:27, hash: 26bd5ebd42
Worked: (optional)

Short description of error
When animating armature override that contains drivers, actions added to NLA tracks are lost after saving/reloading blender file.

Exact steps for others to reproduce the error
1 - Load testCubeDriverNLA.blend (contains link to cubeRigDrivers.blend)
2 - Use "push down action" from the NLA editor to add current "ArmatureAction" action to a new track

3 - Save the file
4 - Reload the file: the NLA track is lost

Blend files:
testCubeDriverNLA.blend

cubeRigDrivers.blend

A complete support of anim data edition in library overrides data-blocks is a rather complex and heavy task. Here is a proposed split of it into milestones. Please note that not all of those milestones will get a defined release targets yet. **Milestone 0 - Already in master** - [x] Add or replace the active action of an override data-block. **Milestone 1 - Minimal Viable Product - 2.92** - [x] Support **adding** new NLA tracks to overrides that already have animdata from their linked reference data-block, and make those new tracks fully editable. - [x] Enable overrides of some properties of existing animdata (like show/hide for NLA strips, tracks, fcurves, settings of drivers?). **Milestone 2 - Potential Extensions - ???** *Those will require #82160 (LibOverrides - Refactor how diffing of RNA collections is handled, and extend diffing possibilities.) to be tackled first.* - [ ] Support **editing** of existing NLA tracks from the linked reference data-block, including adding/removing/re-ordering existing strips? Not sure how useful that would be in practice though. - [ ] Support adding/replacing FCurves in overrides of Actions and/or animdata (for drivers)? Same remarks as above. -------------------------------- ## Original report **System Information** Operating system: Windows-10-10.0.17763 64 Bits Graphics card: GeForce GTX 980/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 432.00 **Blender Version** Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-11-20 14:27, hash: `26bd5ebd42` Worked: (optional) **Short description of error** When animating armature override *that contains drivers*, actions added to NLA tracks are lost after saving/reloading blender file. **Exact steps for others to reproduce the error** 1 - Load testCubeDriverNLA.blend (contains link to cubeRigDrivers.blend) 2 - Use "push down action" from the NLA editor to add current "ArmatureAction" action to a new track ![CaptureRigDriverNLABug.PNG](https://archive.blender.org/developer/F8239536/CaptureRigDriverNLABug.PNG) 3 - Save the file 4 - Reload the file: the NLA track is lost ![CaptureRigDriverNLABug-lost.PNG](https://archive.blender.org/developer/F8239543/CaptureRigDriverNLABug-lost.PNG) Blend files: [testCubeDriverNLA.blend](https://archive.blender.org/developer/F8239539/testCubeDriverNLA.blend) [cubeRigDrivers.blend](https://archive.blender.org/developer/F8239540/cubeRigDrivers.blend)

Luc Revardel commented

2019-12-21 19:11:51 +01:00

Added subscriber: @lrevardel

blender-admin commented

2019-12-21 19:11:51 +01:00

#84486 was marked as duplicate of this issue

blender-admin commented

2019-12-21 19:11:51 +01:00

#81381 was marked as duplicate of this issue

blender-admin commented

2019-12-21 19:11:51 +01:00

#73141 was marked as duplicate of this issue

blender-admin commented

2019-12-21 19:11:51 +01:00

#74884 was marked as duplicate of this issue

Jacques Lucke commented

2019-12-29 13:07:08 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2019-12-29 13:07:08 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jacques Lucke commented

2019-12-29 13:07:08 +01:00

I can reproduce that.

Bastien Montagne commented

2020-01-15 11:14:49 +01:00

Added subscriber: @mont29

Bastien Montagne self-assigned this 2020-01-15 11:14:49 +01:00

Bastien Montagne commented

2020-01-15 11:14:49 +01:00

This is actually a known issue/TODO, editing an existing animdata of an overridden data-block is not supported/implemented yet.

Linked object with drivers already have an animdata, while linked object without any driver or animation does not have one, so creating one in the override does work.

This is actually a known issue/TODO, **editing** an existing animdata of an overridden data-block is not supported/implemented yet. Linked object with drivers already have an animdata, while linked object without any driver or animation does not have one, so creating one in the override does work.

Bastien Montagne changed title from ~~Library Override: actions added to NLA tracks lost on save/reload (if armature contains drivers)~~ to Library Override: Support editing of animation data in overriden data-blocks.

2020-01-15 11:15:32 +01:00

Emir Sinan Gürlek commented

2020-03-13 20:46:42 +01:00

Added subscriber: @filibis

Gabriel Gomez commented

2020-03-22 11:21:07 +01:00

Added subscriber: @gabrign

Rosalie Mantion commented

2020-05-15 01:27:37 +02:00

Added subscriber: @Rosalie

Bastien Montagne commented

2020-07-15 11:33:15 +02:00

Added subscribers: @V-prime, @mano-wii, @ankitm

Nico Zevallos commented

2020-08-15 02:48:49 +02:00

Added subscriber: @gnastacast

rollin commented

2020-09-15 20:44:00 +02:00

Added subscriber: @rollin

RedMser commented

2020-10-26 19:56:35 +01:00

Added subscriber: @RedMser

Georg K commented

2020-11-12 18:29:29 +01:00

Added subscriber: @georgK

Georg K commented

2020-11-13 11:25:20 +01:00

So if there is no animation added to the source object, it should always be possible to add an animation to the override?
Because while it works in tests, it does not work in my project. I simplified my rig ("Problematic") and built a new version ("Working"). NLA strips can be added to the linked override of the new version and will be retained upon reload, but on the old version, NLA strips are gone upon reload (tested with today's master).
Perhaps you could have a look at my files, I fail to see the difference. If it is supposed to work, I can create a separate report if you like.
NLAOnOverride_dest.blend
NLAOnOverride_source.blend

So if there is no animation added to the source object, it should always be possible to add an animation to the override? Because while it works in tests, it does not work in my project. I simplified my rig ("Problematic") and built a new version ("Working"). NLA strips can be added to the linked override of the new version and will be retained upon reload, but on the old version, NLA strips are gone upon reload (tested with today's master). Perhaps you could have a look at my files, I fail to see the difference. If it is supposed to work, I can create a separate report if you like. [NLAOnOverride_dest.blend](https://archive.blender.org/developer/F9273920/NLAOnOverride_dest.blend) [NLAOnOverride_source.blend](https://archive.blender.org/developer/F9273918/NLAOnOverride_source.blend)

Luc Revardel commented

2020-11-13 14:13:31 +01:00

@georgK I think it's the same issue as this report.
In your _source.blend, there's an empty NLA strip associated to Armature.problematic. This is taking the "animdata" slot when linking&overriding.

Not sure how you ended up with it, but you might want to erase this empty strip using "edit->remove empty animation data" option.

Regards

@georgK I think it's the same issue as this report. In your _source.blend, there's an empty NLA strip associated to Armature.problematic. This is taking the "animdata" slot when linking&overriding. ![image.png](https://archive.blender.org/developer/F9275233/image.png) Not sure how you ended up with it, but you might want to erase this empty strip using "edit->remove empty animation data" option. Regards

Georg K commented

2020-11-13 15:01:04 +01:00

@lrevardel
That's it, thanks a lot!

@lrevardel That's it, thanks a lot!

Bastien Montagne commented

2020-11-24 11:19:16 +01:00

Added subscribers: @Addison, @lichtwerk, @iss, @dfelinto, @WilliamReynish

Bastien Montagne commented

2020-11-25 17:31:10 +01:00

Added subscribers: @MarkSutton, @TodorNikolov

blender-admin commented

2020-12-07 16:58:18 +01:00

This issue was referenced by c0bd240ad0

This issue was referenced by c0bd240ad0a17402db9d2e4799a433b81b62fca8

Robert Guetzkow commented

2021-01-09 12:34:20 +01:00

Added subscribers: @amshiv, @rjg

Lai Yu-Hsuan commented

2021-10-02 02:53:47 +02:00

Added subscriber: @raincole

Lai Yu-Hsuan commented

2021-10-02 02:53:47 +02:00

+1 for this. My workflow is:

Make a character with several basic animations, like walking, jumping, swing the arm. Stash these animations in NLA.
Link it into another .blend and fine tuning there

It kind of works, but I cannot delete the existing stashed actions. I have to make new actions, and they clutters NLA very fast.

+1 for this. My workflow is: 1) Make a character with several basic animations, like walking, jumping, swing the arm. Stash these animations in NLA. 2) Link it into another .blend and fine tuning there It kind of works, but I cannot delete the existing stashed actions. I have to make new actions, and they clutters NLA very fast.

Mark Sutton commented

2021-10-26 13:03:46 +02:00

Just thought I'd add something here as I've been using linked libraries extensively for a project and one of the issues/ difficulties I had was discerning which of the NLA tracks were from the link library, and therefore uneditable, and which were from the current blendfile. Feels like it would be helpful if the track was maybe greyed out, had the chainlink icon or something similar.

mw commented

2022-04-22 10:26:52 +02:00

Added subscriber: @fuchs_und_baer

Yegor commented

2022-12-28 09:36:17 +01:00

Added subscriber: @YegorSmirnov

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Library Override: Support editing of animation data in overriden data-blocks. #72629

Original report