Masking with MultiRes is inconsistent across all subdiv levels by having the mask saved to individual levels and the 0 subdiv level not having a mask at all #76386

Closed
opened 3 years ago by Frozen_Death_Knight · 19 comments

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 980/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.50

Blender Version
Broken: version: 2.90 (sub 0), branch: master, commit date: 2020-04-30 20:00, hash: 03f4d20bcf

Short description of error
Masking is not visible on the level 0 mesh with MultiRes added to the object. Also, the mask is saved on every single subdiv level individually, so if you clear the mask at a lower level the mask will still be there on every level above it (i.e. removing the mask at level 3 will have the mask still present at level 4 and up, etc., etc.).
Desktop 2020.05.03 - 17.25.41.01.mp4

Exact steps for others to reproduce the error

  1. Take a cube and subdivide it.

  2. Go down to level 0 and try to mask the mesh, which will be completely invisible. Then pick any subdiv level above it and mask.

  3. Remove the mask at a lower subdiv above level 0 and then move up one level. The mask should still be there.

  4. Repeat 3) until you reach the highest subdiv level.

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 980/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.50 **Blender Version** Broken: version: 2.90 (sub 0), branch: master, commit date: 2020-04-30 20:00, hash: `03f4d20bcf` **Short description of error** Masking is not visible on the level 0 mesh with MultiRes added to the object. Also, the mask is saved on every single subdiv level individually, so if you clear the mask at a lower level the mask will still be there on every level above it (i.e. removing the mask at level 3 will have the mask still present at level 4 and up, etc., etc.). [Desktop 2020.05.03 - 17.25.41.01.mp4](https://archive.blender.org/developer/F8510031/Desktop_2020.05.03_-_17.25.41.01.mp4) **Exact steps for others to reproduce the error** 1) Take a cube and subdivide it. 2) Go down to level 0 and try to mask the mesh, which will be completely invisible. Then pick any subdiv level above it and mask. 3) Remove the mask at a lower subdiv above level 0 and then move up one level. The mask should still be there. 4) Repeat 3) until you reach the highest subdiv level.

Added subscriber: @Frozen_Death_Knight

Added subscriber: @Frozen_Death_Knight
Collaborator

Added subscriber: @mano-wii

Added subscriber: @mano-wii
Collaborator

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Collaborator

I can confirm that the mask does not propagate in the next subdivision levels.

But I cannot reproduce the problem described in item 2:

  1. Go down to level 0 and try to mask the mesh, which will be completely invisible
I can confirm that the mask does not propagate in the next subdivision levels. But I cannot reproduce the problem described in item 2: > 2. Go down to level 0 and try to mask the mesh, which will be completely invisible

Added subscriber: @KidTempo

Added subscriber: @KidTempo
Sergey commented 3 years ago
Owner

Added subscriber: @Sergey

Added subscriber: @Sergey
Sergey self-assigned this 3 years ago
Sergey commented 3 years ago
Owner

Propagaiton is easiest to be implemented by me.

Level 0 wouldn't be affected by thew propagation. In fact, quite sure mask on level 0 totally separate from mask on multires levels.

Propagaiton is easiest to be implemented by me. Level 0 wouldn't be affected by thew propagation. In fact, quite sure mask on level 0 totally separate from mask on multires levels.
Sergey commented 3 years ago
Owner

This comment was removed by @Sergey

*This comment was removed by @Sergey*
Sergey commented 3 years ago
Owner

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sergey closed this issue 3 years ago
Sergey commented 3 years ago
Owner

Eeeeh, the phabricator didn't put the entire comment. Re-typing the reply again.

So the fix propagation has been committed. Would suggest to test everything again with a newer build. If there are still some issues in there submit them one per report.

For the level 0 I think this was bout drawing mask on multires, then going to level 0 which will not have the mask. This is how the current design work (as I've mentioned before multires and non-multires masks are separate). This is not considered a bug.

Eeeeh, the phabricator didn't put the entire comment. Re-typing the reply again. So the fix propagation has been committed. Would suggest to test everything again with a newer build. If there are still some issues in there submit them one per report. For the level 0 I think this was bout drawing mask on multires, then going to level 0 which will not have the mask. This is how the current design work (as I've mentioned before multires and non-multires masks are separate). This is not considered a bug.

@Sergey Okay, but what makes masking so unique that it can't be propagated from level 0 and up? Face Sets is a brand new feature yet it propagates its colours to every level, including level 0. I know that in ZBRush it works the same way with the mask propagating from the base mesh up to the highest subdiv level. I honestly think it would be a good idea to at least consider it as a known issue if you are not going to mark it as a bug.

@Sergey Okay, but what makes masking so unique that it can't be propagated from level 0 and up? Face Sets is a brand new feature yet it propagates its colours to every level, including level 0. I know that in ZBRush it works the same way with the mask propagating from the base mesh up to the highest subdiv level. I honestly think it would be a good idea to at least consider it as a known issue if you are not going to mark it as a bug.
Regnas commented 3 years ago

Added subscriber: @Regnas

Added subscriber: @Regnas
Regnas commented 3 years ago

In #76386#930609, @Sergey wrote:
This is how the current design work (as I've mentioned before multires and non-multires masks are separate). This is not considered a bug.

Ok. But this behavior is not desirable at all, and certainly feels like a glitch. So I hope it can be changed at some point in the future.

> In #76386#930609, @Sergey wrote: > This is how the current design work (as I've mentioned before multires and non-multires masks are separate). This is not considered a bug. Ok. But this behavior is not desirable at all, and certainly feels like a glitch. So I hope it can be changed at some point in the future.
Sergey commented 3 years ago
Owner

Face Sets were likely designed keeping propagation from level 0 all the way in mind. This is not how mask was initially implemented,
It is surely always possible to upgrade existing designs, but this happens outside of the bug tracker.

Face Sets were likely designed keeping propagation from level 0 all the way in mind. This is not how mask was initially implemented, It is surely always possible to upgrade existing designs, but this happens outside of the bug tracker.

@Sergey I have had the chance to test MultiRes masking with the bug fix patch now. Although it is better, masking is still not fixed properly. Here is a video demonstration showing that deleting the mask does not actually remove the entire mask from all subdiv levels by having mask artefacts remaining at the edges of your mask:

Desktop 2020.05.17 - 00.35.46.01.mp4

When you delete a mask, it should be deleted completely across all levels. Until this is fixed, my bug report remains valid.

@Sergey I have had the chance to test MultiRes masking with the bug fix patch now. Although it is better, masking is still not fixed properly. Here is a video demonstration showing that deleting the mask does not actually remove the entire mask from all subdiv levels by having mask artefacts remaining at the edges of your mask: [Desktop 2020.05.17 - 00.35.46.01.mp4](https://archive.blender.org/developer/F8539378/Desktop_2020.05.17_-_00.35.46.01.mp4) When you delete a mask, it should be deleted completely across all levels. Until this is fixed, my bug report remains valid.
Sergey commented 3 years ago
Owner

Please submit new report for that.

Please submit new report for that.
@Sergey Done. https://developer.blender.org/T76862

Added subscriber: @Edvard-Svensson

Added subscriber: @Edvard-Svensson

Removed subscriber: @Edvard-Svensson

Removed subscriber: @Edvard-Svensson
Sign in to join this conversation.
No Label
Interest/Alembic
Interest/Animation & Rigging
Interest/Asset Browser
Interest/Asset Browser Project Overview
Interest/Audio
Interest/Automated Testing
Interest/Blender Asset Bundle
Interest/Collada
Interest/Compositing
Interest/Core
Interest/Cycles
Interest/Dependency Graph
Interest/Development Management
Interest/Eevee & Viewport
Interest/Freestyle
Interest/Geometry Nodes
Interest/Grease Pencil
Interest/Images & Movies
Interest/Import/Export
Interest/Line Art
Interest/Masking
Interest/Modeling
Interest/Modifiers
Interest/Motion Tracking
Interest/Overrides
Interest/Performance
Interest/Pipeline, Assets & I/O
Interest/Translations
Interest/Undo
Interest/USD
Interest/Video Sequencer
legacy module/Animation & Rigging
legacy module/Core
legacy module/Development Management
legacy module/Eevee & Viewport
legacy module/Grease Pencil
legacy module/Modeling
legacy module/Nodes & Physics
legacy module/Pipeline, Assets & IO
legacy module/Platforms, Builds, Tests & Devices
legacy module/Python API
legacy module/Rendering & Cycles
legacy module/Sculpt, Paint & Texture
legacy module/Triaging
legacy module/User Interface
legacy module/VFX & Video
legacy project/1.0.0-beta.2
legacy project/Asset Browser (Archived)
legacy project/BF Blender: 2.8
legacy project/BF Blender: After Release
legacy project/BF Blender: Next
legacy project/BF Blender: Regressions
legacy project/BF Blender: Unconfirmed
legacy project/Blender 2.70
legacy project/Code Quest
legacy project/Datablocks and Libraries
legacy project/Eevee
legacy project/Game Animation
legacy project/Game Audio
legacy project/Game Data Conversion
legacy project/Game Engine
legacy project/Game Logic
legacy project/Game Physics
legacy project/Game Python
legacy project/Game Rendering
legacy project/Game UI
legacy project/GPU / Viewport
legacy project/GSoC
legacy project/Infrastructure: Websites
legacy project/LibOverrides - Usability and UX
legacy project/Milestone 1: Basic, Local Asset Browser
legacy project/Nodes
legacy project/Nodes & Physics
legacy project/OpenGL Error
legacy project/Papercut
legacy project/Performance
legacy project/Physics
legacy project/Platforms, Builds, Tests & Devices
legacy project/Pose Library Basics
legacy project/Python API
legacy project/Render & Cycles
legacy project/Render Pipeline
legacy project/Retrospective
legacy project/Sculpt, Paint & Texture
legacy project/Text Editor
legacy project/Tracker Curfew
legacy project/Triaging
legacy project/User Interface
legacy project/UV Editing
legacy project/VFX & Video
legacy project/Virtual Reality
legacy project/Wintab High Frequency
Meta/Good First Issue
Meta/Papercut
migration/requires-manual-verification
Module › Animation & Rigging
Module › Core
Module › Development Management
Module › Eevee & Viewport
Module › Grease Pencil
Module › Modeling
Module › Nodes & Physics
Module › Pipeline, Assets & IO
Module › Platforms, Builds, Tests & Devices
Module › Python API
Module › Render & Cycles
Module › Sculpt, Paint & Texture
Module › Triaging
Module › User Interface
Module › VFX & Video
Platform/FreeBSD
Platform/Linux
Platform/macOS
Platform/Windows
Priority › High
Priority › Low
Priority › Normal
Priority › Unbreak Now!
Status › Archived
Status › Confirmed
Status › Duplicate
Status › Needs Information from Developers
Status › Needs Information from User
Status › Needs Triage
Status › Resolved
Type › Bug
Type › Design
Type › Known Issue
Type › Patch
Type › Report
Type › To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#76386
Loading…
There is no content yet.